dmaengine: idxd: Fix missing error code in idxd_cdev_open()
Subsystems (2)
PATCH 1/1 dmaengine: idxd: Fix missing error code in idxd_cdev_open()
The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'.
Eliminate the follow smatch warning:
drivers/dma/idxd/cdev.c:113 idxd_cdev_open() warn: missing error code 'rc'.
Reported-by Abaci Robot <[email protected]>
Signed-off-by Jiapeng Chong <[email protected]>
--- drivers/dma/idxd/cdev.c | 1 + 1 file changed, 1 insertion(+)
drivers/dma/idxd/cdev.c +1 -0
@@ -110,6 +110,7 @@ static int idxd_cdev_open(struct inode *inode, struct file *filp) pasid =iommu_sva_get_pasid (sva);if (pasid ==IOMMU_PASID_INVALID ) {iommu_sva_unbind_device (sva); + rc = -EINVAL ; goto failed; }
Signature · 1 line
1.8.3.1
Quoted 10 lines · Jiapeng Chong
The error code is missing in this code scenario, add the error code '
-EINVAL' to the return value 'rc'.Eliminate the follow smatch warning:
drivers/dma/idxd/cdev.c:113idxd_cdev_open()warn: missing error code 'rc'.Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Chong <[email protected]>
Acked-by Dave Jiang <[email protected]>
Quoted 16 lines
--- drivers/dma/idxd/cdev.c | 1 + 1 file changed, 1 insertion(+)drivers/dma/idxd/cdev.c +1
-0@@ -110,6 +110,7 @@ static int idxd_cdev_open(struct inode *inode, struct file *filp) pasid =iommu_sva_get_pasid (sva);if (pasid ==IOMMU_PASID_INVALID ) {iommu_sva_unbind_device (sva); + rc = -EINVAL ; goto failed; }
Quoted 7 lines · Jiapeng Chong
The error code is missing in this code scenario, add the error code '
-EINVAL' to the return value 'rc'.Eliminate the follow smatch warning:
drivers/dma/idxd/cdev.c:113idxd_cdev_open()warn: missing error code 'rc'.
Applied, thanks
Signature · 1 line
~Vinod