arm64: dts: qcom: sc7180: Add DisplayPort node
Subsystems (4)
PATCH v4 1/1 arm64: dts: qcom: sc7180: Add DisplayPort node
Add DP device node on sc7180.
---
Changes in v2:
-- replace msm_dp with dp
-- replace dp_opp_table with opp_table
Changes in v3:
-- correct text of commit title
Changes in v4:
-- replace dp with mdss_dp
-- replace opp_table with dp_opp_table
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9 ++++ arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++ 2 files changed, 87 insertions(+)
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +9 -0
@@ -786,6 +786,15 @@ hp_i2c: &i2c9 { status = "okay"; }; +&mdss_dp { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&dp_hot_plug_det>; + data-lanes = <0 1>; + vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; +}; + &pm6150_adc { charger-thermistor@4f { reg = <ADC5_AMUX_THM3_100K_PU>;
arch/arm64/boot/dts/qcom/sc7180.dtsi +78 -0
90 lines not on this page · raw message
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 98 lines · Kuogee Hsieh
Add DP device node on sc7180.
Signed-off-by Kuogee Hsieh <[email protected]>---
Changes in v2:
-- replacemsm_dpwith dp
-- replacedp_opp_tablewithopp_tableChanges in v3:
-- correct text of commit titleChanges in v4:
-- replace dp withmdss_dp
-- replaceopp_tablewithdp_opp_tablearch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9 ++++ arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++ 2 files changed, 87 insertions(+)arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +9
-0@@ -786,6 +786,15 @@ hp_i2c: &i2c9 { status = "okay"; }; +&mdss_dp { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&dp_hot_plug_det>; + data-lanes = <0 1>; + vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; +}; + &pm6150_adc { charger-thermistor@4f { reg = <ADC5_AMUX_THM3_100K_PU>;arch/arm64/boot/dts/qcom/sc7180.dtsi +43
-0@@ -3032,6 +3032,13 @@ remote-endpoint = <&dsi0_in>; }; }; + + port@2 { + reg = <2>; + dpu_intf0_out: endpoint { + remote-endpoint = <&dp_in>; + }; + }; }; mdp_opp_table: mdp-opp-table {@@ -3148,6 +3155,77 @@ status = "disabled"; }; + + mdss_dp: displayport-controller@ae90000 { + compatible = "qcom,sc7180-dp"; + status = "disabled"; + + reg = <0 0x0ae90000 0 0x1400>; + + interrupt-parent = <&mdss>; + interrupts = <12>; + + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, + <&dispcc DISP_CC_MDSS_DP_AUX_CLK>, + <&dispcc DISP_CC_MDSS_DP_LINK_CLK>, + <&dispcc DISP_CC_MDSS_DP_LINK_INTF_CLK>, + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>; + clock-names = "core_iface", "core_aux", "ctrl_link", + "ctrl_link_iface", "stream_pixel"; + #clock-cells = <1>; + assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>, + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>; + assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>; + phys = <&dp_phy>; + phy-names = "dp"; + + operating-points-v2 = <&dp_opp_table>; + power-domains = <&rpmhpd SC7180_CX>; + + #sound-dai-cells = <0>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + dp_in: endpoint { + remote-endpoint = <&dpu_intf0_out>;
arch/arm64/boot/dts/qcom/sc7180.dtsi line 3203
Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +10
-0+ }; + }; + + port@1 { + reg = <1>; + dp_out: endpoint { }; + }; + }; + + dp_opp_table: dp-opp-table {
I forgot that our discussion about the node name here was on the previous revision, _this_ is the patch I will drop the "dp-" from and apply.
And as I've looked at this quite a bit now:
Thanks for following up on the other feedback!
Regards,
Bjorn
Quoted 32 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +25
-0+ compatible = "operating-points-v2"; + + opp-160000000 { + opp-hz = /bits/ 64 <160000000>; + required-opps = <&rpmhpd_opp_low_svs>; + }; + + opp-270000000 { + opp-hz = /bits/ 64 <270000000>; + required-opps = <&rpmhpd_opp_svs>; + }; + + opp-540000000 { + opp-hz = /bits/ 64 <540000000>; + required-opps = <&rpmhpd_opp_svs_l1>; + }; + + opp-810000000 { + opp-hz = /bits/ 64 <810000000>; + required-opps = <&rpmhpd_opp_nom>; + }; + }; + }; + + }; dispcc: clock-controller@af00000 {Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Stephen Boyd
Reviewed-byQuoting Bjorn Andersson (2021-06-25 09:13:45)
Quoted 7 lines · Kuogee Hsieh
arch/arm64/boot/dts/qcom/sc7180.dtsi line 3203
Quoted 5 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +5
-0+ dp_out: endpoint { }; + }; + }; + + dp_opp_table: dp-opp-table {
Quoted 8 lines
I forgot that our discussion about the node name here was on the previous revision, _this_ is the patch I will drop the "dp-" from and apply.
And as I've looked at this quite a bit now:
Reviewed-by Bjorn Andersson <[email protected]>
With that node name fixed