Skip to contentSkip to conversation

net:cxgb3: fix incorrect work cancellation

PATCH Applied Íñigo Huguet 2 participants 2 messages Jun 4, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net:cxgb3: fix incorrect work cancellation

In my last changes in commit 5e0b8928927f I introduced a copy-paste bug, leading to cancel twice qresume_task work for OFLD queue, and never the one for CTRL queue. This patch cancels correctly both works.

---
 drivers/net/ethernet/chelsio/cxgb3/sge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/chelsio/cxgb3/sge.c +1 -1
index fa91aa57b50a..d1dfccdf571d 100644
@@ -3310,7 +3310,7 @@ void t3_sge_stop(struct adapter *adap)
 		struct sge_qset *qs = &adap->sge.qs[i];
 
 		cancel_work_sync(&qs->txq[TXQ_OFLD].qresume_task);
-		cancel_work_sync(&qs->txq[TXQ_OFLD].qresume_task);
+		cancel_work_sync(&qs->txq[TXQ_CTRL].qresume_task);
 	}
 }
 
Signature · 1 line
2.31.1
#1 lore raw
This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 8 lines · On Fri, 4 Jun 2021 13:36:33 +0200 you wrote:

In my last changes in commit 5e0b8928927f I introduced a copy-paste bug, leading to cancel twice qresume_task work for OFLD queue, and never the one for CTRL queue. This patch cancels correctly both works.

---
 drivers/net/ethernet/chelsio/cxgb3/sge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- net:cxgb3: fix incorrect work cancellation

    https://git.kernel.org/netdev/net-next/c/d5a73dcf0901

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html