pull request for net: batman-adv 2021-06-08
Subsystems (3)
Simon Wunderlich
maintainercover pull request for net: batman-adv 2021-06-08
Hi David, hi Jakub,
here is a bugfix for batman-adv which we would like to have integrated into net.
Please pull or let me know of any problem!
Thank you,
Simon
The following changes since commit b741596468b010af2846b75f5e75a842ce344a6e:
Merge tag 'riscv-for-linus-5.13-mw1' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux (2021-05-08 11:52:37 -0700)
are available in the Git repository at:
git://git.open-mesh.org/linux-merge.git tags/batadv-net-pullrequest-20210608
for you to fetch changes up to 9f460ae31c4435fd022c443a6029352217a16ac1:
batman-adv: Avoid WARN_ON timing related checks (2021-05-18 21:10:01 +0200)
----------------------------------------------------------------
Here is a batman-adv bugfix:
- Avoid WARN_ON timing related checks, by Sven Eckelmann
----------------------------------------------------------------
Sven Eckelmann (1):
batman-adv: Avoid WARN_ON timing related checks
net/batman-adv/bat_iv_ogm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Simon Wunderlich
maintainerPATCH 1/1 batman-adv: Avoid WARN_ON timing related checks
From: Sven Eckelmann <[email protected]>
The soft/batadv interface for a queued OGM can be changed during the time the OGM was queued for transmission and when the OGM is actually transmitted by the worker.
But WARN_ON must be used to denote kernel bugs and not to print simple warnings. A warning can simply be printed using pr_warn.
--- net/batman-adv/bat_iv_ogm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/batman-adv/bat_iv_ogm.c +3 -1
@@ -409,8 +409,10 @@ static void batadv_iv_ogm_emit(struct batadv_forw_packet *forw_packet)if (WARN_ON (!forw_packet->if_outgoing))return ; -if (WARN_ON (forw_packet->if_outgoing->soft_iface != soft_iface)) +if (forw_packet->if_outgoing->soft_iface != soft_iface) { +pr_warn ("%s: soft interface switch for queued OGM\n" , __func__);return ; + }if (forw_packet->if_incoming->if_status !=BATADV_IF_ACTIVE )return ;
Signature · 1 line
2.20.1
Re: [PATCH 1/1] batman-adv: Avoid WARN_ON timing related checks
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 10 lines · On Tue, 8 Jun 2021 17:29:47 +0200 you wrote:
From: Sven Eckelmann <[email protected]>
The soft/batadv interface for a queued OGM can be changed during the time the OGM was queued for transmission and when the OGM is actually transmitted by the worker.
But
WARN_ONmust be used to denote kernel bugs and not to print simple warnings. A warning can simply be printed usingpr_warn.[...]
Here is the summary with links:
- [1/1] batman-adv: Avoid WARN_ON timing related checks
https://git.kernel.org/netdev/net/c/9f460ae31c44
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html