ethernet/qlogic: Use list_for_each_entry() to simplify code in qlcnic_hw.c
Subsystems (3)
PATCH 1/1 ethernet/qlogic: Use list_for_each_entry() to simplify code in qlcnic_hw.c
Convert list_for_each() to list_for_each_entry() where applicable. This simplifies the code.
Reported-by Hulk Robot <[email protected]>
Signed-off-by Wang Hai <[email protected]>
--- drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c +2 -6
@@ -460,12 +460,10 @@ int qlcnic_82xx_sre_macaddr_change(struct qlcnic_adapter *adapter, u8 *addr,int qlcnic_nic_del_mac (struct qlcnic_adapter *adapter,const u8 *addr) {struct qlcnic_mac_vlan_list *cur; -struct list_head *head;int err = -EINVAL ;/* Delete MAC from the existing list */ -list_for_each (head, &adapter->mac_list) { - cur = list_entry(head, struct qlcnic_mac_vlan_list, list); +list_for_each_entry (cur, &adapter->mac_list, list) {if (ether_addr_equal (addr, cur->mac_addr)) { err =qlcnic_sre_macaddr_change (adapter, cur->mac_addr,0 ,QLCNIC_MAC_DEL );
@@ -483,11 +481,9 @@ int qlcnic_nic_add_mac(struct qlcnic_adapter *adapter, const u8 *addr, u16 vlan, enum qlcnic_mac_type mac_type) {struct qlcnic_mac_vlan_list *cur; -struct list_head *head;/* look up if already exists */ -list_for_each (head, &adapter->mac_list) { - cur = list_entry(head, struct qlcnic_mac_vlan_list, list); +list_for_each_entry (cur, &adapter->mac_list, list) {if (ether_addr_equal (addr, cur->mac_addr) && cur->vlan_id == vlan)return 0 ;
Signature · 1 line
2.17.1
This patch was applied to netdev/net-next.git (refs/heads/master):
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
Quoted 8 lines · On Tue, 8 Jun 2021 13:29:08 +0000 you wrote:
Convert
list_for_each()tolist_for_each_entry()where applicable. This simplifies the code.Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>--- drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
Here is the summary with links:
- [net-next] ethernet/qlogic: Use list_for_each_entry() to simplify code in qlcnic_hw.c
https://git.kernel.org/netdev/net-next/c/78595dfcb29b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html