Skip to contentSkip to conversation

net: hns3: use list_move_tail instead of list_del/list_add_tail in hclgevf_main.c

PATCH Applied Baokun Li 2 participants 2 messages Jun 9, 2021

Subsystems (5)
lore
Share & tools
lore

Baokun Li

author
#0 lore raw

PATCH v2 1/1 net: hns3: use list_move_tail instead of list_del/list_add_tail in hclgevf_main.c

Using list_move_tail() instead of list_del() + list_add_tail() in hclgevf_main.c.

---
V1->V2:
CC mailist

 .../hisilicon/hns3/hns3vf/hclgevf_main.c     | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c +3 -6
index f84b3a135c06..52eaf82b7cd7 100644
@@ -1536,8 +1536,7 @@ static void hclgevf_sync_from_add_list(struct list_head *add_list,
 			kfree(mac_node);
 		} else if (mac_node->state == HCLGEVF_MAC_ACTIVE) {
 			mac_node->state = HCLGEVF_MAC_TO_DEL;
-			list_del(&mac_node->node);
-			list_add_tail(&mac_node->node, mac_list);
+			list_move_tail(&mac_node->node, mac_list);
 		} else {
 			list_del(&mac_node->node);
 			kfree(mac_node);
@@ -1562,8 +1561,7 @@ static void hclgevf_sync_from_del_list(struct list_head *del_list,
 			list_del(&mac_node->node);
 			kfree(mac_node);
 		} else {
-			list_del(&mac_node->node);
-			list_add_tail(&mac_node->node, mac_list);
+			list_move_tail(&mac_node->node, mac_list);
 		}
 	}
 }
@@ -1599,8 +1597,7 @@ static void hclgevf_sync_mac_list(struct hclgevf_dev *hdev,
 	list_for_each_entry_safe(mac_node, tmp, list, node) {
 		switch (mac_node->state) {
 		case HCLGEVF_MAC_TO_DEL:
-			list_del(&mac_node->node);
-			list_add_tail(&mac_node->node, &tmp_del_list);
+			list_move_tail(&mac_node->node, &tmp_del_list);
 			break;
 		case HCLGEVF_MAC_TO_ADD:
 			new_node = kzalloc(sizeof(*new_node), GFP_ATOMIC);
#1 lore raw
This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 9 lines · On Wed, 9 Jun 2021 15:17:20 +0800 you wrote:

Using list_move_tail() instead of list_del() + list_add_tail() in hclgevf_main.c.

---
V1->V2:
CC mailist

[...]

Here is the summary with links:
- [net-next,v2] net: hns3: use list_move_tail instead of list_del/list_add_tail in hclgevf_main.c

    https://git.kernel.org/netdev/net-next/c/49768ce98c2c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html