net: stmmac: Fix mixed enum type warning
Subsystems (4)
PATCH 1/1 net: stmmac: Fix mixed enum type warning
The commit 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking procedure") introduced the following coverity warning:
"Parse warning (PW.MIXED_ENUM_TYPE)"
"1. mixed_enum_type: enumerated type mixed with another type"
This is due to both "lo_state" and "lp_sate" which their datatype are enum stmmac_fpe_state type, and being assigned with "FPE_EVENT_UNKNOWN" which is a macro-defined of 0. Fixed this by assigned both these variables with the correct enum value.
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +2 -2
@@ -1021,8 +1021,8 @@ static void stmmac_fpe_link_state_handle(struct stmmac_priv *priv, bool is_up)if (is_up && *hs_enable) {stmmac_fpe_send_mpacket (priv, priv->ioaddr,MPACKET_VERIFY ); }else { - *lo_state =FPE_EVENT_UNKNOWN ; - *lp_state =FPE_EVENT_UNKNOWN ; + *lo_state =FPE_STATE_OFF ; + *lp_state =FPE_STATE_OFF ; } }
Signature · 1 line
2.25.1
This patch was applied to netdev/net-next.git (refs/heads/master):
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
Quoted 6 lines · On Thu, 10 Jun 2021 16:53:54 +0800 you wrote:
The commit
5a5586112b92("net: stmmac: support FPE link partner hand-shaking procedure") introduced the following coverity warning:"Parse warning (PW.MIXED_ENUM_TYPE)"
"1.mixed_enum_type: enumerated type mixed with another type"
Quoted 6 lines
This is due to both "
lo_state" and "lp_sate" which their datatype are enumstmmac_fpe_statetype, and being assigned with "FPE_EVENT_UNKNOWN" which is a macro-defined of 0. Fixed this by assigned both these variables with the correct enum value.[...]
Here is the summary with links:
- [net-next,v1,1/1] net: stmmac: Fix mixed enum type warning
https://git.kernel.org/netdev/net-next/c/1f7096f0fdb2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html