Skip to contentSkip to conversation

r_du_lvdsenc.c : Check return value of devm_ioremap_resource with IS_ERR

PATCH In review ethan.zhao 2 participants 3 messages Dec 8, 2013 – Dec 10, 2013

Subsystems (3)
lore
Share & tools
lore

ethan.zhao

author
#0 lore raw

PATCH 1/1 r_du_lvdsenc.c : Check return value of devm_ioremap_resource with IS_ERR

function devm_ioremap_resource() doesn't return NULL, should check its return value with helper IS_ERR().

---
 drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c +1 -1
index a0f6a17..93190ab 100644
@@ -151,7 +151,7 @@ static int rcar_du_lvdsenc_get_resources(struct rcar_du_lvdsenc *lvds,
 	}
 
 	lvds->mmio = devm_ioremap_resource(&pdev->dev, mem);
-	if (lvds->mmio == NULL) {
+	if (IS_ERR(lvds->mmio)) {
 		dev_err(&pdev->dev, "failed to remap memory resource for %s\n",
 			name);
 		return -ENOMEM;
Signature · 1 line
1.8.3.4 (Apple Git-47)
#1 lore raw

Hi Ethan,

Thank you for the patch.

Quoted 4 lines · On Sunday 08 December 2013 10:41:46 ethan.zhao wrote:

function devm_ioremap_resource() doesn't return NULL, should check its return value with helper IS_ERR().

This issue has already been addressed by a patch sent to the dri-devel mailing list by Wei Yongjun (https://lkml.org/lkml/2013/8/22/637).

I've asked for a v2 to be submitted but haven't received any reply. I'll fix the problem myself and send the patch now.

Quoted 17 lines
---
 drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c index a0f6a17..93190ab 100644

drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c +1 -1
@@ -151,7 +151,7 @@ static int rcar_du_lvdsenc_get_resources(struct
 rcar_du_lvdsenc *lvds, }
 
 	lvds->mmio = devm_ioremap_resource(&pdev->dev, mem);
-	if (lvds->mmio == NULL) {
+	if (IS_ERR(lvds->mmio)) {
 		dev_err(&pdev->dev, "failed to remap memory resource for %s\n",
 			name);
 		return -ENOMEM;
Signature · 3 lines
Regards,

Laurent Pinchart
author
#2 lore raw

Laurent,

Next time I scan the NULL check, if hit your driver again, I will resend it.

Thanks,
Ethan

Quoted 39 lines · Laurent Pinchart

Hi Ethan,

Thank you for the patch.

Quoted 4 lines · On Sunday 08 December 2013 10:41:46 ethan.zhao wrote:

function devm_ioremap_resource() doesn't return NULL, should check its return value with helper IS_ERR().

This issue has already been addressed by a patch sent to the dri-devel mailing list by Wei Yongjun (https://lkml.org/lkml/2013/8/22/637).

I've asked for a v2 to be submitted but haven't received any reply. I'll fix the problem myself and send the patch now.

Quoted 9 lines
---
 drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c index a0f6a17..93190ab 100644

drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c static int rcar_du_lvdsenc_get_resources(struct · line 157

Quoted 8 lines
drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c +1 -1
@@ -151,7 +151,7 @@ static int rcar_du_lvdsenc_get_resources(struct
 rcar_du_lvdsenc *lvds, }
 
      lvds->mmio = devm_ioremap_resource(&pdev->dev, mem);
-     if (lvds->mmio == NULL) {
+     if (IS_ERR(lvds->mmio)) {
              dev_err(&pdev->dev, "failed to remap memory resource for %s\n",
                      name);
              return -ENOMEM;

--
Regards,

Laurent Pinchart