spi: remove spi_set_cs_timing()
PATCH 1/1 spi: remove spi_set_cs_timing()
No one seems to be using this global and exported function, so remove it as it is no longer needed.
--- drivers/spi/spi.c | 73 ----------------------------------------- include/linux/spi/spi.h | 5 --- 2 files changed, 78 deletions(-)
drivers/spi/spi.c +0 -73
@@ -3453,79 +3453,6 @@ int spi_setup(struct spi_device *spi) }EXPORT_SYMBOL_GPL (spi_setup); -/** -* spi_set_cs_timing - configure CS setup, hold, and inactive delays -* @spi: the device that requires specific CS timing configuration -* @setup: CS setup time specified via @spi_delay -* @hold: CS hold time specified via @spi_delay -* @inactive: CS inactive delay between transfers specified via @spi_delay -* -* Return: zero on success, else a negative error code. -*/ -int spi_set_cs_timing (struct spi_device *spi,struct spi_delay *setup, -struct spi_delay *hold,struct spi_delay *inactive) -{ -struct device *parent = spi->controller->dev.parent; -size_t len; -int status; - -if (spi->controller->set_cs_timing && - !(spi->cs_gpiod ||gpio_is_valid (spi->cs_gpio))) { -mutex_lock (&spi->controller->io_mutex); - -if (spi->controller->auto_runtime_pm) { - status =pm_runtime_get_sync (parent); -if (status <0 ) { -mutex_unlock (&spi->controller->io_mutex); -pm_runtime_put_noidle (parent); -dev_err (&spi->controller->dev,"Failed to power device: %d\n" , - status); -return status; - } - - status = spi->controller->set_cs_timing (spi, setup, - hold, inactive); -pm_runtime_mark_last_busy (parent); -pm_runtime_put_autosuspend (parent); - }else { - status = spi->controller->set_cs_timing (spi, setup, hold, - inactive); - } - -mutex_unlock (&spi->controller->io_mutex); -return status; - } - -if ((setup && setup->unit ==SPI_DELAY_UNIT_SCK ) || - (hold && hold->unit ==SPI_DELAY_UNIT_SCK ) || - (inactive && inactive->unit ==SPI_DELAY_UNIT_SCK )) { -dev_err (&spi->dev, -"Clock-cycle delays for CS not supported in SW mode\n" ); -return -ENOTSUPP ; - } - - len =sizeof (struct spi_delay ); - -/* copy delays to controller */ -if (setup) -memcpy (&spi->controller->cs_setup, setup, len); -else -memset (&spi->controller->cs_setup,0 , len); - -if (hold) -memcpy (&spi->controller->cs_hold, hold, len); -else -memset (&spi->controller->cs_hold,0 , len); - -if (inactive) -memcpy (&spi->controller->cs_inactive, inactive, len); -else -memset (&spi->controller->cs_inactive,0 , len); - -return 0 ; -} -EXPORT_SYMBOL_GPL (spi_set_cs_timing); -static int _spi_xfer_word_delay_update (struct spi_transfer *xfer,struct spi_device *spi) {
include/linux/spi/spi.h +0 -5
@@ -1108,11 +1108,6 @@ static inline void spi_message_free(struct spi_message *m)kfree (m); } -extern int spi_set_cs_timing (struct spi_device *spi, -struct spi_delay *setup, -struct spi_delay *hold, -struct spi_delay *inactive); -extern int spi_setup (struct spi_device *spi);extern int spi_async (struct spi_device *spi,struct spi_message *message); extern int spi_async_locked(struct spi_device *spi,
Signature · 1 line
2.32.0
Mark Brown
maintainerQuoted 2 lines · Greg Kroah-Hartman
No one seems to be using this global and exported function, so remove it as it is no longer needed.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: remove spi_set_cs_timing()
commit: 4ccf359849ce709f4bf0214b4b5b8b6891d38770
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
CC leilk, Alexandru Ardelean
Quoted 22 lines · Mark Brown
Quoted 2 lines · Greg Kroah-Hartman
No one seems to be using this global and exported function, so remove it as it is no longer needed.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: remove
spi_set_cs_timing()commit: 4ccf359849ce709f4bf0214b4b5b8b6891d38770All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
Quoted 6 lines
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds