net: dsa: sja1105: constify the sja1105_regs structures
Vladimir Oltean
maintainerPATCH 1/1 net: dsa: sja1105: constify the sja1105_regs structures
From: Vladimir Oltean <[email protected]>
The struct sja1105_regs tables are not modified during the runtime of the driver, so they can be made constant. In fact, struct sja1105_info already holds a const pointer to these.
--- drivers/net/dsa/sja1105/sja1105_spi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/dsa/sja1105/sja1105_spi.c +3 -3
@@ -404,7 +404,7 @@ int sja1105_static_config_upload(struct sja1105_private *priv)return rc; } -static struct sja1105_regs sja1105et_regs = { +static const struct sja1105_regs sja1105et_regs = { .device_id =0x0 , .prod_id =0x100BC3 , .status =0x1 ,
@@ -440,7 +440,7 @@ static struct sja1105_regs sja1105et_regs = { .mdio_100base_t1 = SJA1105_RSV_ADDR, }; -static struct sja1105_regs sja1105pqrs_regs = { +static const struct sja1105_regs sja1105pqrs_regs = { .device_id =0x0 , .prod_id =0x100BC3 , .status =0x1 ,
@@ -479,7 +479,7 @@ static struct sja1105_regs sja1105pqrs_regs = { .mdio_100base_t1 = SJA1105_RSV_ADDR, }; -static struct sja1105_regs sja1110_regs = { +static const struct sja1105_regs sja1110_regs = { .device_id =SJA1110_SPI_ADDR (0x0 ), .prod_id =SJA1110_ACU_ADDR (0xf00 ), .status =SJA1110_SPI_ADDR (0x4 ),
Signature · 1 line
2.25.1
Quoted 7 lines · Vladimir Oltean
From: Vladimir Oltean <[email protected]>
The struct
sja1105_regstables are not modified during the runtime of the driver, so they can be made constant. In fact, structsja1105_infoalready holds a const pointer to these.Signed-off-by Vladimir Oltean <[email protected]>
Signature · 1 line
Florian
This patch was applied to netdev/net-next.git (refs/heads/master):
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
Quoted 9 lines · On Mon, 14 Jun 2021 16:50:50 +0300 you wrote:
From: Vladimir Oltean <[email protected]>
The struct
sja1105_regstables are not modified during the runtime of the driver, so they can be made constant. In fact, structsja1105_infoalready holds a const pointer to these.Signed-off-by Vladimir Oltean <[email protected]>[...]
Here is the summary with links:
- [net-next] net: dsa: sja1105: constify the sja1105_regs structures
https://git.kernel.org/netdev/net-next/c/3009e8aa85af
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html