Skip to contentSkip to conversation

net: mhi_net: Update the transmit handler prototype

PATCH Applied Subash Abhinov Kasiviswanathan 2 participants 2 messages Jun 14, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: mhi_net: Update the transmit handler prototype

Update the function prototype of mhi_ndo_xmit to match ndo_start_xmit. This otherwise leads to run time failures when CFI is enabled in kernel.

Fixes 3ffec6a14f24 ("net: Add mhi-net driver")
---
 drivers/net/mhi/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mhi/net.c +1 -1
index 64af1e5..bbbbf6c 100644
@@ -56,7 +56,7 @@ static int mhi_ndo_stop(struct net_device *ndev)
 	return 0;
 }
 
-static int mhi_ndo_xmit(struct sk_buff *skb, struct net_device *ndev)
+static netdev_tx_t mhi_ndo_xmit(struct sk_buff *skb, struct net_device *ndev)
 {
 	struct mhi_net_dev *mhi_netdev = netdev_priv(ndev);
 	const struct mhi_net_proto *proto = mhi_netdev->proto;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#1 lore raw
This patch was applied to netdev/net.git (refs/heads/master):

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

Quoted 8 lines · On Mon, 14 Jun 2021 15:03:25 -0600 you wrote:

Update the function prototype of mhi_ndo_xmit to match ndo_start_xmit. This otherwise leads to run time failures when CFI is enabled in kernel.

Fixes 3ffec6a14f24 ("net: Add mhi-net driver")

[...]

Here is the summary with links:
- [net] net: mhi_net: Update the transmit handler prototype

    https://git.kernel.org/netdev/net/c/2214fb53006e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html