remoteproc: qcom: Minidump improvements
Subsystems (2)
cover remoteproc: qcom: Minidump improvements
This patchset adds a fallback mechanism to the minidump flow for remoteprocs which do not support minidump in its firmware.
Patch 1: Export the base coredump APIs to allow for fallback mechanism. Patch 2: Fallback to full coredumps when SMEM is not initialized at all.
Siddharth Gupta (2):
remoteproc: core: Export the rproc coredump APIs
remoteproc: qcom: Add full coredump fallback mechanism
drivers/remoteproc/qcom_common.c | 9 +++++++-- drivers/remoteproc/qcom_q6v5_pas.c | 1 + drivers/remoteproc/remoteproc_coredump.c | 2 ++ drivers/remoteproc/remoteproc_internal.h | 4 ---- include/linux/remoteproc.h | 4 ++++ 5 files changed, 14 insertions(+), 6 deletions(-)
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH 1/2 remoteproc: core: Export the rproc coredump APIs
The remoteproc coredump APIs are currently only part of the internal remoteproc header. This prevents the remoteproc platform drivers from using these APIs when needed. This change moves the rproc_coredump() and rproc_coredump_cleanup() APIs to the linux header and marks them as exported symbols.
--- drivers/remoteproc/remoteproc_coredump.c | 2 ++ drivers/remoteproc/remoteproc_internal.h | 4 ---- include/linux/remoteproc.h | 4 ++++ 3 files changed, 6 insertions(+), 4 deletions(-)
drivers/remoteproc/remoteproc_coredump.c +2 -0
@@ -32,6 +32,7 @@ void rproc_coredump_cleanup(struct rproc *rproc)kfree (entry); } } +EXPORT_SYMBOL (rproc_coredump_cleanup);/** * rproc_coredump_add_segment() - add segment of device memory to coredump
@@ -327,6 +328,7 @@ void rproc_coredump(struct rproc *rproc)*/ wait_for_completion (&dump_state.dump_done); } +EXPORT_SYMBOL (rproc_coredump);/** * rproc_coredump_using_sections() - perform coredump using section headers
drivers/remoteproc/remoteproc_internal.h +0 -4
@@ -49,10 +49,6 @@ extern struct class rproc_class;int rproc_init_sysfs (void );void rproc_exit_sysfs (void ); -/* from remoteproc_coredump.c */ -void rproc_coredump_cleanup (struct rproc *rproc); -void rproc_coredump (struct rproc *rproc); -#ifdef CONFIG_REMOTEPROC_CDEV void rproc_init_cdev (void );void rproc_exit_cdev (void );
include/linux/remoteproc.h +4 -0
@@ -674,6 +674,10 @@ void rproc_shutdown(struct rproc *rproc);int rproc_detach (struct rproc *rproc);int rproc_set_firmware (struct rproc *rproc,const char *fw_name);void rproc_report_crash (struct rproc *rproc,enum rproc_crash_type type); + +/* from remoteproc_coredump.c */ +void rproc_coredump_cleanup (struct rproc *rproc); +void rproc_coredump (struct rproc *rproc);void rproc_coredump_using_sections (struct rproc *rproc);int rproc_coredump_add_segment (struct rproc *rproc,dma_addr_t da,size_t size); int rproc_coredump_add_custom_segment(struct rproc *rproc,
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH 2/2 remoteproc: qcom: Add full coredump fallback mechanism
In reply to Siddharth GuptaIf a remoteproc's firmware does not support minidump but the driver adds an ID, the minidump driver does not collect any coredumps when the remoteproc crashes. This hinders the purpose of coredump collection. This change adds a fallback mechanism in the event of a crash.
--- drivers/remoteproc/qcom_common.c | 9 +++++++-- drivers/remoteproc/qcom_q6v5_pas.c | 1 + 2 files changed, 8 insertions(+), 2 deletions(-)
drivers/remoteproc/qcom_common.c +7 -2
@@ -163,12 +163,17 @@ void qcom_minidump(struct rproc *rproc, unsigned int minidump_id)*/ if (subsystem->regions_baseptr ==0 ||le32_to_cpu (subsystem->status) !=1 || -le32_to_cpu (subsystem->enabled) !=MD_SS_ENABLED || -le32_to_cpu (subsystem->encryption_status) !=MD_SS_ENCR_DONE ) { +le32_to_cpu (subsystem->enabled) !=MD_SS_ENABLED ) { +return rproc_coredump (rproc); + } + +if (le32_to_cpu (subsystem->encryption_status) !=MD_SS_ENCR_DONE ) {dev_err (&rproc->dev,"Minidump not ready, skipping\n" );return ; } +rproc_coredump_cleanup (rproc); + ret =qcom_add_minidump_segments (rproc, subsystem);if (ret) {dev_err (&rproc->dev,"Failed with error: %d while adding minidump entries\n" , ret);
drivers/remoteproc/qcom_q6v5_pas.c +1 -0
@@ -274,6 +274,7 @@ static const struct rproc_ops adsp_minidump_ops = { .start = adsp_start, .stop = adsp_stop, .da_to_va = adsp_da_to_va, + .parse_fw = qcom_register_dump_segments, .load = adsp_load, .panic = adsp_panic, .coredump = adsp_minidump,
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project