net: qualcomm: rmnet: Remove some unneeded casts
Subsystems (3)
PATCH 1/1 net: qualcomm: rmnet: Remove some unneeded casts
Remove the explicit casts in the checksum complement functions and pass the actual protocol specific headers instead.
Signed-off-by Subash Abhinov Kasiviswanathan <[email protected]>
--- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c +5 -6
@@ -163,13 +163,12 @@ rmnet_map_ipv6_dl_csum_trailer(struct sk_buff *skb, }#endif -static void rmnet_map_complement_ipv4_txporthdr_csum_field (void *iphdr) +static void rmnet_map_complement_ipv4_txporthdr_csum_field (struct iphdr *ip4h) { -struct iphdr *ip4h = (struct iphdr *)iphdr;void *txphdr;u16 *csum; - txphdr = iphdr + ip4h->ihl *4 ; + txphdr = ip4h + ip4h->ihl *4 ;if (ip4h->protocol ==IPPROTO_TCP || ip4h->protocol ==IPPROTO_UDP ) { csum = (u16 *)rmnet_map_get_csum_field (ip4h->protocol, txphdr);
@@ -198,13 +197,13 @@ rmnet_map_ipv4_ul_csum_header(struct iphdr *iphdr, }#if IS_ENABLED (CONFIG_IPV6 ) -static void rmnet_map_complement_ipv6_txporthdr_csum_field (void *ip6hdr) +static void +rmnet_map_complement_ipv6_txporthdr_csum_field (struct ipv6hdr *ip6h) { -struct ipv6hdr *ip6h = (struct ipv6hdr *)ip6hdr;void *txphdr;u16 *csum; - txphdr = ip6hdr +sizeof (struct ipv6hdr ); + txphdr = ip6h +sizeof (struct ipv6hdr );if (ip6h->nexthdr ==IPPROTO_TCP || ip6h->nexthdr ==IPPROTO_UDP ) { csum = (u16 *)rmnet_map_get_csum_field (ip6h->nexthdr, txphdr);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
This patch was applied to netdev/net-next.git (refs/heads/master):
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
Quoted 7 lines · On Wed, 16 Jun 2021 01:59:13 -0600 you wrote:
Remove the explicit casts in the checksum complement functions and pass the actual protocol specific headers instead.
Signed-off-by Subash Abhinov Kasiviswanathan <[email protected]>--- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
Here is the summary with links:
- [net-next] net: qualcomm: rmnet: Remove some unneeded casts
https://git.kernel.org/netdev/net-next/c/56a967c4f7e5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html