powerpc/build: vdso linker warning for orphan sections
Nicholas Piggin
reviewerPATCH 1/1 powerpc/build: vdso linker warning for orphan sections
Add --orphan-handling=warn for vdsos, and adjust vdso linker scripts to deal with orphan sections.
--- arch/powerpc/kernel/vdso32/Makefile | 2 +- arch/powerpc/kernel/vdso32/vdso32.lds.S | 3 ++- arch/powerpc/kernel/vdso64/Makefile | 2 +- arch/powerpc/kernel/vdso64/vdso64.lds.S | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-)
arch/powerpc/kernel/vdso32/Makefile +1 -1
@@ -66,7 +66,7 @@ include/generated/vdso32-offsets.h: $(obj)/vdso32.so.dbg FORCE # actual build commands quiet_cmd_vdso32ld_and_check = VDSO32L $@ - cmd_vdso32ld_and_check = $(VDSOCC) $(c_flags) $(CC32FLAGS) -o $@ -Wl,-T$(filter %.lds,$^) $(filter %.o,$^) ; $(cmd_vdso_check) + cmd_vdso32ld_and_check = $(VDSOCC) $(c_flags) $(CC32FLAGS) -o $@ -Wl,-T$(filter %.lds,$^) $(filter %.o,$^) $(if $(CONFIG_LD_ORPHAN_WARN), -Wl$(comma)--orphan-handling=warn) ; $(cmd_vdso_check) quiet_cmd_vdso32as = VDSO32A $@ cmd_vdso32as = $(VDSOCC) $(a_flags) $(CC32FLAGS) -c -o $@ $< quiet_cmd_vdso32cc = VDSO32C $@
arch/powerpc/kernel/vdso32/vdso32.lds.S +2 -1
@@ -85,9 +85,10 @@ SECTIONS /DISCARD/ : { *(.note.GNU-stack) + *(.branch_lt) *(.data .data.* .gnu.linkonce.d.* .sdata*) *(.bss .sbss .dynbss .dynsbss) - *(.got1) + *(.got1 .glink .iplt .rela*) } }
arch/powerpc/kernel/vdso64/Makefile +1 -1
@@ -59,4 +59,4 @@ include/generated/vdso64-offsets.h: $(obj)/vdso64.so.dbg FORCE # actual build commands quiet_cmd_vdso64ld_and_check = VDSO64L $@ - cmd_vdso64ld_and_check = $(CC) $(c_flags) -o $@ -Wl,-T$(filter %.lds,$^) $(filter %.o,$^); $(cmd_vdso_check) + cmd_vdso64ld_and_check = $(CC) $(c_flags) -o $@ -Wl,-T$(filter %.lds,$^) $(filter %.o,$^) $(if $(CONFIG_LD_ORPHAN_WARN), -Wl$(comma)--orphan-handling=warn) ; $(cmd_vdso_check)
arch/powerpc/kernel/vdso64/vdso64.lds.S +2 -1
@@ -33,7 +33,7 @@ SECTIONS . = ALIGN(16); .text : { *(.text .stub .text.* .gnu.linkonce.t.* __ftr_alt_*) - *(.sfpr .glink) + *(.sfpr) } :text PROVIDE(__etext = .); PROVIDE(_etext = .);
@@ -87,6 +87,7 @@ SECTIONS *(.data .data.* .gnu.linkonce.d.* .sdata*) *(.bss .sbss .dynbss .dynsbss) *(.opd) + *(.glink .iplt .plt .rela*) } }
Signature · 1 line
2.23.0
kernel test robot
build botI love your patch! Perhaps something to improve:
Hi Nicholas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on v5.13-rc6 next-20210616]
[cannot apply to scottwood/next]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-build-vdso-linker-warning-for-orphan-sections/20210616-123155 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c16d1f65a49de22ffb37b84c51010a87fe155fe2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nicholas-Piggin/powerpc-build-vdso-linker-warning-for-orphan-sections/20210616-123155 git checkout c16d1f65a49de22ffb37b84c51010a87fe155fe2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr] scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
>> /opt/cross/gcc-9.3.0-nolibc/powerpc64-linux/bin/../lib/gcc/powerpc64-linux/9.3.0/../../../../powerpc64-linux/bin/ld: warning: discarding dynamic section .rela.opd
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kernel test robot
build botI love your patch! Perhaps something to improve:
Hi Nicholas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-build-vdso-linker-warning-for-orphan-sections/20210616-123155 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-ppa8548_defconfig (attached as .config) compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c16d1f65a49de22ffb37b84c51010a87fe155fe2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nicholas-Piggin/powerpc-build-vdso-linker-warning-for-orphan-sections/20210616-123155 git checkout c16d1f65a49de22ffb37b84c51010a87fe155fe2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
>> /opt/cross/gcc-9.3.0-nolibc/powerpc-linux/bin/../lib/gcc/powerpc-linux/9.3.0/../../../../powerpc-linux/bin/ld: warning: orphan section `.PPC.EMB.apuinfo' from `arch/powerpc/kernel/vdso32/vgettimeofday.o' being placed in section `.PPC.EMB.apuinfo' -- >> /opt/cross/gcc-9.3.0-nolibc/powerpc-linux/bin/../lib/gcc/powerpc-linux/9.3.0/../../../../powerpc-linux/bin/ld: warning: orphan section `.PPC.EMB.apuinfo' from `arch/powerpc/kernel/vdso32/vgettimeofday.o' being placed in section `.PPC.EMB.apuinfo'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Nicholas Piggin
reviewerExcerpts from Nicholas Piggin's message of June 11, 2021 9:10 pm:
Quoted 4 lines
Add --orphan-handling=warn for vdsos, and adjust vdso linker scripts to deal with orphan sections.
Signed-off-by Nicholas Piggin <[email protected]>
Okay it looks like modules should discard .PPC.EMB.apuinfo. Not entirely sure about .rela.opd.
Thanks,
Nick