cxgb4: fix wrong shift.
Subsystems (4)
PATCH 1/1 cxgb4: fix wrong shift.
While fixing coverity warning, commit dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift value. Fix that.
drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c +1 -1
@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,WORD_MASK , f->fs.nat_lip[3 ] | f->fs.nat_lip[2 ] <<8 | f->fs.nat_lip[1 ] <<16 | - (u64)f->fs.nat_lip[0] << 25, 1); + (u64)f->fs.nat_lip[0] << 24, 1); } }
Greg KH
maintainerQuoted 12 lines · Pavel Machek
While fixing coverity warning, commit
dd2c79677375c37f8f9f8d663eb4708495d595efintroduced typo in shift value. Fix that.Signed-off-by Pavel Machek (CIP) <[email protected]>drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c +0
-0
drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c static void set_nat_params(struct adapter *adap, struct filter_entry *f, · line 204
Quoted 8 lines
drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c +1
-1@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,WORD_MASK , f->fs.nat_lip[3 ] | f->fs.nat_lip[2 ] <<8 | f->fs.nat_lip[1 ] <<16 | - (u64)f->fs.nat_lip[0] << 25, 1); + (u64)f->fs.nat_lip[0] << 24, 1); } }
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
David Miller
maintainerFrom: Pavel Machek <[email protected]>
Date: Tue, 15 Jun 2021 11:56:51 +0200
Quoted 5 lines
While fixing coverity warning, commit
dd2c79677375c37f8f9f8d663eb4708495d595efintroduced typo in shift value. Fix that.Signed-off-by Pavel Machek (CIP) <[email protected]>
Please repost with an appropriate Fixes: tag, thank you.
Quoted 10 lines · David Miller
From: Pavel Machek <[email protected]>
Date: Tue, 15 Jun 2021 11:56:51 +0200Quoted 5 lines
While fixing coverity warning, commit
dd2c79677375c37f8f9f8d663eb4708495d595efintroduced typo in shift value. Fix that.Signed-off-by Pavel Machek (CIP) <[email protected]>Please repost with an appropriate Fixes: tag, thank you.
Done, you should have PATCHv2 in your inbox.
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH v2 1/1 cxgb4: fix wrong shift.
In reply to Pavel MachekWhile fixing coverity warning, commit dd2c79677375 introduced typo in shift value. Fix that.
drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c +1 -1
@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,WORD_MASK , f->fs.nat_lip[3 ] | f->fs.nat_lip[2 ] <<8 | f->fs.nat_lip[1 ] <<16 | - (u64)f->fs.nat_lip[0] << 25, 1); + (u64)f->fs.nat_lip[0] << 24, 1); } }
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 5 lines · On Fri, 18 Jun 2021 11:29:48 +0200 you wrote:
While fixing coverity warning, commit
dd2c79677375introduced typo in shift value. Fix that.Signed-off-by Pavel Machek (CIP) <[email protected]>Fixes dd2c79677375 ("cxgb4: Fix unintentional sign extension issues")
Here is the summary with links:
- [PATCHv2] cxgb4: fix wrong shift.
https://git.kernel.org/netdev/net/c/39eb028183bc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html