usb: cdns3: Enable TDL_CHK only for OUT ep
PATCH 1/1 usb: cdns3: Enable TDL_CHK only for OUT ep
commit d6eef886903c ("usb: cdns3: Enable TDL_CHK only for OUT ep") upstream.
ZLP gets stuck if TDL_CHK bit is set and TDL_FROM_TRB is used as TDL source for IN endpoints. To fix it, TDL_CHK is only enabled for OUT endpoints.
Cc [email protected] # 5.4, 5.10
Fixes 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Reported-by Aswath Govindraju <[email protected]>
Signed-off-by Sanket Parmar <[email protected]>
--- drivers/usb/cdns3/gadget.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/usb/cdns3/gadget.c +3 -5
@@ -1531,7 +1531,7 @@ void cdns3_configure_dmult(struct cdns3_device *priv_dev,else mask =BIT (priv_ep->num); -if (priv_ep->type !=USB_ENDPOINT_XFER_ISOC ) { +if (priv_ep->type !=USB_ENDPOINT_XFER_ISOC && !priv_ep->dir) {cdns3_set_register_bit (®s->tdl_from_trb, mask);cdns3_set_register_bit (®s->tdl_beh, mask);cdns3_set_register_bit (®s->tdl_beh2, mask);
@@ -1569,15 +1569,13 @@ void cdns3_ep_config(struct cdns3_endpoint *priv_ep)case USB_ENDPOINT_XFER_INT : ep_cfg =EP_CFG_EPTYPE (USB_ENDPOINT_XFER_INT ); -if ((priv_dev->dev_ver ==DEV_VER_V2 && !priv_ep->dir) || - priv_dev->dev_ver >DEV_VER_V2 ) +if (priv_dev->dev_ver >=DEV_VER_V2 && !priv_ep->dir) ep_cfg |=EP_CFG_TDL_CHK ;break ;case USB_ENDPOINT_XFER_BULK : ep_cfg =EP_CFG_EPTYPE (USB_ENDPOINT_XFER_BULK ); -if ((priv_dev->dev_ver ==DEV_VER_V2 && !priv_ep->dir) || - priv_dev->dev_ver >DEV_VER_V2 ) +if (priv_dev->dev_ver >=DEV_VER_V2 && !priv_ep->dir) ep_cfg |=EP_CFG_TDL_CHK ;break ;default :
Signature · 1 line
2.20.1