media: ov8856: ignore gpio and regulator for ov8856 with ACPI
PATCH 1/1 media: ov8856: ignore gpio and regulator for ov8856 with ACPI
For ov8856 working with ACPI, it does not depend on the reset gpio and regulator to do reset and power control, so should get the gpio and regulator for non-ACPI cases only, otherwise it will break ov8856 with ACPI.
Signed-off-by Bingbu Cao <[email protected]>
Signed-off-by Tianshu Qiu <[email protected]>
Cc Robert Foss <[email protected]>
--- drivers/media/i2c/ov8856.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)
drivers/media/i2c/ov8856.c +13 -13
@@ -2304,25 +2304,25 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, struct device *dev)clk_set_rate (ov8856->xvclk, xvclk_rate); xvclk_rate =clk_get_rate (ov8856->xvclk); + + ov8856->reset_gpio =devm_gpiod_get_optional (dev,"reset" , +GPIOD_OUT_LOW ); +if (IS_ERR (ov8856->reset_gpio)) +return PTR_ERR (ov8856->reset_gpio); + +for (i =0 ; i <ARRAY_SIZE (ov8856_supply_names); i++) + ov8856->supplies[i].supply = ov8856_supply_names[i]; + + ret =devm_regulator_bulk_get (dev,ARRAY_SIZE (ov8856_supply_names), + ov8856->supplies); +if (ret) +return ret; }if (xvclk_rate !=OV8856_XVCLK_19_2 )dev_warn (dev,"external clock rate %u is unsupported" , xvclk_rate); - ov8856->reset_gpio =devm_gpiod_get_optional (dev,"reset" , -GPIOD_OUT_LOW ); -if (IS_ERR (ov8856->reset_gpio)) -return PTR_ERR (ov8856->reset_gpio); - -for (i =0 ; i <ARRAY_SIZE (ov8856_supply_names); i++) - ov8856->supplies[i].supply = ov8856_supply_names[i]; - - ret =devm_regulator_bulk_get (dev,ARRAY_SIZE (ov8856_supply_names), - ov8856->supplies); -if (ret) -return ret; - ep =fwnode_graph_get_next_endpoint (fwnode,NULL );if (!ep)return -ENXIO ;
Signature · 1 line
2.7.4
Quoted 6 lines · Bingbu Cao
For ov8856 working with ACPI, it does not depend on the reset gpio and regulator to do reset and power control, so should get the gpio and regulator for non-ACPI cases only, otherwise it will break ov8856 with ACPI.
LGTM
Reviewed-by Sergey Senozhatsky <[email protected]>