Skip to contentSkip to conversation

efi_loader: Use %pD to log device-path instead of local efi_dp_str()

PATCH In review Masami Hiramatsu 2 participants 2 messages Jul 14, 2021 – Jul 16, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efi_loader: Use %pD to log device-path instead of local efi_dp_str()

Use %pD to log device-path instead of using efi_dp_str() and efi_free_pool() locally in find_boot_device(). This is a cleanup patch, no feature update nor fix.

---
 lib/efi_loader/efi_capsule.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
lib/efi_loader/efi_capsule.c +1 -5
index b878e71438..a09c5705f1 100644
@@ -691,11 +691,7 @@ skip:
 	}
 found:
 	if (boot_dev) {
-		u16 *path_str;
-
-		path_str = efi_dp_str(boot_dev);
-		log_debug("Boot device %ls\n", path_str);
-		efi_free_pool(path_str);
+		log_debug("Boot device %pD\n", boot_dev);
 
 		volume = efi_fs_from_path(boot_dev);
 		if (!volume)
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Masami Hiramatsu

Use %pD to log device-path instead of using efi_dp_str() and efi_free_pool() locally in find_boot_device(). This is a cleanup patch, no feature update nor fix.

Quoted 22 lines
---
  lib/efi_loader/efi_capsule.c |    6 +-----
  1 file changed, 1 insertion(+), 5 deletions(-)
lib/efi_loader/efi_capsule.c +1 -5
index b878e71438..a09c5705f1 100644
@@ -691,11 +691,7 @@ skip:
  	}
  found:
  	if (boot_dev) {
-		u16 *path_str;
-
-		path_str = efi_dp_str(boot_dev);
-		log_debug("Boot device %ls\n", path_str);
-		efi_free_pool(path_str);
+		log_debug("Boot device %pD\n", boot_dev);
 
  		volume = efi_fs_from_path(boot_dev);
  		if (!volume)