Skip to contentSkip to conversation

media: staging: document that Imgu not output auto-exposure statistics

PATCH Superseded Bingbu Cao 3 participants 3 messages Jul 14, 2021

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Bingbu Cao

author
#0 lore raw

PATCH 1/1 media: staging: document that Imgu not output auto-exposure statistics

Currently, Imgu can not support output the auto-exposure statistics into ae_raw_buffer in 3A stats buffer, this patch document it.

---
 drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +3 -0
index fa3d6ee5adf2..605113da1aed 100644
@@ -534,6 +534,9 @@ struct ipu3_uapi_ff_status {
  *
  * @awb_raw_buffer: auto white balance meta data &ipu3_uapi_awb_raw_buffer
  * @ae_raw_buffer: auto exposure raw data &ipu3_uapi_ae_raw_buffer_aligned
+ *                 current Imgu does not output the auto exposure statistics
+ *                 to ae_raw_buffer, the user such as 3A algorithm can use the
+ *                 RGB table in &ipu3_uapi_awb_raw_buffer to do auto-exposure.
  * @af_raw_buffer: &ipu3_uapi_af_raw_buffer for auto focus meta data
  * @awb_fr_raw_buffer: value as specified by &ipu3_uapi_awb_fr_raw_buffer
  * @stats_4a_config: 4a statistics config as defined by &ipu3_uapi_4a_config.
Signature · 1 line
2.7.4
#1 lore raw

Hi Bingbu,

Thank you for the patch.

Quoted 13 lines · Bingbu Cao

Currently, Imgu can not support output the auto-exposure statistics into ae_raw_buffer in 3A stats buffer, this patch document it.

---
 drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +0 -0
index fa3d6ee5adf2..605113da1aed 100644

drivers/staging/media/ipu3/include/uapi/intel-ipu3.h struct ipu3_uapi_ff_status { · line 539

Quoted 6 lines
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +3 -0
@@ -534,6 +534,9 @@ struct ipu3_uapi_ff_status {
  *
  * @awb_raw_buffer: auto white balance meta data &ipu3_uapi_awb_raw_buffer
  * @ae_raw_buffer: auto exposure raw data &ipu3_uapi_ae_raw_buffer_aligned
+ *                 current Imgu does not output the auto exposure statistics
+ *                 to ae_raw_buffer, the user such as 3A algorithm can use the
+ *                 RGB table in &ipu3_uapi_awb_raw_buffer to do auto-exposure.

Is there any other fields in the statistics buffer that is not populated by the device, or is this the only one ?

Could you please also mark the corresponding parameters fields as unused by the device ?

Quoted 3 lines
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +0 -0
  * @af_raw_buffer: &ipu3_uapi_af_raw_buffer for auto focus meta data
  * @awb_fr_raw_buffer: value as specified by &ipu3_uapi_awb_fr_raw_buffer
  * @stats_4a_config: 4a statistics config as defined by &ipu3_uapi_4a_config.
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw

Laurent,

Thanks for your review.

Quoted 13 lines · Laurent Pinchart

Hi Bingbu,

Thank you for the patch.

Quoted 8 lines · Bingbu Cao

Currently, Imgu can not support output the auto-exposure statistics into ae_raw_buffer in 3A stats buffer, this patch document it.

---
 drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 3 +++
 1 file changed, 3 insertions(+)
Quoted 14 lines

drivers/staging/media/ipu3/include/uapi/intel-ipu3.h struct ipu3_uapi_ff_status { · line 539

Quoted 11 lines
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +3 -0
index fa3d6ee5adf2..605113da1aed 100644
@@ -534,6 +534,9 @@ struct ipu3_uapi_ff_status {
  *
  * @awb_raw_buffer: auto white balance meta data &ipu3_uapi_awb_raw_buffer
  * @ae_raw_buffer: auto exposure raw data &ipu3_uapi_ae_raw_buffer_aligned
+ *                 current Imgu does not output the auto exposure statistics
+ *                 to ae_raw_buffer, the user such as 3A algorithm can use the
+ *                 RGB table in &ipu3_uapi_awb_raw_buffer to do auto-exposure.

Is there any other fields in the statistics buffer that is not populated by the device, or is this the only one ?

I will check again whether there is any I missed.

Quoted 3 lines

Could you please also mark the corresponding parameters fields as unused by the device ?

Yes, sure.

Quoted 5 lines
Quoted 4 lines
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +0 -0
  * @af_raw_buffer: &ipu3_uapi_af_raw_buffer for auto focus meta data
  * @awb_fr_raw_buffer: value as specified by &ipu3_uapi_awb_fr_raw_buffer
  * @stats_4a_config: 4a statistics config as defined by &ipu3_uapi_4a_config.
Signature · 2 lines
Best regards,
Bingbu Cao