net: sched: fix memory leak in tcindex_partial_destroy_work
Subsystems (3)
PATCH 1/1 net: sched: fix memory leak in tcindex_partial_destroy_work
Syzbot reported memory leak in tcindex_set_parms(). The problem was in non-freed perfect hash in tcindex_partial_destroy_work().
In tcindex_set_parms() new tcindex_data is allocated and some fields from old one are copied to new one, but not the perfect hash. Since tcindex_partial_destroy_work() is the destroy function for old tcindex_data, we need to free perfect hash to avoid memory leak.
--- net/sched/cls_tcindex.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
net/sched/cls_tcindex.c +4 -1
@@ -278,6 +278,8 @@ static int tcindex_filter_result_init(struct tcindex_filter_result *r, TCA_TCINDEX_POLICE); } +static void tcindex_free_perfect_hash (struct tcindex_data *cp); +static void tcindex_partial_destroy_work (struct work_struct *work) { struct tcindex_data *p = container_of(to_rcu_work(work),
@@ -285,7 +287,8 @@ static void tcindex_partial_destroy_work(struct work_struct *work) rwork);rtnl_lock (); -kfree (p->perfect); +if (p->perfect) +tcindex_free_perfect_hash (p);kfree (p);rtnl_unlock (); }
Signature · 1 line
2.32.0
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 9 lines · On Sat, 17 Jul 2021 14:29:33 +0300 you wrote:
Syzbot reported memory leak in
tcindex_set_parms(). The problem was in non-freed perfect hash intcindex_partial_destroy_work().In
tcindex_set_parms()newtcindex_datais allocated and some fields from old one are copied to new one, but not the perfect hash. Sincetcindex_partial_destroy_work()is the destroy function for oldtcindex_data, we need to free perfect hash to avoid memory leak.[...]
Here is the summary with links:
- net: sched: fix memory leak in tcindex_partial_destroy_work
https://git.kernel.org/netdev/net/c/f5051bcece50
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html