PM / Domains: Add support for 'required-opps' to set default perf state
Subsystems (9)
v5 cover PM / Domains: Add support for 'required-opps' to set default perf state
v5: Dropped all default_pstate handling in runtime suspend/resume
v4: Fixed error handling in __genpd_dev_pm_attach()
This is a re-spin of the series [1] which was adding support for a new DT binding (assigned-performance-state) and based on the discussions on that thread [2] it was concluded that we could achieve the same with the existing 'required-opps' binding instead.
So this series, just drops the new binding and uses required-opps to achieve the default perf state setting thats needed by some devices.
---
Some devics within power-domains with performance states do not support DVFS, but still need to vote on a default/static state while they are active. Add support for this using the 'required-opps' property in device tree.
[1] https://lore.kernel.org/patchwork/project/lkml/list/?series=501336&state=%2A&archive=both
[2] https://lore.kernel.org/patchwork/patch/1436886/
Rajendra Nayak (2):
PM / Domains: Add support for 'required-opps' to set default perf
state
arm64: dts: sc7180: Add required-opps for i2c
arch/arm64/boot/dts/qcom/sc7180.dtsi | 24 ++++++++++++++++++++++++ drivers/base/power/domain.c | 28 +++++++++++++++++++++++++--- include/linux/pm_domain.h | 1 + 3 files changed, 50 insertions(+), 3 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
PATCH v5 1/2 PM / Domains: Add support for 'required-opps' to set default perf state
Some devices within power domains with performance states do not support DVFS, but still need to vote on a default/static state while they are active. They can express this using the 'required-opps' property in device tree, which points to the phandle of the OPP supported by the corresponding power-domains.
Add support to parse this information from DT and then set the specified performance state during attach and drop it on detach. runtime suspend/resume callbacks already have logic to drop/set the vote as needed and should take care of dropping the default perf state vote on runtime suspend and restore it back on runtime resume.
--- drivers/base/power/domain.c | 28 +++++++++++++++++++++++++--- include/linux/pm_domain.h | 1 + 2 files changed, 26 insertions(+), 3 deletions(-)
drivers/base/power/domain.c +25 -3
@@ -2598,6 +2598,12 @@ static void genpd_dev_pm_detach(struct device *dev, bool power_off)dev_dbg (dev,"removing from PM domain %s\n" , pd->name); +/* Drop the default performance state */ +if (dev_gpd_data (dev)->default_pstate) { +dev_pm_genpd_set_performance_state (dev,0 ); +dev_gpd_data (dev)->default_pstate =0 ; + } +for (i =1 ; i <GENPD_RETRY_MAX_MS ; i <<=1 ) { ret =genpd_remove_device (pd, dev);if (ret != -EAGAIN )
@@ -2635,9 +2641,10 @@ static void genpd_dev_pm_sync(struct device *dev)static int __genpd_dev_pm_attach (struct device *dev,struct device *base_dev,unsigned int index,bool power_on) { +struct device_node *np;struct of_phandle_args pd_args;struct generic_pm_domain *pd; -int ret; +int ret, pstate; ret =of_parse_phandle_with_args (dev->of_node,"power-domains" ,"#power-domain-cells" , index, &pd_args);
@@ -2675,10 +2682,25 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,genpd_unlock (pd); } -if (ret) +if (ret) {genpd_remove_device (pd, dev); +return -EPROBE_DEFER ; + } + +/* Set the default performance state */ + np = base_dev->of_node; +if (of_parse_phandle (np,"required-opps" , index)) { + pstate =of_get_required_opp_performance_state (np, index); +if (pstate <0 ) { + ret = pstate; +dev_err (dev,"failed to set required performance state for power-domain %s: %d\n" , + pd->name, ret); + } +dev_pm_genpd_set_performance_state (dev, pstate); +dev_gpd_data (dev)->default_pstate = pstate; + } -return ret ? -EPROBE_DEFER :1 ; +return ret ? ret :1 ; }/**
include/linux/pm_domain.h +1 -0
@@ -198,6 +198,7 @@ struct generic_pm_domain_data {struct notifier_block *power_nb;int cpu;unsigned int performance_state; +unsigned int default_pstate;unsigned int rpm_pstate;ktime_t next_wakeup;void *data;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Hi,
drivers/base/power/domain.c static void genpd_dev_pm_sync(struct device *dev) · line 2647
Quoted 9 lines · Rajendra Nayak
drivers/base/power/domain.c +2
-1@@ -2635,9 +2641,10 @@ static void genpd_dev_pm_sync(struct device *dev)static int __genpd_dev_pm_attach (struct device *dev,struct device *base_dev,unsigned int index,bool power_on) { +struct device_node *np;struct of_phandle_args pd_args;struct generic_pm_domain *pd; -int ret; +int ret, pstate;
nit: might want to keep one variable declaration per line here.
Signature · 1 line
balbi
Quoted 51 lines · Rajendra Nayak
Some devices within power domains with performance states do not support DVFS, but still need to vote on a default/static state while they are active. They can express this using the 'required-opps' property in device tree, which points to the phandle of the OPP supported by the corresponding power-domains.
Add support to parse this information from DT and then set the specified performance state during attach and drop it on detach. runtime suspend/resume callbacks already have logic to drop/set the vote as needed and should take care of dropping the default perf state vote on runtime suspend and restore it back on runtime resume.
Signed-off-by Rajendra Nayak <[email protected]>--- drivers/base/power/domain.c | 28 +++++++++++++++++++++++++--- include/linux/pm_domain.h | 1 + 2 files changed, 26 insertions(+), 3 deletions(-)drivers/base/power/domain.c +8
-1@@ -2598,6 +2598,12 @@ static void genpd_dev_pm_detach(struct device *dev, bool power_off)dev_dbg (dev,"removing from PM domain %s\n" , pd->name); +/* Drop the default performance state */ +if (dev_gpd_data (dev)->default_pstate) { +dev_pm_genpd_set_performance_state (dev,0 ); +dev_gpd_data (dev)->default_pstate =0 ; + } +for (i =1 ; i <GENPD_RETRY_MAX_MS ; i <<=1 ) { ret =genpd_remove_device (pd, dev);if (ret != -EAGAIN )@@ -2635,9 +2641,10 @@ static void genpd_dev_pm_sync(struct device *dev)static int __genpd_dev_pm_attach (struct device *dev,struct device *base_dev,unsigned int index,bool power_on) { +struct device_node *np;struct of_phandle_args pd_args;struct generic_pm_domain *pd; -int ret; +int ret, pstate; ret =of_parse_phandle_with_args (dev->of_node,"power-domains" ,"#power-domain-cells" , index, &pd_args);@@ -2675,10 +2682,25 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,genpd_unlock (pd);
drivers/base/power/domain.c static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, · line 2691
Quoted 10 lines
drivers/base/power/domain.c +6
-1} -if (ret) +if (ret) {genpd_remove_device (pd, dev); +return -EPROBE_DEFER ; + } + +/* Set the default performance state */ + np = base_dev->of_node;
Please use dev->of_node instead (it is set to the same of_node as base_dev by the callers of __genpd_dev_pm_attach) as it's more consistent with existing code.
drivers/base/power/domain.c static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, · line 2700
Quoted 9 lines
drivers/base/power/domain.c +9
-0+if (of_parse_phandle (np,"required-opps" , index)) { + pstate =of_get_required_opp_performance_state (np, index); +if (pstate <0 ) { + ret = pstate; +dev_err (dev,"failed to set required performance state for power-domain %s: %d\n" , + pd->name, ret); + } +dev_pm_genpd_set_performance_state (dev, pstate); +dev_gpd_data (dev)->default_pstate = pstate;
This doesn't look entirely correct to me. If we fail to translate a required opp to a performance state, we shouldn't try to set it.
Perhaps it's also easier to call of_get_required_opp_performance_state() unconditionally of whether a "required-opps" specifier exists. If it fails with the translation, then we just skip setting a default state and continue with returning 1.
Would that work?
Quoted 20 lines
drivers/base/power/domain.c +2
-1+ } -return ret ? -EPROBE_DEFER :1 ; +return ret ? ret :1 ; }/** include/linux/pm_domain.h +1
-1@@ -198,6 +198,7 @@ struct generic_pm_domain_data {struct notifier_block *power_nb;int cpu;unsigned int performance_state; +unsigned int default_pstate;unsigned int rpm_pstate;ktime_t next_wakeup;void *data; --
Quoted 3 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Kind regards
Uffe
Quoted 77 lines · Ulf Hansson
Quoted 51 lines · Rajendra Nayak
Some devices within power domains with performance states do not support DVFS, but still need to vote on a default/static state while they are active. They can express this using the 'required-opps' property in device tree, which points to the phandle of the OPP supported by the corresponding power-domains.
Add support to parse this information from DT and then set the specified performance state during attach and drop it on detach. runtime suspend/resume callbacks already have logic to drop/set the vote as needed and should take care of dropping the default perf state vote on runtime suspend and restore it back on runtime resume.
Signed-off-by Rajendra Nayak <[email protected]>--- drivers/base/power/domain.c | 28 +++++++++++++++++++++++++--- include/linux/pm_domain.h | 1 + 2 files changed, 26 insertions(+), 3 deletions(-)drivers/base/power/domain.c +8
-1@@ -2598,6 +2598,12 @@ static void genpd_dev_pm_detach(struct device *dev, bool power_off)dev_dbg (dev,"removing from PM domain %s\n" , pd->name); +/* Drop the default performance state */ +if (dev_gpd_data (dev)->default_pstate) { +dev_pm_genpd_set_performance_state (dev,0 ); +dev_gpd_data (dev)->default_pstate =0 ; + } +for (i =1 ; i <GENPD_RETRY_MAX_MS ; i <<=1 ) { ret =genpd_remove_device (pd, dev);if (ret != -EAGAIN )@@ -2635,9 +2641,10 @@ static void genpd_dev_pm_sync(struct device *dev)static int __genpd_dev_pm_attach (struct device *dev,struct device *base_dev,unsigned int index,bool power_on) { +struct device_node *np;struct of_phandle_args pd_args;struct generic_pm_domain *pd; -int ret; +int ret, pstate; ret =of_parse_phandle_with_args (dev->of_node,"power-domains" ,"#power-domain-cells" , index, &pd_args);@@ -2675,10 +2682,25 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,genpd_unlock (pd);drivers/base/power/domain.c static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, · line 2691
Quoted 10 lines
drivers/base/power/domain.c +6
-1} -if (ret) +if (ret) {genpd_remove_device (pd, dev); +return -EPROBE_DEFER ; + } + +/* Set the default performance state */ + np = base_dev->of_node;Please use
dev->of_nodeinstead (it is set to the sameof_nodeasbase_devby the callers of__genpd_dev_pm_attach) as it's more consistent with existing code.drivers/base/power/domain.c static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, · line 2700
Quoted 9 lines
drivers/base/power/domain.c +9
-0+if (of_parse_phandle (np,"required-opps" , index)) { + pstate =of_get_required_opp_performance_state (np, index); +if (pstate <0 ) { + ret = pstate; +dev_err (dev,"failed to set required performance state for power-domain %s: %d\n" , + pd->name, ret); + } +dev_pm_genpd_set_performance_state (dev, pstate); +dev_gpd_data (dev)->default_pstate = pstate;
Quoted 2 lines
This doesn't look entirely correct to me. If we fail to translate a required opp to a performance state, we shouldn't try to set it.
yeah, that does not seem right at all :(
Quoted 7 lines
Perhaps it's also easier to call
of_get_required_opp_performance_state()unconditionally of whether a "required-opps" specifier exists. If it fails with the translation, then we just skip setting a default state and continue with returning 1.Would that work?
I think it should, I'll redo the error handling, hopefully right this time, and re-post. Thanks for the review.
Quoted 28 lines
Quoted 21 lines
drivers/base/power/domain.c +2
-1+ } -return ret ? -EPROBE_DEFER :1 ; +return ret ? ret :1 ; }/** include/linux/pm_domain.h +1
-1@@ -198,6 +198,7 @@ struct generic_pm_domain_data {struct notifier_block *power_nb;int cpu;unsigned int performance_state; +unsigned int default_pstate;unsigned int rpm_pstate;ktime_t next_wakeup;void *data; --Quoted 3 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Kind regards
Uffe
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 79 lines · Rajendra Nayak
Quoted 77 lines · Ulf Hansson
Quoted 51 lines · Rajendra Nayak
Some devices within power domains with performance states do not support DVFS, but still need to vote on a default/static state while they are active. They can express this using the 'required-opps' property in device tree, which points to the phandle of the OPP supported by the corresponding power-domains.
Add support to parse this information from DT and then set the specified performance state during attach and drop it on detach. runtime suspend/resume callbacks already have logic to drop/set the vote as needed and should take care of dropping the default perf state vote on runtime suspend and restore it back on runtime resume.
Signed-off-by Rajendra Nayak <[email protected]>---
drivers/base/power/domain.c| 28 +++++++++++++++++++++++++--- include/linux/pm_domain.h | 1 +2 files changed, 26 insertions(+), 3 deletions(-)drivers/base/power/domain.c +8
-1@@ -2598,6 +2598,12 @@ static void genpd_dev_pm_detach(struct device *dev, bool power_off) dev_dbg(dev, "removing from PM domain %s\n", pd->name); + /* Drop the default performance state */ + if (dev_gpd_data(dev)->default_pstate) { + dev_pm_genpd_set_performance_state(dev, 0); + dev_gpd_data(dev)->default_pstate = 0; + } + for (i = 1; i < GENPD_RETRY_MAX_MS; i <<= 1) { ret = genpd_remove_device(pd, dev); if (ret != -EAGAIN)@@ -2635,9 +2641,10 @@ static void genpd_dev_pm_sync(struct device *dev) static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, unsigned int index, bool power_on) { + struct device_node *np; struct of_phandle_args pd_args; struct generic_pm_domain *pd; - int ret; + int ret, pstate; ret = of_parse_phandle_with_args(dev->of_node, "power-domains", "#power-domain-cells", index, &pd_args);@@ -2675,10 +2682,25 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, genpd_unlock(pd);drivers/base/power/domain.c static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, · line 2691
Quoted 10 lines
drivers/base/power/domain.c +6
-1} - if (ret) + if (ret) { genpd_remove_device(pd, dev); + return -EPROBE_DEFER; + } + + /* Set the default performance state */ + np = base_dev->of_node;Please use
dev->of_nodeinstead (it is set to the sameof_nodeasbase_devby the callers of__genpd_dev_pm_attach) as it's more consistent with existing code.Quoted 9 lines
drivers/base/power/domain.c +9
-0+ if (of_parse_phandle(np, "required-opps", index)) { + pstate = of_get_required_opp_performance_state(np, index); + if (pstate < 0) { + ret = pstate; + dev_err(dev, "failed to set required performance state for power-domain %s: %d\n", + pd->name, ret); + } + dev_pm_genpd_set_performance_state(dev, pstate); + dev_gpd_data(dev)->default_pstate = pstate;
Quoted 12 lines
Quoted 2 lines
This doesn't look entirely correct to me. If we fail to translate a required opp to a performance state, we shouldn't try to set it.
yeah, that does not seem right at all :(
Quoted 7 lines
Perhaps it's also easier to call
of_get_required_opp_performance_state()unconditionally of whether a "required-opps" specifier exists. If it fails with the translation, then we just skip setting a default state and continue with returning 1.Would that work?
Looks like calling of_get_required_opp_performance_state() unconditionally makes it spit out a pr_err() in case the node is missing "required-opps" property, so I posted a v6 [1] with the check in place and adding the missing else condition.
[1] https://lore.kernel.org/patchwork/project/lkml/list/?series=510727
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 93 lines · Rajendra Nayak
Quoted 90 lines · Rajendra Nayak
Quoted 77 lines · Ulf Hansson
Quoted 51 lines · Rajendra Nayak
Some devices within power domains with performance states do not support DVFS, but still need to vote on a default/static state while they are active. They can express this using the 'required-opps' property in device tree, which points to the phandle of the OPP supported by the corresponding power-domains.
Add support to parse this information from DT and then set the specified performance state during attach and drop it on detach. runtime suspend/resume callbacks already have logic to drop/set the vote as needed and should take care of dropping the default perf state vote on runtime suspend and restore it back on runtime resume.
Signed-off-by Rajendra Nayak <[email protected]>--- drivers/base/power/domain.c | 28 +++++++++++++++++++++++++--- include/linux/pm_domain.h | 1 + 2 files changed, 26 insertions(+), 3 deletions(-)drivers/base/power/domain.c +8
-1@@ -2598,6 +2598,12 @@ static void genpd_dev_pm_detach(struct device *dev, bool power_off)dev_dbg (dev,"removing from PM domain %s\n" , pd->name); +/* Drop the default performance state */ +if (dev_gpd_data (dev)->default_pstate) { +dev_pm_genpd_set_performance_state (dev,0 ); +dev_gpd_data (dev)->default_pstate =0 ; + } +for (i =1 ; i <GENPD_RETRY_MAX_MS ; i <<=1 ) { ret =genpd_remove_device (pd, dev);if (ret != -EAGAIN )@@ -2635,9 +2641,10 @@ static void genpd_dev_pm_sync(struct device *dev)static int __genpd_dev_pm_attach (struct device *dev,struct device *base_dev,unsigned int index,bool power_on) { +struct device_node *np;struct of_phandle_args pd_args;struct generic_pm_domain *pd; -int ret; +int ret, pstate; ret =of_parse_phandle_with_args (dev->of_node,"power-domains" ,"#power-domain-cells" , index, &pd_args);@@ -2675,10 +2682,25 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,genpd_unlock (pd);drivers/base/power/domain.c static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, · line 2691
Quoted 10 lines
drivers/base/power/domain.c +6
-1} -if (ret) +if (ret) {genpd_remove_device (pd, dev); +return -EPROBE_DEFER ; + } + +/* Set the default performance state */ + np = base_dev->of_node;Please use
dev->of_nodeinstead (it is set to the sameof_nodeasbase_devby the callers of__genpd_dev_pm_attach) as it's more consistent with existing code.drivers/base/power/domain.c static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, · line 2700
Quoted 9 lines
drivers/base/power/domain.c +9
-0+if (of_parse_phandle (np,"required-opps" , index)) { + pstate =of_get_required_opp_performance_state (np, index); +if (pstate <0 ) { + ret = pstate; +dev_err (dev,"failed to set required performance state for power-domain %s: %d\n" , + pd->name, ret); + } +dev_pm_genpd_set_performance_state (dev, pstate); +dev_gpd_data (dev)->default_pstate = pstate;Quoted 2 lines
This doesn't look entirely correct to me. If we fail to translate a required opp to a performance state, we shouldn't try to set it.
yeah, that does not seem right at all :(
Quoted 6 lines
Perhaps it's also easier to call
of_get_required_opp_performance_state()unconditionally of whether a "required-opps" specifier exists. If it fails with the translation, then we just skip setting a default state and continue with returning 1.
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Would that work?
Looks like calling
of_get_required_opp_performance_state()unconditionally makes it spit out apr_err()in case the node is missing "required-opps" property, so I posted a v6 [1] with the check in place and adding the missing else condition.
I see.
Viresh, would it make sense to remove that print? I mean, the required-opps property could be considered as optional and it seems a bit silly that a pre-parsing of the property is needed to figure that out.
Quoted 2 lines
[1] https://lore.kernel.org/patchwork/project/lkml/list/?series=510727
Kind regards
Uffe
Quoted 4 lines · Ulf Hansson
Viresh, would it make sense to remove that print? I mean, the required-opps property could be considered as optional and it seems a bit silly that a pre-parsing of the property is needed to figure that out.
Sure, np.
Signature · 1 line
viresh
PATCH v5 2/2 arm64: dts: sc7180: Add required-opps for i2c
In reply to Rajendra Nayakqup-i2c devices on sc7180 are clocked with a fixed clock (19.2 MHz) Though qup-i2c does not support DVFS, it still needs to vote for a performance state on 'CX' to satisfy the 19.2 Mhz clock frequency requirement.
Use 'required-opps' to pass this information from device tree, and also add the power-domains property to specify the CX power-domain.
--- arch/arm64/boot/dts/qcom/sc7180.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
arch/arm64/boot/dts/qcom/sc7180.dtsi +24 -0
@@ -785,8 +785,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>, <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; spi0: spi@880000 {
@@ -837,8 +839,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>, <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; spi1: spi@884000 {
@@ -889,8 +893,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>, <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; uart2: serial@888000 {
@@ -923,8 +929,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>, <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; spi3: spi@88c000 {
@@ -975,8 +983,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>, <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; uart4: serial@890000 {
@@ -1009,8 +1019,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>, <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; spi5: spi@894000 {
@@ -1074,8 +1086,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>, <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; spi6: spi@a80000 {
@@ -1126,8 +1140,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>, <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; uart7: serial@a84000 {
@@ -1160,8 +1176,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>, <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; spi8: spi@a88000 {
@@ -1212,8 +1230,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>, <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; uart9: serial@a8c000 {
@@ -1246,8 +1266,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>, <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; spi10: spi@a90000 {
@@ -1298,8 +1320,10 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>, <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>; interconnect-names = "qup-core", "qup-config", "qup-memory"; + power-domains = <&rpmhpd SC7180_CX>; + required-opps = <&rpmhpd_opp_low_svs>; status = "disabled"; }; spi11: spi@a94000 {
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation