Skip to contentSkip to conversation

defer: remove superfluous preposition

PATCH In review Zhouyi Zhou 2 participants 5 messages Jul 20, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 defer: remove superfluous preposition

Hi, Paul
I think preposition 'on' here is superfluous, correct me if I am wrong.
Best Wishes
Zhouyi

---
 defer/rcufundamental.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
defer/rcufundamental.tex +1 -1
index 66f9b70..62f31d0 100644
@@ -332,7 +332,7 @@ greater detail in \cref{sec:memorder:RCU}.
 	It might seem strange to have RCU read-side critical sections
 	containing writes, but RCU is just fine with this.
 	This capability is used frequently in the Linux kernel, for
-	example, acquiring a lock on or reference to a data structure.
+	example, acquiring a lock or reference to a data structure.
 	Acquiring either a lock or a reference results in a write
 	to memory, and it is OK to do these within an RCU read-side
 	critical section.
Signature · 1 line
2.5.0
#1 lore raw
Quoted 4 lines · Zhouyi Zhou

Hi, Paul
I think preposition 'on' here is superfluous, correct me if I am wrong.
Best Wishes
Zhouyi

The current text is technically grammatically correct, but as you noticed, rather awkward. I should rework that sentence and the one following. Huh. Actually, I should rework that entire paragraph.

How about the following?

Thanx, Paul

------------------------------------------------------------------------

commit 5eb7525e2f7338ea6b817c145a9b4da60e6871d1

Author: Paul E. McKenney <[email protected]>
Date:   Tue Jul 20 10:31:03 2021 -0700

defer/rcufundamental: Wordsmith QQ answer about writes in RCU readers

defer/rcufundamental.tex +11 -6
index 66f9b702..054512e0 100644
@@ -330,12 +330,17 @@ greater detail in \cref{sec:memorder:RCU}.
 	\co{P1()}'s grace period.
 
 	It might seem strange to have RCU read-side critical sections
-	containing writes, but RCU is just fine with this.
-	This capability is used frequently in the Linux kernel, for
-	example, acquiring a lock on or reference to a data structure.
-	Acquiring either a lock or a reference results in a write
-	to memory, and it is OK to do these within an RCU read-side
-	critical section.
+	containing writes, but this capability is not only permitted,
+	but also highly useful.
+	For example, the Linux kernel frequently carries out an
+	RCU-protected traversal of a linked data structure and then
+	acquires a reference to the destination data element.
+	Because this data element must not be freed in the meantime,
+	that element's reference counter must necessarily be incremented
+	within the traversal's RCU read-side critical section.
+	However, that increment entails a write to memory.
+	Therefore, it is a very good thing that memory writes are
+	permitted within RCU read-side critical sections.
 
 	If having writes in RCU read-side critical sections still seems
 	strange, please review
#2 lore raw

Thanks Paul for reviewing the patch

Quoted 41 lines · Paul E. McKenney
Quoted 4 lines · Zhouyi Zhou

Hi, Paul
I think preposition 'on' here is superfluous, correct me if I am wrong.
Best Wishes
Zhouyi

The current text is technically grammatically correct, but as you noticed, rather awkward. I should rework that sentence and the one following. Huh. Actually, I should rework that entire paragraph.

How about the following?

Thanx, Paul

------------------------------------------------------------------------

commit 5eb7525e2f7338ea6b817c145a9b4da60e6871d1

Author: Paul E. McKenney <[email protected]>
Date:   Tue Jul 20 10:31:03 2021 -0700

defer/rcufundamental: Wordsmith QQ answer about writes in RCU readers

defer/rcufundamental.tex +1 -6
index 66f9b702..054512e0 100644
@@ -330,12 +330,17 @@ greater detail in \cref{sec:memorder:RCU}.
        \co{P1()}'s grace period.
 
        It might seem strange to have RCU read-side critical sections
-       containing writes, but RCU is just fine with this.
-       This capability is used frequently in the Linux kernel, for
-       example, acquiring a lock on or reference to a data structure.
-       Acquiring either a lock or a reference results in a write
-       to memory, and it is OK to do these within an RCU read-side
-       critical section.
+       containing writes, but this capability is not only permitted,

defer/rcufundamental.tex greater detail in \cref{sec:memorder:RCU}. · line 343

Quoted 10 lines
defer/rcufundamental.tex +10 -0
+       but also highly useful.
+       For example, the Linux kernel frequently carries out an
+       RCU-protected traversal of a linked data structure and then
+       acquires a reference to the destination data element.
+       Because this data element must not be freed in the meantime,
+       that element's reference counter must necessarily be incremented
+       within the traversal's RCU read-side critical section.
+       However, that increment entails a write to memory.
+       Therefore, it is a very good thing that memory writes are
+       permitted within RCU read-side critical sections.

The revised paragraph is easier for me to understand, especially why acquiring a reference to a data structure entails a write ;-)

defer/rcufundamental.tex greater detail in \cref{sec:memorder:RCU}. · line 346

Quoted 3 lines
defer/rcufundamental.tex +0 -0
        If having writes in RCU read-side critical sections still seems
        strange, please review

The revised edition looks wonderful, thank you

Thanks again
Zhouyi

#3 lore raw
Quoted 57 lines · Zhouyi Zhou

Thanks Paul for reviewing the patch

Quoted 41 lines · Paul E. McKenney
Quoted 4 lines · Zhouyi Zhou

Hi, Paul
I think preposition 'on' here is superfluous, correct me if I am wrong.
Best Wishes
Zhouyi

The current text is technically grammatically correct, but as you noticed, rather awkward. I should rework that sentence and the one following. Huh. Actually, I should rework that entire paragraph.

How about the following?

Thanx, Paul

------------------------------------------------------------------------

commit 5eb7525e2f7338ea6b817c145a9b4da60e6871d1

Author: Paul E. McKenney <[email protected]>
Date:   Tue Jul 20 10:31:03 2021 -0700

defer/rcufundamental: Wordsmith QQ answer about writes in RCU readers

defer/rcufundamental.tex +1 -6
index 66f9b702..054512e0 100644
@@ -330,12 +330,17 @@ greater detail in \cref{sec:memorder:RCU}.
        \co{P1()}'s grace period.
 
        It might seem strange to have RCU read-side critical sections
-       containing writes, but RCU is just fine with this.
-       This capability is used frequently in the Linux kernel, for
-       example, acquiring a lock on or reference to a data structure.
-       Acquiring either a lock or a reference results in a write
-       to memory, and it is OK to do these within an RCU read-side
-       critical section.
+       containing writes, but this capability is not only permitted,

defer/rcufundamental.tex greater detail in \cref{sec:memorder:RCU}. · line 343

Quoted 10 lines
defer/rcufundamental.tex +10 -0
+       but also highly useful.
+       For example, the Linux kernel frequently carries out an
+       RCU-protected traversal of a linked data structure and then
+       acquires a reference to the destination data element.
+       Because this data element must not be freed in the meantime,
+       that element's reference counter must necessarily be incremented
+       within the traversal's RCU read-side critical section.
+       However, that increment entails a write to memory.
+       Therefore, it is a very good thing that memory writes are
+       permitted within RCU read-side critical sections.

The revised paragraph is easier for me to understand, especially why acquiring a reference to a data structure entails a write ;-)

Quoted 1 line
Quoted 3 lines
Quoted 2 lines

If having writes in RCU read-side critical sections still seems strange, please review

The revised edition looks wonderful, thank you

Glad you like it, and thank you for pointing me at the original awkward sentence!

Thanx, Paul

#4 lore raw
Quoted 59 lines · Paul E. McKenney
Quoted 57 lines · Zhouyi Zhou

Thanks Paul for reviewing the patch

Quoted 41 lines · Paul E. McKenney
Quoted 4 lines · Zhouyi Zhou

Hi, Paul
I think preposition 'on' here is superfluous, correct me if I am wrong.
Best Wishes
Zhouyi

The current text is technically grammatically correct, but as you noticed, rather awkward. I should rework that sentence and the one following. Huh. Actually, I should rework that entire paragraph.

How about the following?

Thanx, Paul

------------------------------------------------------------------------

commit 5eb7525e2f7338ea6b817c145a9b4da60e6871d1

Author: Paul E. McKenney <[email protected]>
Date:   Tue Jul 20 10:31:03 2021 -0700

defer/rcufundamental: Wordsmith QQ answer about writes in RCU readers

defer/rcufundamental.tex +1 -6
index 66f9b702..054512e0 100644
@@ -330,12 +330,17 @@ greater detail in \cref{sec:memorder:RCU}.
        \co{P1()}'s grace period.
 
        It might seem strange to have RCU read-side critical sections
-       containing writes, but RCU is just fine with this.
-       This capability is used frequently in the Linux kernel, for
-       example, acquiring a lock on or reference to a data structure.
-       Acquiring either a lock or a reference results in a write
-       to memory, and it is OK to do these within an RCU read-side
-       critical section.
+       containing writes, but this capability is not only permitted,

defer/rcufundamental.tex greater detail in \cref{sec:memorder:RCU}. · line 343

Quoted 10 lines
defer/rcufundamental.tex +10 -0
+       but also highly useful.
+       For example, the Linux kernel frequently carries out an
+       RCU-protected traversal of a linked data structure and then
+       acquires a reference to the destination data element.
+       Because this data element must not be freed in the meantime,
+       that element's reference counter must necessarily be incremented
+       within the traversal's RCU read-side critical section.
+       However, that increment entails a write to memory.
+       Therefore, it is a very good thing that memory writes are
+       permitted within RCU read-side critical sections.

The revised paragraph is easier for me to understand, especially why acquiring a reference to a data structure entails a write ;-)

Quoted 1 line
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

If having writes in RCU read-side critical sections still seems strange, please review

The revised edition looks wonderful, thank you

Glad you like it, and thank you for pointing me at the original awkward sentence!

You are very welcome ;-), reading the book itself is a
self-improvement process,
To be honest, by reading the book, I find you are the example worth following in my career life.

Quoted 2 lines

Thanx, Paul

Best Wishes
Zhouyi