Skip to contentSkip to conversation

net/tcp_fastopen: remove obsolete extern

PATCH Applied Eric Dumazet 3 participants 3 messages Jul 19, 2021 – Jul 20, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/tcp_fastopen: remove obsolete extern

From: Eric Dumazet <[email protected]>

After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer a global variable.

Fixes 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob")
Cc Haishuang Yan <[email protected]>
Cc Wei Wang <[email protected]>
Cc Yuchung Cheng <[email protected]>
Cc Neal Cardwell <[email protected]>
---
 include/net/tcp.h | 1 -
 1 file changed, 1 deletion(-)
include/net/tcp.h +0 -1
index 17df9b047ee46dabed8797246f99e1a2fd39c243..784d5c3ef1c5be0b54194711ff7f306d271d95c3 100644
@@ -1709,7 +1709,6 @@ struct tcp_fastopen_context {
 	struct rcu_head	rcu;
 };
 
-extern unsigned int sysctl_tcp_fastopen_blackhole_timeout;
 void tcp_fastopen_active_disable(struct sock *sk);
 bool tcp_fastopen_active_should_disable(struct sock *sk);
 void tcp_fastopen_active_disable_ofo_check(struct sock *sk);
Signature · 1 line
2.32.0.402.g57bb445576-goog
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Eric Dumazet

From: Eric Dumazet <[email protected]>

After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer a global variable.

Quoted 7 lines
Fixes 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob")
Cc Haishuang Yan <[email protected]>
Cc Wei Wang <[email protected]>
Cc Yuchung Cheng <[email protected]>
Cc Neal Cardwell <[email protected]>

---

Quoted 18 lines
 include/net/tcp.h | 1 -
 1 file changed, 1 deletion(-)
include/net/tcp.h +0 -2
index 17df9b047ee46dabed8797246f99e1a2fd39c243..784d5c3ef1c5be0b54194711ff7f306d271d95c3 100644
@@ -1709,7 +1709,6 @@ struct tcp_fastopen_context {
        struct rcu_head rcu;
 };
 
-extern unsigned int sysctl_tcp_fastopen_blackhole_timeout;
 void tcp_fastopen_active_disable(struct sock *sk);
 bool tcp_fastopen_active_should_disable(struct sock *sk);
 void tcp_fastopen_active_disable_ofo_check(struct sock *sk);
--

2.32.0.402.g57bb445576-goog

#2 lore raw
In reply to Eric Dumazet
This patch was applied to netdev/net.git (refs/heads/master):

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

Quoted 5 lines · On Mon, 19 Jul 2021 02:20:28 -0700 you wrote:

From: Eric Dumazet <[email protected]>

After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer a global variable.

Quoted 8 lines
Fixes 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob")
Cc Haishuang Yan <[email protected]>
Cc Wei Wang <[email protected]>
Cc Yuchung Cheng <[email protected]>
Cc Neal Cardwell <[email protected]>

[...]

Here is the summary with links:
- [net] net/tcp_fastopen: remove obsolete extern

    https://git.kernel.org/netdev/net/c/749468760b95

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html