Skip to contentSkip to conversation

mt7530 mt7530_fdb_write only set ivl bit vid larger than 1

PATCH Applied [email protected] 3 participants 3 messages Jul 19, 2021 – Jul 20, 2021

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mt7530 mt7530_fdb_write only set ivl bit vid larger than 1

From: Eric Woudstra <[email protected]>

Fixes my earlier patch which broke vlan unaware bridges.

The IVL bit now only gets set for vid's larger than 1.

Fixes 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit")
---
 drivers/net/dsa/mt7530.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/dsa/mt7530.c +2 -1
index 9e4df35f9..69f21b716 100644
@@ -366,7 +366,8 @@ mt7530_fdb_write(struct mt7530_priv *priv, u16 vid,
 	int i;
 
 	reg[1] |= vid & CVID_MASK;
-	reg[1] |= ATA2_IVL;
+	if (vid > 1)
+		reg[1] |= ATA2_IVL;
 	reg[2] |= (aging & AGE_TIMER_MASK) << AGE_TIMER;
 	reg[2] |= (port_mask & PORT_MAP_MASK) << PORT_MAP;
 	/* STATIC_ENT indicate that entry is static wouldn't
Signature · 7 lines
2.25.1


_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · On 7/19/21 11:23 AM, [email protected] wrote:

From: Eric Woudstra <[email protected]>

Fixes my earlier patch which broke vlan unaware bridges.

The IVL bit now only gets set for vid's larger than 1.

Fixes 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit")
Signature · 6 lines
Florian

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
#2 lore raw
In reply to [email protected]
This patch was applied to netdev/net.git (refs/heads/master):

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

Quoted 10 lines · On Mon, 19 Jul 2021 20:23:57 +0200 you wrote:

From: Eric Woudstra <[email protected]>

Fixes my earlier patch which broke vlan unaware bridges.

The IVL bit now only gets set for vid's larger than 1.

Fixes 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit")

[...]

Here is the summary with links:
- [net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1

    https://git.kernel.org/netdev/net/c/7e777021780e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek