Skip to contentSkip to conversation

arm64: dts: qcom: DTS updates

PATCH Applied Alex Elder 5 participants 12 messages Jul 19, 2021 – Aug 3, 2021

Subsystems (6)
lore
Share & tools
lore

Alex Elder

author
#0 lore raw

cover arm64: dts: qcom: DTS updates

This series updates some IPA-related DT nodes.

Newer versions of IPA do not require an interconnect between IPA and SoC internal memory. The first patch updates the DT binding to reflect this.

The second patch adds IPA information to "sc7280.dtsi", using only two interconnects. It includes the definition of the reserved memory area used to hold IPA firmware.

The last patch defines the reserved IPA firmware memory area in "sc7180.dtsi".

-Alex

Alex Elder (3):
dt-bindings: net: qcom,ipa: make imem interconnect optional
arm64: dts: qcom: sc7280: add IPA information
arm64: dts: qcom: sc7180: define ipa_fw_mem node

 .../devicetree/bindings/net/qcom,ipa.yaml     | 18 ++++----
 arch/arm64/boot/dts/qcom/sc7180.dtsi          |  5 +++
 arch/arm64/boot/dts/qcom/sc7280.dtsi          | 43 +++++++++++++++++++
 3 files changed, 58 insertions(+), 8 deletions(-)
Signature · 1 line
2.27.0
author
#1 lore raw

PATCH 1/3 dt-bindings: net: qcom,ipa: make imem interconnect optional

On some newer SoCs, the interconnect between IPA and SoC internal memory (imem) is not used. Reflect this in the binding by moving the definition of the "imem" interconnect to the end and defining minItems to be 2 for both the interconnects and interconnect-names properties.

---
 .../devicetree/bindings/net/qcom,ipa.yaml      | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +10 -8
index ed88ba4b94df5..4853ab7017bd9 100644
@@ -87,16 +87,18 @@ properties:
       - const: ipa-setup-ready
 
   interconnects:
+    minItems: 2
     items:
-      - description: Interconnect path between IPA and main memory
-      - description: Interconnect path between IPA and internal memory
-      - description: Interconnect path between IPA and the AP subsystem
+      - description: Path leading to system memory
+      - description: Path between the AP and IPA config space
+      - description: Path leading to internal memory
 
   interconnect-names:
+    minItems: 2
     items:
       - const: memory
-      - const: imem
       - const: config
+      - const: imem
 
   qcom,smem-states:
     $ref: /schemas/types.yaml#/definitions/phandle-array
@@ -207,11 +209,11 @@ examples:
 
                 interconnects =
                         <&rsc_hlos MASTER_IPA &rsc_hlos SLAVE_EBI1>,
-                        <&rsc_hlos MASTER_IPA &rsc_hlos SLAVE_IMEM>,
-                        <&rsc_hlos MASTER_APPSS_PROC &rsc_hlos SLAVE_IPA_CFG>;
+                        <&rsc_hlos MASTER_APPSS_PROC &rsc_hlos SLAVE_IPA_CFG>,
+                        <&rsc_hlos MASTER_IPA &rsc_hlos SLAVE_IMEM>;
                 interconnect-names = "memory",
-                                     "imem",
-                                     "config";
+                                     "config",
+                                     "imem";
 
                 qcom,smem-states = <&ipa_smp2p_out 0>,
                                    <&ipa_smp2p_out 1>;
Signature · 1 line
2.27.0
maintainer
#2 lore raw

Re: [PATCH net-next 1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional

Quoted 25 lines · Alex Elder

On some newer SoCs, the interconnect between IPA and SoC internal memory (imem) is not used. Reflect this in the binding by moving the definition of the "imem" interconnect to the end and defining minItems to be 2 for both the interconnects and interconnect-names properties.

---
 .../devicetree/bindings/net/qcom,ipa.yaml      | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +2 -3
index ed88ba4b94df5..4853ab7017bd9 100644
@@ -87,16 +87,18 @@ properties:
       - const: ipa-setup-ready
 
   interconnects:
+    minItems: 2
     items:
-      - description: Interconnect path between IPA and main memory
-      - description: Interconnect path between IPA and internal memory
-      - description: Interconnect path between IPA and the AP subsystem
+      - description: Path leading to system memory

Documentation/devicetree/bindings/net/qcom,ipa.yaml properties: · line 101

Quoted 10 lines
Documentation/devicetree/bindings/net/qcom,ipa.yaml +4 -1
+      - description: Path between the AP and IPA config space
+      - description: Path leading to internal memory
 
   interconnect-names:
+    minItems: 2
     items:
       - const: memory
-      - const: imem
       - const: config
+      - const: imem

What about existing users? This will generate warnings. Doing this for the 2nd item would avoid the need for .dts updates:

- enum: [ imem, config ]

Rob

#3 lore raw

Re: [PATCH net-next 1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional

Quoted 40 lines · Rob Herring
Quoted 25 lines · Alex Elder

On some newer SoCs, the interconnect between IPA and SoC internal memory (imem) is not used. Reflect this in the binding by moving the definition of the "imem" interconnect to the end and defining minItems to be 2 for both the interconnects and interconnect-names properties.

---
  .../devicetree/bindings/net/qcom,ipa.yaml      | 18 ++++++++++--------
  1 file changed, 10 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +2 -3
index ed88ba4b94df5..4853ab7017bd9 100644
@@ -87,16 +87,18 @@ properties:
        - const: ipa-setup-ready
 
    interconnects:
+    minItems: 2
      items:
-      - description: Interconnect path between IPA and main memory
-      - description: Interconnect path between IPA and internal memory
-      - description: Interconnect path between IPA and the AP subsystem
+      - description: Path leading to system memory

Documentation/devicetree/bindings/net/qcom,ipa.yaml properties: · line 101

Quoted 10 lines
Documentation/devicetree/bindings/net/qcom,ipa.yaml +4 -1
+      - description: Path between the AP and IPA config space
+      - description: Path leading to internal memory
 
    interconnect-names:
+    minItems: 2
      items:
        - const: memory
-      - const: imem
        - const: config
+      - const: imem

What about existing users? This will generate warnings. Doing this for the 2nd item would avoid the need for .dts updates:

Quoted 1 line

- enum: [ imem, config ]

If I understand correctly, the effect of this would be that the second item can either be "imem" or "config", and the third (if present) could only be "imem"?

And you're saying that otherwise, existing users (the only one it applies to at the moment is "sdm845.dtsi") would produce warnings, because the interconnects are listed in an order different from what the binding specifies.

Is that correct?

If so, what you propose suggests "imem" could be listed twice. It doesn't make sense, and maybe it's precluded in other ways so that's OK. But I'd be happy to update "sdm845.dtsi" to address your concern. (Maybe that's something you would rather avoid?)

Also, I need to make a separate update to "sm8350.dtsi" because
that was defined before I understood what I do now about the interconnects. It uses the wrong names, and should combine its first two interconnects into just one.

-Alex

Quoted 3 lines

Rob

maintainer
#4 lore raw

Re: [PATCH net-next 1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional

Quoted 42 lines · Alex Elder
Quoted 40 lines · Rob Herring
Quoted 25 lines · Alex Elder

On some newer SoCs, the interconnect between IPA and SoC internal memory (imem) is not used. Reflect this in the binding by moving the definition of the "imem" interconnect to the end and defining minItems to be 2 for both the interconnects and interconnect-names properties.

---
  .../devicetree/bindings/net/qcom,ipa.yaml      | 18 ++++++++++--------
  1 file changed, 10 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +2 -3
index ed88ba4b94df5..4853ab7017bd9 100644
@@ -87,16 +87,18 @@ properties:
        - const: ipa-setup-ready
 
    interconnects:
+    minItems: 2
      items:
-      - description: Interconnect path between IPA and main memory
-      - description: Interconnect path between IPA and internal memory
-      - description: Interconnect path between IPA and the AP subsystem
+      - description: Path leading to system memory

Documentation/devicetree/bindings/net/qcom,ipa.yaml properties: · line 101

Quoted 10 lines
Documentation/devicetree/bindings/net/qcom,ipa.yaml +4 -1
+      - description: Path between the AP and IPA config space
+      - description: Path leading to internal memory
 
    interconnect-names:
+    minItems: 2
      items:
        - const: memory
-      - const: imem
        - const: config
+      - const: imem

What about existing users? This will generate warnings. Doing this for the 2nd item would avoid the need for .dts updates:

Quoted 5 lines
Quoted 1 line

- enum: [ imem, config ]

If I understand correctly, the effect of this would be that the second item can either be "imem" or "config", and the third (if present) could only be "imem"?

Yes for the 2nd, but the 3rd item could only be 'config'.

Quoted 7 lines

And you're saying that otherwise, existing users (the only one it applies to at the moment is "sdm845.dtsi") would produce warnings, because the interconnects are listed in an order different from what the binding specifies.

Is that correct?

Yes.

Quoted 3 lines

If so, what you propose suggests "imem" could be listed twice. It doesn't make sense, and maybe it's precluded in other ways so that's OK.

Good observation. There are generic checks that the strings are unique.

Quoted 3 lines

But I'd be happy to update "sdm845.dtsi" to
address your concern. (Maybe that's something you would rather avoid?)

Better to not change DT if you don't have to. You're probably okay if all clients (consumers of the dtb) used names and didn't care about the order. And I have no idea if all users of SDM845 are okay with a DTB change being required. That's up to QCom maintainers. I only care that ABI breakages are documented as such.

Quoted 4 lines

Also, I need to make a separate update to "sm8350.dtsi" because that was defined before I understood what I do now about the interconnects. It uses the wrong names, and should combine its first two interconnects into just one.

If the interconnects was ignored in that case, then the change doesn't matter.

Rob

#5 lore raw

Re: [PATCH net-next 1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional

Quoted 43 lines · Rob Herring
Quoted 42 lines · Alex Elder
Quoted 40 lines · Rob Herring
Quoted 25 lines · Alex Elder

On some newer SoCs, the interconnect between IPA and SoC internal memory (imem) is not used. Reflect this in the binding by moving the definition of the "imem" interconnect to the end and defining minItems to be 2 for both the interconnects and interconnect-names properties.

---
   .../devicetree/bindings/net/qcom,ipa.yaml      | 18 ++++++++++--------
   1 file changed, 10 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +2 -3
index ed88ba4b94df5..4853ab7017bd9 100644
@@ -87,16 +87,18 @@ properties:
         - const: ipa-setup-ready
 
     interconnects:
+    minItems: 2
       items:
-      - description: Interconnect path between IPA and main memory
-      - description: Interconnect path between IPA and internal memory
-      - description: Interconnect path between IPA and the AP subsystem
+      - description: Path leading to system memory

Documentation/devicetree/bindings/net/qcom,ipa.yaml properties: · line 101

Quoted 10 lines
Documentation/devicetree/bindings/net/qcom,ipa.yaml +4 -1
+      - description: Path between the AP and IPA config space
+      - description: Path leading to internal memory
 
     interconnect-names:
+    minItems: 2
       items:
         - const: memory
-      - const: imem
         - const: config
+      - const: imem

What about existing users? This will generate warnings. Doing this for the 2nd item would avoid the need for .dts updates:

Quoted 1 line
Quoted 1 line
Quoted 1 line

- enum: [ imem, config ]

In other words:

interconnect-names:
minItems: 2
items:
- const: memory
- enum: [ imem, config ]
- const: imem

What do I do with the "interconnects" descriptions in that case? How do I make the "interconnect-names" specified this way align with the described interconnect values? Is that necessary?

Quoted 5 lines
Quoted 3 lines

If I understand correctly, the effect of this would be that the second item can either be "imem" or "config", and the third (if present) could only be "imem"?

Yes for the 2nd, but the 3rd item could only be 'config'.

Sorry, yes, that's what I meant. I might have misread the diff output.

Quoted 7 lines
Quoted 6 lines

And you're saying that otherwise, existing users (the only one it applies to at the moment is "sdm845.dtsi") would produce warnings, because the interconnects are listed in an order different from what the binding specifies.

Is that correct?

Quoted 7 lines

Yes.

Quoted 3 lines

If so, what you propose suggests "imem" could be listed twice. It doesn't make sense, and maybe it's precluded in other ways so that's OK.

Good observation. There are generic checks that the strings are unique.

I think I don't like that quite as much, because that "no duplicates" rule is implied. It also avoids any confusion in the "respectively" relationship between interconnects and interconnect-names.

I understand what you're suggesting though, and I would be happy to update the binding in the way you suggest. I'd like to hear what you say about my questions above before doing so.

Quoted 6 lines
Quoted 3 lines

But I'd be happy to update "sdm845.dtsi" to
address your concern. (Maybe that's something you would rather avoid?)

Better to not change DT if you don't have to. You're probably okay if all clients (consumers of the dtb) used names and didn't care about

In the IPA driver, wherever names are specified for things in DT, names (only) are used to look them up. So I'm "probably okay."

Quoted 10 lines

the order. And I have no idea if all users of SDM845 are okay with a DTB change being required. That's up to QCom maintainers. I only care that ABI breakages are documented as such.

Quoted 4 lines

Also, I need to make a separate update to "sm8350.dtsi" because that was defined before I understood what I do now about the interconnects. It uses the wrong names, and should combine its first two interconnects into just one.

If the interconnects was ignored in that case, then the change doesn't matter.

That platform is not yet fully supported by the IPA driver, thus there is (so far) no instance where it is used. Resolving this is part of enabling support for that.

Thanks.

-Alex

Quoted 2 lines

Rob

maintainer
#6 lore raw

Re: [PATCH net-next 1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional

Quoted 56 lines · Alex Elder
Quoted 43 lines · Rob Herring
Quoted 42 lines · Alex Elder
Quoted 40 lines · Rob Herring
Quoted 25 lines · Alex Elder

On some newer SoCs, the interconnect between IPA and SoC internal memory (imem) is not used. Reflect this in the binding by moving the definition of the "imem" interconnect to the end and defining minItems to be 2 for both the interconnects and interconnect-names properties.

---
   .../devicetree/bindings/net/qcom,ipa.yaml      | 18 ++++++++++--------
   1 file changed, 10 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +2 -3
index ed88ba4b94df5..4853ab7017bd9 100644
@@ -87,16 +87,18 @@ properties:
         - const: ipa-setup-ready
 
     interconnects:
+    minItems: 2
       items:
-      - description: Interconnect path between IPA and main memory
-      - description: Interconnect path between IPA and internal memory
-      - description: Interconnect path between IPA and the AP subsystem
+      - description: Path leading to system memory

Documentation/devicetree/bindings/net/qcom,ipa.yaml properties: · line 101

Quoted 10 lines
Documentation/devicetree/bindings/net/qcom,ipa.yaml +4 -1
+      - description: Path between the AP and IPA config space
+      - description: Path leading to internal memory
 
     interconnect-names:
+    minItems: 2
       items:
         - const: memory
-      - const: imem
         - const: config
+      - const: imem

What about existing users? This will generate warnings. Doing this for the 2nd item would avoid the need for .dts updates:

Quoted 1 line
Quoted 1 line
Quoted 1 line

- enum: [ imem, config ]

In other words:

interconnect-names:
minItems: 2
items:
- const: memory
- enum: [ imem, config ]
- const: imem

Quoted 3 lines

What do I do with the "interconnects" descriptions in that case? How do I make the "interconnect-names" specified this way align with the described interconnect values? Is that necessary?

The schema will only ever check or care that there are 2 or 3 entries. You can put whatever you want for the description. Or use 'oneOf' to have the 2 entry and 3 entry cases.

Quoted 22 lines
Quoted 5 lines
Quoted 3 lines

If I understand correctly, the effect of this would be that the second item can either be "imem" or "config", and the third (if present) could only be "imem"?

Yes for the 2nd, but the 3rd item could only be 'config'.

Sorry, yes, that's what I meant. I might have misread the diff output.

Quoted 13 lines
Quoted 6 lines

And you're saying that otherwise, existing users (the only one it applies to at the moment is "sdm845.dtsi") would produce warnings, because the interconnects are listed in an order different from what the binding specifies.

Is that correct?

Yes.

Quoted 3 lines

If so, what you propose suggests "imem" could be listed twice. It doesn't make sense, and maybe it's precluded in other ways so that's OK.

Quoted 6 lines
Quoted 1 line

Good observation. There are generic checks that the strings are unique.

I think I don't like that quite as much, because that "no duplicates" rule is implied. It also avoids any confusion in the "respectively" relationship between interconnects and interconnect-names.

We could be verbose about it using the 'uniqueItems' keyword, but I try to make the bindings follow the common case (for DT) rather than the default for json-schema. If you think about the purpose of '*-names', non-unique entries would never make sense as the purpose is to identify what each entry is.

Quoted 9 lines

I understand what you're suggesting though, and I would be happy to update the binding in the way you suggest. I'd like to hear what you say about my questions above before doing so.

Quoted 4 lines
Quoted 3 lines

But I'd be happy to update "sdm845.dtsi" to
address your concern. (Maybe that's something you would rather avoid?)

Quoted 5 lines
Quoted 2 lines

Better to not change DT if you don't have to. You're probably okay if all clients (consumers of the dtb) used names and didn't care about

In the IPA driver, wherever names are specified for things in DT, names (only) are used to look them up. So I'm "probably okay."

Yes, probably so. It's ultimately up to you and the Qcom maintainers what to do. I'm just providing how you could avoid the change.

Rob

author
#7 lore raw

PATCH 2/3 arm64: dts: qcom: sc7280: add IPA information

In reply to Alex Elder

Add IPA-related nodes and definitions to "sc7280.dtsi", including the reserved memory area used for AP-based IPA firmware loading.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 43 ++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
arch/arm64/boot/dts/qcom/sc7280.dtsi +43 -0
index a8c274ad74c47..5eb2b58ea23be 100644
@@ -7,6 +7,7 @@
 
 #include <dt-bindings/clock/qcom,gcc-sc7280.h>
 #include <dt-bindings/clock/qcom,rpmh.h>
+#include <dt-bindings/interconnect/qcom,sc7280.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/mailbox/qcom-ipcc.h>
 #include <dt-bindings/power/qcom-aoss-qmp.h>
@@ -63,6 +64,11 @@ cpucp_mem: memory@80b00000 {
 			no-map;
 			reg = <0x0 0x80b00000 0x0 0x100000>;
 		};
+
+		ipa_fw_mem: memory@8b700000 {
+			reg = <0 0x8b700000 0 0x10000>;
+			no-map;
+		};
 	};
 
 	cpus {
@@ -508,6 +514,43 @@ mmss_noc: interconnect@1740000 {
 			qcom,bcm-voters = <&apps_bcm_voter>;
 		};
 
+		ipa: ipa@1e40000 {
+			compatible = "qcom,sc7280-ipa";
+
+			iommus = <&apps_smmu 0x480 0x0>,
+				 <&apps_smmu 0x482 0x0>;
+			reg = <0 0x1e40000 0 0x8000>,
+			      <0 0x1e50000 0 0x4ad0>,
+			      <0 0x1e04000 0 0x23000>;
+			reg-names = "ipa-reg",
+				    "ipa-shared",
+				    "gsi";
+
+			interrupts-extended = <&intc 0 654 IRQ_TYPE_EDGE_RISING>,
+					      <&intc 0 432 IRQ_TYPE_LEVEL_HIGH>,
+					      <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
+					      <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "ipa",
+					  "gsi",
+					  "ipa-clock-query",
+					  "ipa-setup-ready";
+
+			clocks = <&rpmhcc RPMH_IPA_CLK>;
+			clock-names = "core";
+
+			interconnects = <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>,
+					<&gem_noc MASTER_APPSS_PROC 0 &cnoc2 SLAVE_IPA_CFG 0>;
+			interconnect-names = "memory",
+					     "config";
+
+			qcom,smem-states = <&ipa_smp2p_out 0>,
+					   <&ipa_smp2p_out 1>;
+			qcom,smem-state-names = "ipa-clock-enabled-valid",
+						"ipa-clock-enabled";
+
+			status = "disabled";
+		};
+
 		tcsr_mutex: hwlock@1f40000 {
 			compatible = "qcom,tcsr-mutex", "syscon";
 			reg = <0 0x01f40000 0 0x40000>;
Signature · 1 line
2.27.0
author
#8 lore raw

PATCH 3/3 arm64: dts: qcom: sc7180: define ipa_fw_mem node

In reply to Alex Elder

Define the reserved memory space used for IPA firmware for the Qualcomm SC7180 SoC.

---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/qcom/sc7180.dtsi +5 -0
index a5d58eb928960..7af551a1fd904 100644
@@ -110,6 +110,11 @@ tz_mem: memory@80b00000 {
 			no-map;
 		};
 
+		ipa_fw_mem: memory@8b700000 {
+			reg = <0 0x8b700000 0 0x10000>;
+			no-map;
+		};
+
 		rmtfs_mem: memory@94600000 {
 			compatible = "qcom,rmtfs-mem";
 			reg = <0x0 0x94600000 0x0 0x200000>;
Signature · 1 line
2.27.0
#9 lore raw
In reply to Alex Elder
This series was applied to netdev/net-next.git (refs/heads/master):

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

Quoted 11 lines · On Mon, 19 Jul 2021 16:24:53 -0500 you wrote:

This series updates some IPA-related DT nodes.

Newer versions of IPA do not require an interconnect between IPA and SoC internal memory. The first patch updates the DT binding to reflect this.

The second patch adds IPA information to "sc7280.dtsi", using only two interconnects. It includes the definition of the reserved memory area used to hold IPA firmware.

[...]

Here is the summary with links:
- [net-next,1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional

    https://git.kernel.org/netdev/net-next/c/6a0eb6c9d934
  - [net-next,2/3] arm64: dts: qcom: sc7280: add IPA information
    https://git.kernel.org/netdev/net-next/c/f8bd3c82bf7d
  - [net-next,3/3] arm64: dts: qcom: sc7180: define ipa_fw_mem node
    https://git.kernel.org/netdev/net-next/c/fd0f72c34bd9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

#10 lore raw
Quoted 4 lines · On Tue 20 Jul 09:20 CDT 2021, [email protected] wrote:

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

David, Jakub, can you please revert/drop the two "arm64: dts" patches from the net-next tree?

DTS patches are generally merged through the qcom and ultimately soc tree and I have a number of patches queued up in both sc7180 and sc7280 that will cause merge conflicts down the road, so I would prefer to pick these up as well.

Regards,
Bjorn

Quoted 27 lines · On Mon, 19 Jul 2021 16:24:53 -0500 you wrote:
Quoted 11 lines

This series updates some IPA-related DT nodes.

Newer versions of IPA do not require an interconnect between IPA and SoC internal memory. The first patch updates the DT binding to reflect this.

The second patch adds IPA information to "sc7280.dtsi", using only two interconnects. It includes the definition of the reserved memory area used to hold IPA firmware.

[...]

Here is the summary with links:
- [net-next,1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional

    https://git.kernel.org/netdev/net-next/c/6a0eb6c9d934
  - [net-next,2/3] arm64: dts: qcom: sc7280: add IPA information
    https://git.kernel.org/netdev/net-next/c/f8bd3c82bf7d
  - [net-next,3/3] arm64: dts: qcom: sc7180: define ipa_fw_mem node
    https://git.kernel.org/netdev/net-next/c/fd0f72c34bd9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

#11 lore raw
Quoted 9 lines · Bjorn Andersson
Quoted 4 lines · On Tue 20 Jul 09:20 CDT 2021, [email protected] wrote:

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

David, Jakub, can you please revert/drop the two "arm64: dts" patches from the net-next tree?

David, I intended for this series to go through the Qualcomm repository rather than net-next, to avoid any conflicts with other updates to the affected DTS file. The only indication I made was by having you and Jakub in the "Cc" list rather than "To" list; in the future I will be more obvious in the cover page.

Would you please revert the entire merge, so that these commits can go through the Qualcomm repository? These are the commits (in order):
6a0eb6c9d9341 dt-bindings: net: qcom,ipa: make imem interconnect optional f8bd3c82bf7d7 arm64: dts: qcom: sc7280: add IPA information fd0f72c34bd96 arm64: dts: qcom: sc7180: define ipa_fw_mem node b79c6fba6cd7c Merge branch 'qcom-dts-updates'

If there is another way you think this should be handled, please explain. Thanks.

-Alex

Quoted 36 lines

DTS patches are generally merged through the qcom and ultimately soc tree and I have a number of patches queued up in both sc7180 and sc7280 that will cause merge conflicts down the road, so I would prefer to pick these up as well.

Regards,
Bjorn

Quoted 27 lines · On Mon, 19 Jul 2021 16:24:53 -0500 you wrote:
Quoted 11 lines

This series updates some IPA-related DT nodes.

Newer versions of IPA do not require an interconnect between IPA and SoC internal memory. The first patch updates the DT binding to reflect this.

The second patch adds IPA information to "sc7280.dtsi", using only two interconnects. It includes the definition of the reserved memory area used to hold IPA firmware.

[...]

Here is the summary with links:
- [net-next,1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional

     https://git.kernel.org/netdev/net-next/c/6a0eb6c9d934
   - [net-next,2/3] arm64: dts: qcom: sc7280: add IPA information
     https://git.kernel.org/netdev/net-next/c/f8bd3c82bf7d
   - [net-next,3/3] arm64: dts: qcom: sc7180: define ipa_fw_mem node
     https://git.kernel.org/netdev/net-next/c/fd0f72c34bd9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html