powerpc/perf: Clear pending PMI in ppmu callbacks
v4 cover powerpc/perf: Clear pending PMI in ppmu callbacks
Running perf fuzzer testsuite popped up below messages in the dmesg logs:
"Can't find PMC that caused IRQ"
This means a PMU exception happened, but none of the PMC's (Performance Monitor Counter) were found to be overflown. Perf interrupt handler checks the PMC's to see which PMC has overflown and if none of the PMCs are overflown ( counter value not >= 0x80000000 ), it throws warning:
"Can't find PMC that caused IRQ".
Powerpc has capability to mask and replay a performance monitoring interrupt (PMI). In case of replayed PMI, there are some corner cases that clears the PMCs after masking. In such cases, the perf interrupt handler will not find the active PMC values that had caused the overflow and thus leading to this message. This patchset attempts to fix those corner cases.
However there is one more case in PowerNV where these messages are emitted during system wide profiling or when a specific CPU is monitored for an event. That is, when a counter overflow just before entering idle and a PMI gets triggered after wakeup from idle. Since PMCs are not saved in the idle path, perf interrupt handler will not find overflown counter value and emits the "Can't find PMC" messages. This patch documents this race condition in powerpc core-book3s.
Patch fixes the ppmu callbacks to disable pending interrupt before clearing the overflown PMC and documents the race condition in idle path.
Changelog:
changes from v3 -> v4
Addressed review comments from Nicholas Piggin
- Added comment explaining the need to clear MMCR0 PMXE bit in pmu disable callback.
- Added a check to display warning if there is a PMI pending bit set in Paca without any overflown PMC.
- Removed the condition check before clearing pending PMI in 'clear_pmi_irq_pending' function.
- Added reviewed by from Nicholas Piggin.
Changes from v2 -> v3
Addressed review comments from Nicholas Piggin
- Moved the clearing of PMI bit to power_pmu_disable. In previous versions, this was done in power_pmu_del, power_pmu_stop/enable callbacks before clearing of PMC's.
- power_pmu_disable is called before any event gets deleted or stopped. If more than one event is running in the PMU, we may clear the PMI bit for an event which is not going to be deleted/stopped. Hence introduced check in power_pmu_enable to set back PMI to avoid dropping of valid samples in such cases.
- Disable MMCR0 PMXE bit in pmu disable callback which otherwise could trigger PMI when PMU is getting disabled.
Changes from v1 -> v2
Addressed review comments from Nicholas Piggin
- Moved the PMI pending check and clearing function to arch/powerpc/include/asm/hw_irq.h and renamed function to "get_clear_pmi_irq_pending"
- Along with checking for pending PMI bit in Paca, look for PMAO bit in MMCR0 register to decide on pending PMI interrupt.
Athira Rajeev (1):
powerpc/perf: Fix PMU callbacks to clear pending PMI before resetting
an overflown PMC
arch/powerpc/include/asm/hw_irq.h | 38 +++++++++++++++++++++++++ arch/powerpc/perf/core-book3s.c | 59 ++++++++++++++++++++++++++++++++++++++- 2 files changed, 96 insertions(+), 1 deletion(-)
Signature · 1 line
1.8.3.1
PATCH v4 1/1 powerpc/perf: Fix PMU callbacks to clear pending PMI before resetting an overflown PMC
Running perf fuzzer showed below in dmesg logs:
"Can't find PMC that caused IRQ"
This means a PMU exception happened, but none of the PMC's (Performance Monitor Counter) were found to be overflown. There are some corner cases that clears the PMCs after PMI gets masked. In such cases, the perf interrupt handler will not find the active PMC values that had caused the overflow and thus leads to this message while replaying.
Case 1: PMU Interrupt happens during replay of other interrupts and counter values gets cleared by PMU callbacks before replay:
During replay of interrupts like timer, __do_irq and doorbell exception, we conditionally enable interrupts via may_hard_irq_enable(). This could potentially create a window to generate a PMI. Since irq soft mask is set to ALL_DISABLED, the PMI will get masked here. We could get IPIs run before perf interrupt is replayed and the PMU events could deleted or stopped. This will change the PMU SPR values and resets the counters. Snippet of ftrace log showing PMU callbacks invoked in "__do_irq":
<idle>-0 [051] dns. 132025441306354: __do_irq <-call_do_irq
<idle>-0 [051] dns. 132025441306430: irq_enter <-__do_irq
<idle>-0 [051] dns. 132025441306503: irq_enter_rcu <-__do_irq
<idle>-0 [051] dnH. 132025441306599: xive_get_irq <-__do_irq
<<>>
<idle>-0 [051] dnH. 132025441307770: generic_smp_call_function_single_interrupt <-smp_ipi_demux_relaxed <idle>-0 [051] dnH. 132025441307839: flush_smp_call_function_queue <-smp_ipi_demux_relaxed <idle>-0 [051] dnH. 132025441308057: _raw_spin_lock <-event_function
<idle>-0 [051] dnH. 132025441308206: power_pmu_disable <-perf_pmu_disable
<idle>-0 [051] dnH. 132025441308337: power_pmu_del <-event_sched_out
<idle>-0 [051] dnH. 132025441308407: power_pmu_read <-power_pmu_del
<idle>-0 [051] dnH. 132025441308477: read_pmc <-power_pmu_read
<idle>-0 [051] dnH. 132025441308590: isa207_disable_pmc <-power_pmu_del
<idle>-0 [051] dnH. 132025441308663: write_pmc <-power_pmu_del
<idle>-0 [051] dnH. 132025441308787: power_pmu_event_idx <-perf_event_update_userpage <idle>-0 [051] dnH. 132025441308859: rcu_read_unlock_strict <-perf_event_update_userpage <idle>-0 [051] dnH. 132025441308975: power_pmu_enable <-perf_pmu_enable
<<>>
<idle>-0 [051] dnH. 132025441311108: irq_exit <-__do_irq
<idle>-0 [051] dns. 132025441311319: performance_monitor_exception <-replay_soft_interrupts
Case 2: PMI's masked during local_* operations, example local_add. If the local_add operation happens within a local_irq_save, replay of PMI will be during local_irq_restore. Similar to case 1, this could also create a window before replay where PMU events gets deleted or stopped.
Patch adds a fix to update the PMU callback function 'power_pmu_disable' to check for pending perf interrupt. If there is an overflown PMC and pending perf interrupt indicated in Paca, clear the PMI bit in paca to drop that sample. Clearing of PMI bit is done in 'power_pmu_disable' since disable is invoked before any event gets deleted/stopped. With this fix, if there are more than one event running in the PMU, there is a chance that we clear the PMI bit for the event which is not getting deleted/stopped. The other events may still remain active. Hence to make sure we don't drop valid sample in such cases, another check is added in power_pmu_enable. This checks if there is an overflown PMC found among the active events and if so enable back the PMI bit. Two new helper functions are introduced to clear/set the PMI, ie 'clear_pmi_irq_pending' and 'set_pmi_irq_pending'. Helper function 'pmi_irq_pending' is introduced to give a warning if there is pending PMI bit in paca, but no PMC is overflown.
Also there are corner cases which results in performance monitor interrupts getting triggered during power_pmu_disable. This happens since PMXE bit is not cleared along with disabling of other MMCR0 bits in the pmu_disable. Such PMI's could leave the PMU running and could trigger PMI again which will set MMCR0 PMAO bit. This could lead to spurious interrupts in some corner cases. Example, a timer after power_pmu_del which will re-enable interrupts and triggers a PMI again since PMAO bit is still set. But fails to find valid overflow since PMC get cleared in power_pmu_del. Patch fixes this by disabling PMXE along with disabling of other MMCR0 bits in power_pmu_disable.
We can't just replay PMI any time. Hence this approach is preferred rather than replaying PMI before resetting overflown PMC. Patch also documents core-book3s on a race condition which can trigger these PMC messages during idle path in PowerNV.
--- arch/powerpc/include/asm/hw_irq.h | 38 +++++++++++++++++++++++++ arch/powerpc/perf/core-book3s.c | 59 ++++++++++++++++++++++++++++++++++++++- 2 files changed, 96 insertions(+), 1 deletion(-)
arch/powerpc/include/asm/hw_irq.h +38 -0
@@ -224,6 +224,40 @@ static inline bool arch_irqs_disabled(void)return arch_irqs_disabled_flags (arch_local_save_flags ()); } +static inline void set_pmi_irq_pending (void ) +{ +/* +* Invoked from PMU callback functions to set +* PMI bit in Paca. This has to be called with +* irq's disabled ( via hard_irq_disable ). +*/ +if (IS_ENABLED (CONFIG_PPC_IRQ_SOFT_MASK_DEBUG )) +WARN_ON_ONCE (mfmsr () &MSR_EE ); +get_paca ()->irq_happened |=PACA_IRQ_PMI ; +} + +static inline void clear_pmi_irq_pending (void ) +{ +/* +* Invoked from PMU callback functions to clear +* the pending PMI bit in Paca. +*/ +if (IS_ENABLED (CONFIG_PPC_IRQ_SOFT_MASK_DEBUG )) +WARN_ON_ONCE (mfmsr () &MSR_EE ); +get_paca ()->irq_happened &= ~PACA_IRQ_PMI ; +} + +static inline int pmi_irq_pending (void ) +{ +/* +* Invoked from PMU callback functions to check +* if there is a pending PMI bit in Paca. +*/ +if (get_paca ()->irq_happened &PACA_IRQ_PMI ) +return 1 ; +return 0 ; +} +#ifdef CONFIG_PPC_BOOK3S /* * To support disabling and enabling of irq with PMI, set of
@@ -408,6 +442,10 @@ static inline void do_hard_irq_enable(void)BUILD_BUG (); } +static inline void clear_pmi_irq_pending (void ) { } +static inline void set_pmi_irq_pending (void ) { } +static inline int pmi_irq_pending (void ) {return 0 ; } +static inline void irq_soft_mask_regs_set_state (struct pt_regs *regs,unsigned long val) { }
arch/powerpc/perf/core-book3s.c +58 -1
99 lines not on this page · raw message
Signature · 1 line
1.8.3.1
Re: [PATCH V4 1/1] powerpc/perf: Fix PMU callbacks to clear pending PMI before resetting an overflown PMC
Quoted 78 lines · Athira Rajeev
Running perf fuzzer showed below in dmesg logs:
"Can't find PMC that caused IRQ"This means a PMU exception happened, but none of the PMC's (Performance Monitor Counter) were found to be overflown. There are some corner cases that clears the PMCs after PMI gets masked. In such cases, the perf interrupt handler will not find the active PMC values that had caused the overflow and thus leads to this message while replaying.
Case 1: PMU Interrupt happens during replay of other interrupts and counter values gets cleared by PMU callbacks before replay:
During replay of interrupts like timer,
__do_irqand doorbell exception, we conditionally enable interrupts viamay_hard_irq_enable(). This could potentially create a window to generate a PMI. Since irq soft mask is set toALL_DISABLED, the PMI will get masked here. We could get IPIs run before perf interrupt is replayed and the PMU events could deleted or stopped. This will change the PMU SPR values and resets the counters. Snippet of ftrace log showing PMU callbacks invoked in "__do_irq":<idle>-0 [051] dns. 132025441306354:
__do_irq<-call_do_irq
<idle>-0 [051] dns. 132025441306430:irq_enter<-__do_irq
<idle>-0 [051] dns. 132025441306503:irq_enter_rcu<-__do_irq
<idle>-0 [051] dnH. 132025441306599:xive_get_irq<-__do_irq
<<>>
<idle>-0 [051] dnH. 132025441307770:generic_smp_call_function_single_interrupt<-smp_ipi_demux_relaxed <idle>-0 [051] dnH. 132025441307839:flush_smp_call_function_queue<-smp_ipi_demux_relaxed <idle>-0 [051] dnH. 132025441308057:_raw_spin_lock<-event_function
<idle>-0 [051] dnH. 132025441308206:power_pmu_disable<-perf_pmu_disable
<idle>-0 [051] dnH. 132025441308337:power_pmu_del<-event_sched_out
<idle>-0 [051] dnH. 132025441308407:power_pmu_read<-power_pmu_del
<idle>-0 [051] dnH. 132025441308477:read_pmc<-power_pmu_read
<idle>-0 [051] dnH. 132025441308590:isa207_disable_pmc<-power_pmu_del
<idle>-0 [051] dnH. 132025441308663:write_pmc<-power_pmu_del
<idle>-0 [051] dnH. 132025441308787:power_pmu_event_idx<-perf_event_update_userpage <idle>-0 [051] dnH. 132025441308859:rcu_read_unlock_strict<-perf_event_update_userpage <idle>-0 [051] dnH. 132025441308975:power_pmu_enable<-perf_pmu_enable
<<>>
<idle>-0 [051] dnH. 132025441311108:irq_exit<-__do_irq
<idle>-0 [051] dns. 132025441311319:performance_monitor_exception<-replay_soft_interruptsCase 2: PMI's masked during local_* operations, example
local_add. If thelocal_addoperation happens within alocal_irq_save, replay of PMI will be duringlocal_irq_restore. Similar to case 1, this could also create a window before replay where PMU events gets deleted or stopped.Patch adds a fix to update the PMU callback function '
power_pmu_disable' to check for pending perf interrupt. If there is an overflown PMC and pending perf interrupt indicated in Paca, clear the PMI bit in paca to drop that sample. Clearing of PMI bit is done in 'power_pmu_disable' since disable is invoked before any event gets deleted/stopped. With this fix, if there are more than one event running in the PMU, there is a chance that we clear the PMI bit for the event which is not getting deleted/stopped. The other events may still remain active. Hence to make sure we don't drop valid sample in such cases, another check is added inpower_pmu_enable. This checks if there is an overflown PMC found among the active events and if so enable back the PMI bit. Two new helper functions are introduced to clear/set the PMI, ie 'clear_pmi_irq_pending' and 'set_pmi_irq_pending'. Helper function 'pmi_irq_pending' is introduced to give a warning if there is pending PMI bit in paca, but no PMC is overflown.Also there are corner cases which results in performance monitor interrupts getting triggered during
power_pmu_disable. This happens since PMXE bit is not cleared along with disabling of other MMCR0 bits in thepmu_disable. Such PMI's could leave the PMU running and could trigger PMI again which will set MMCR0 PMAO bit. This could lead to spurious interrupts in some corner cases. Example, a timer afterpower_pmu_delwhich will re-enable interrupts and triggers a PMI again since PMAO bit is still set. But fails to find valid overflow since PMC get cleared inpower_pmu_del. Patch fixes this by disabling PMXE along with disabling of other MMCR0 bits inpower_pmu_disable.We can't just replay PMI any time. Hence this approach is preferred rather than replaying PMI before resetting overflown PMC. Patch also documents core-book3s on a race condition which can trigger these PMC messages during idle path in PowerNV.
Quoted 6 lines
Fixes f442d004806e ("powerpc/64s: Add support to mask perf interrupts and replay them")Reported-by Nageswara R Sastry <[email protected]>Suggested-by Nicholas Piggin <[email protected]>Suggested-by Madhavan Srinivasan <[email protected]>Signed-off-by Athira Rajeev <[email protected]>Reviewed-by Nicholas Piggin <[email protected]>
Quoted 171 lines
--- arch/powerpc/include/asm/hw_irq.h | 38 +++++++++++++++++++++++++ arch/powerpc/perf/core-book3s.c | 59 ++++++++++++++++++++++++++++++++++++++- 2 files changed, 96 insertions(+), 1 deletion(-)arch/powerpc/include/asm/hw_irq.h +38
-0@@ -224,6 +224,40 @@ static inline bool arch_irqs_disabled(void)return arch_irqs_disabled_flags (arch_local_save_flags ()); } +static inline void set_pmi_irq_pending (void ) +{ +/* +* Invoked from PMU callback functions to set +* PMI bit in Paca. This has to be called with +* irq's disabled ( via hard_irq_disable ). +*/ +if (IS_ENABLED (CONFIG_PPC_IRQ_SOFT_MASK_DEBUG )) +WARN_ON_ONCE (mfmsr () &MSR_EE ); +get_paca ()->irq_happened |=PACA_IRQ_PMI ; +} + +static inline void clear_pmi_irq_pending (void ) +{ +/* +* Invoked from PMU callback functions to clear +* the pending PMI bit in Paca. +*/ +if (IS_ENABLED (CONFIG_PPC_IRQ_SOFT_MASK_DEBUG )) +WARN_ON_ONCE (mfmsr () &MSR_EE ); +get_paca ()->irq_happened &= ~PACA_IRQ_PMI ; +} + +static inline int pmi_irq_pending (void ) +{ +/* +* Invoked from PMU callback functions to check +* if there is a pending PMI bit in Paca. +*/ +if (get_paca ()->irq_happened &PACA_IRQ_PMI ) +return 1 ; +return 0 ; +} +#ifdef CONFIG_PPC_BOOK3S /* * To support disabling and enabling of irq with PMI, set of @@ -408,6 +442,10 @@ static inline void do_hard_irq_enable(void)BUILD_BUG (); } +static inline void clear_pmi_irq_pending (void ) { } +static inline void set_pmi_irq_pending (void ) { } +static inline int pmi_irq_pending (void ) {return 0 ; } +static inline void irq_soft_mask_regs_set_state (struct pt_regs *regs,unsigned long val) { }arch/powerpc/perf/core-book3s.c +58
-1@@ -848,6 +848,19 @@ static void write_pmc(int idx, unsigned long val) } } +static int any_pmc_overflown (struct cpu_hw_events *cpuhw) +{ +int i, idx; + +for (i =0 ; i < cpuhw->n_events; i++) { + idx = cpuhw->event[i]->hw.idx; +if ((idx) && ((int )read_pmc (idx) <0 )) +return idx; + } + +return 0 ; +} +/* Called from sysrq_handle_showregs() */ void perf_event_print_debug (void ) {@@ -1272,11 +1285,13 @@ static void power_pmu_disable(struct pmu *pmu)/* * Set the 'freeze counters' bit, clear EBE/BHRBA/PMCC/PMAO/FC56 +* Also clear PMXE to disable PMI's getting triggered in some +* corner cases during PMU disable. */ val = mmcr0 =mfspr (SPRN_MMCR0 ); val |=MMCR0_FC ; val &= ~(MMCR0_EBE |MMCR0_BHRBA |MMCR0_PMCC |MMCR0_PMAO | -MMCR0_FC56 ); +MMCR0_PMXE |MMCR0_FC56 );/* Set mmcr0 PMCCEXT for p10 */ if (ppmu->flags &PPMU_ARCH_31 ) val |=MMCR0_PMCCEXT ;@@ -1290,6 +1305,24 @@ static void power_pmu_disable(struct pmu *pmu)mb ();isync (); +/* +* Some corner cases could clear the PMU counter overflow +* while a masked PMI is pending. One of such case is +* when a PMI happens during interrupt replay and perf +* counter values gets cleared by PMU callbacks before +* replay. +* +* If any of PMC corresponding to the active PMU events is +* overflown, disable the interrupt by clearing the paca +* bit for PMI since we are disabling the PMU now. +* Otherwise provide a warning if there is PMI pending, but +* no counter is found overflown. +*/ +if (any_pmc_overflown (cpuhw)) +clear_pmi_irq_pending (); +else +WARN_ON (pmi_irq_pending ()); + val = mmcra = cpuhw->mmcr.mmcra;/* @@ -1381,6 +1414,15 @@ static void power_pmu_enable(struct pmu *pmu)* (possibly updated for removal of events). */ if (!cpuhw->n_added) { +/* +* If there is any active event with an overflown PMC +* value, Set back PACA_IRQ_PMI which would have got +* cleared in power_pmu_disable. +*/ +hard_irq_disable (); +if (any_pmc_overflown (cpuhw)) +set_pmi_irq_pending (); +mtspr (SPRN_MMCRA , cpuhw->mmcr.mmcra & ~MMCRA_SAMPLE_ENABLE );mtspr (SPRN_MMCR1 , cpuhw->mmcr.mmcr1);if (ppmu->flags &PPMU_ARCH_31 )@@ -2336,6 +2378,12 @@ static void __perf_event_interrupt(struct pt_regs *regs)break ; } } +/* +* Clear PACA_IRQ_PMI in case it was set by +* set_pmi_irq_pending() when PMU was enabled +* after accounting for interrupts. +*/ +clear_pmi_irq_pending ();if (!active)/* reset non active counters that have overflowed */ write_pmc (i +1 ,0 );@@ -2355,6 +2403,15 @@ static void __perf_event_interrupt(struct pt_regs *regs) } } } + +/* +* During system wide profling or while specific CPU +* is monitored for an event, some corner cases could +* cause PMC to overflow in idle path. This will trigger +* a PMI after waking up from idle. Since counter values +* are _not_ saved/restored in idle path, can lead to +* below "Can't find PMC" message. +*/ if (unlikely (!found) && !arch_irq_disabled_regs (regs))printk_ratelimited (KERN_WARNING "Can't find PMC that caused IRQ\n" );
Signature · 2 lines
Thanks and Regards R.Nageswara Sastry
Quoted 66 lines · Athira Rajeev
Running perf fuzzer testsuite popped up below messages in the dmesg logs:
"Can't find PMC that caused IRQ"
This means a PMU exception happened, but none of the PMC's (Performance Monitor Counter) were found to be overflown. Perf interrupt handler checks the PMC's to see which PMC has overflown and if none of the PMCs are overflown ( counter value not >=
0x80000000), it throws warning:
"Can't find PMC that caused IRQ".Powerpc has capability to mask and replay a performance monitoring interrupt (PMI). In case of replayed PMI, there are some corner cases that clears the PMCs after masking. In such cases, the perf interrupt handler will not find the active PMC values that had caused the overflow and thus leading to this message. This patchset attempts to fix those corner cases.
However there is one more case in PowerNV where these messages are emitted during system wide profiling or when a specific CPU is monitored for an event. That is, when a counter overflow just before entering idle and a PMI gets triggered after wakeup from idle. Since PMCs are not saved in the idle path, perf interrupt handler will not find overflown counter value and emits the "Can't find PMC" messages. This patch documents this race condition in powerpc core-book3s.
Patch fixes the ppmu callbacks to disable pending interrupt before clearing the overflown PMC and documents the race condition in idle path.
Changelog:
changes from v3 -> v4
Addressed review comments from Nicholas Piggin
- Added comment explaining the need to clear MMCR0 PMXE bit in pmu disable callback.
- Added a check to display warning if there is a PMI pending bit set in Paca without any overflown PMC.
- Removed the condition check before clearing pending PMI in 'clear_pmi_irq_pending' function.
- Added reviewed by from Nicholas Piggin.Changes from v2 -> v3
Addressed review comments from Nicholas Piggin
- Moved the clearing of PMI bit topower_pmu_disable. In previous versions, this was done inpower_pmu_del, power_pmu_stop/enable callbacks before clearing of PMC's.
-power_pmu_disableis called before any event gets deleted or stopped. If more than one event is running in the PMU, we may clear the PMI bit for an event which is not going to be deleted/stopped. Hence introduced check inpower_pmu_enableto set back PMI to avoid dropping of valid samples in such cases.
- Disable MMCR0 PMXE bit in pmu disable callback which otherwise could trigger PMI when PMU is getting disabled.
Changes from v1 -> v2
Addressed review comments from Nicholas Piggin
- Moved the PMI pending check and clearing function toarch/powerpc/include/asm/hw_irq.hand renamed function to "get_clear_pmi_irq_pending"
- Along with checking for pending PMI bit in Paca, look for PMAO bit in MMCR0 register to decide on pending PMI interrupt.
Quoted 3 lines
Athira Rajeev (1):
powerpc/perf: Fix PMU callbacks to clear pending PMI before resetting
an overflown PMC
Hi,
Please let me know if there are any review comments for this patch.
Thanks
Athira
Quoted 8 lines
arch/powerpc/include/asm/hw_irq.h| 38 +++++++++++++++++++++++++arch/powerpc/perf/core-book3s.c| 59 ++++++++++++++++++++++++++++++++++++++-2 files changed, 96 insertions(+), 1 deletion(-)Signature · 1 line
1.8.3.1
Nicholas Piggin
reviewerExcerpts from Athira Rajeev's message of November 20, 2021 12:36 am:
Quoted 70 lines
Quoted 66 lines · Athira Rajeev
Running perf fuzzer testsuite popped up below messages in the dmesg logs:
"Can't find PMC that caused IRQ"
This means a PMU exception happened, but none of the PMC's (Performance Monitor Counter) were found to be overflown. Perf interrupt handler checks the PMC's to see which PMC has overflown and if none of the PMCs are overflown ( counter value not >=
0x80000000), it throws warning:
"Can't find PMC that caused IRQ".Powerpc has capability to mask and replay a performance monitoring interrupt (PMI). In case of replayed PMI, there are some corner cases that clears the PMCs after masking. In such cases, the perf interrupt handler will not find the active PMC values that had caused the overflow and thus leading to this message. This patchset attempts to fix those corner cases.
However there is one more case in PowerNV where these messages are emitted during system wide profiling or when a specific CPU is monitored for an event. That is, when a counter overflow just before entering idle and a PMI gets triggered after wakeup from idle. Since PMCs are not saved in the idle path, perf interrupt handler will not find overflown counter value and emits the "Can't find PMC" messages. This patch documents this race condition in powerpc core-book3s.
Patch fixes the ppmu callbacks to disable pending interrupt before clearing the overflown PMC and documents the race condition in idle path.
Changelog:
changes from v3 -> v4
Addressed review comments from Nicholas Piggin
- Added comment explaining the need to clear MMCR0 PMXE bit in pmu disable callback.
- Added a check to display warning if there is a PMI pending bit set in Paca without any overflown PMC.
- Removed the condition check before clearing pending PMI in 'clear_pmi_irq_pending' function.
- Added reviewed by from Nicholas Piggin.Changes from v2 -> v3
Addressed review comments from Nicholas Piggin
- Moved the clearing of PMI bit topower_pmu_disable. In previous versions, this was done inpower_pmu_del, power_pmu_stop/enable callbacks before clearing of PMC's.
-power_pmu_disableis called before any event gets deleted or stopped. If more than one event is running in the PMU, we may clear the PMI bit for an event which is not going to be deleted/stopped. Hence introduced check inpower_pmu_enableto set back PMI to avoid dropping of valid samples in such cases.
- Disable MMCR0 PMXE bit in pmu disable callback which otherwise could trigger PMI when PMU is getting disabled.
Changes from v1 -> v2
Addressed review comments from Nicholas Piggin
- Moved the PMI pending check and clearing function toarch/powerpc/include/asm/hw_irq.hand renamed function to "get_clear_pmi_irq_pending"
- Along with checking for pending PMI bit in Paca, look for PMAO bit in MMCR0 register to decide on pending PMI interrupt.Quoted 3 lines
Athira Rajeev (1):
powerpc/perf: Fix PMU callbacks to clear pending PMI before resetting
an overflown PMC
Quoted 6 lines
Hi,
Please let me know if there are any review comments for this patch.
Thanks
Athira
It seems good to me. It already has my R-B. Would be good if we can get this one merged.
Thanks,
Nick
Michael Ellerman
AppliedQuoted 5 lines · Athira Rajeev
Running perf fuzzer testsuite popped up below messages in the dmesg logs:
"Can't find PMC that caused IRQ"
Quoted 7 lines
This means a PMU exception happened, but none of the PMC's (Performance Monitor Counter) were found to be overflown. Perf interrupt handler checks the PMC's to see which PMC has overflown and if none of the PMCs are overflown ( counter value not >=
0x80000000), it throws warning:
"Can't find PMC that caused IRQ".[...]
Applied to powerpc/next.
[1/1] powerpc/perf: Fix PMU callbacks to clear pending PMI before resetting an overflown PMC
https://git.kernel.org/powerpc/c/2c9ac51b850d84ee496b0a5d832ce66d411ae552
cheers