Skip to contentSkip to conversation

patch "usb: typec: tipd: Don't block probing of consumer of "connector"" added to usb-linus

PATCH [email protected] 1 participant 1 message Jul 21, 2021

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: typec: tipd: Don't block probing of consumer of "connector"

to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

From 57560ee95cb7f91cf0bc31d4ae8276e0dcfe17aa Mon Sep 17 00:00:00 2001
From: Martin Kepplinger <[email protected]>
Date: Wed, 14 Jul 2021 08:18:07 +0200
Subject: usb: typec: tipd: Don't block probing of consumer of "connector"
nodes

Similar as with tcpm this patch lets fw_devlink know not to wait on the fwnode to be populated as a struct device.

Without this patch, USB functionality can be broken on some previously supported boards.

Fixes 28ec344bb891 ("usb: typec: tcpm: Don't block probing of consumers of "connector" nodes")
Cc stable <[email protected]>
---
 drivers/usb/typec/tipd/core.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/usb/typec/tipd/core.c +9 -0
index 938219bc1b4b..21b3ae25c76d 100644
@@ -629,6 +629,15 @@ static int tps6598x_probe(struct i2c_client *client)
 	if (!fwnode)
 		return -ENODEV;
 
+	/*
+	 * This fwnode has a "compatible" property, but is never populated as a
+	 * struct device. Instead we simply parse it to read the properties.
+	 * This breaks fw_devlink=on. To maintain backward compatibility
+	 * with existing DT files, we work around this by deleting any
+	 * fwnode_links to/from this fwnode.
+	 */
+	fw_devlink_purge_absent_suppliers(fwnode);
+
 	tps->role_sw = fwnode_usb_role_switch_get(fwnode);
 	if (IS_ERR(tps->role_sw)) {
 		ret = PTR_ERR(tps->role_sw);
Signature · 1 line
2.32.0