iio: accel: add support for ADXL355
Subsystems (4)
v3 cover iio: accel: add support for ADXL355
Add the dt-bindings and the driver for ADXL355 3-axis MEMS Accelerometer.
Changes since v2:
1. Add separate DT binding doc in yaml.
2. Use ____cacheline_aligned buffer for regmap_bulk_read/write calls.
3. Make code consistent by using same style in switch case.
4. Use FIELD_PREP in place of custom macros.
5. Make Kconfig description more informative.
Changes since v1:
1. Remove the declarations for static regmap structures from adxl355.h. This was missed in the v1 and caused errors.
2. Make switch case statements consistent by directly returning from each case rather than saving the return in a variable.
3. Some coding style changes.
Changes since v0:
1. Move adxl355_hpf_3db_table to adxl355_data structure. This is done to make sure that each device gets its own table.
2. Make local regmap definitions private to adxl355_core.c.
3. Other minor coding style changes.
Puranjay Mohan (2):
dt-bindings: iio: accel: Add DT binding doc for ADXL355
iio: accel: Add driver support for ADXL355
.../bindings/iio/accel/adi,adxl355.yaml | 75 +++ MAINTAINERS | 7 + drivers/iio/accel/Kconfig | 29 + drivers/iio/accel/Makefile | 3 + drivers/iio/accel/adxl355.h | 77 +++ drivers/iio/accel/adxl355_core.c | 545 ++++++++++++++++++ drivers/iio/accel/adxl355_i2c.c | 63 ++ drivers/iio/accel/adxl355_spi.c | 66 +++ 8 files changed, 865 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml create mode 100644 drivers/iio/accel/adxl355.h create mode 100644 drivers/iio/accel/adxl355_core.c create mode 100644 drivers/iio/accel/adxl355_i2c.c create mode 100644 drivers/iio/accel/adxl355_spi.c
Signature · 1 line
2.30.1
PATCH v3 1/2 dt-bindings: iio: accel: Add DT binding doc for ADXL355
Add devicetree binding document for ADXL355, a 3-Axis MEMS Accelerometer.
--- .../bindings/iio/accel/adi,adxl355.yaml | 75 +++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml new file +75 -0
@@ -0,0 +1,75 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/accel/adi,adxl355.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices ADXL355 3-Axis, Low noise MEMS Accelerometer + +maintainers: + - Puranjay Mohan <[email protected]> + +description: | + Analog Devices ADXL355 3-Axis, Low noise MEMS Accelerometer that supports + both I2C & SPI interfaces + https://www.analog.com/en/products/adxl355.html + +properties: + compatible: + enum: + - adi,adxl355 + + reg: + maxItems: 1 + + interrupts: + items: + - description: DRDY PIN + - description: INT1 PIN + - description: INT2 PIN + + vdd-supply: + description: Regulator that provides power to the sensor + + vddio-supply: + description: Regulator that provides power to the bus + + spi-max-frequency: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + /* Example for a I2C device node */ + accelerometer@1D { + compatible = "adi,adxl355"; + reg = <0x1D>; + interrupt-parent = <&gpio>; + interrupts = <25 IRQ_TYPE_EDGE_RISING>; + }; + }; + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + spi0 { + #address-cells = <1>; + #size-cells = <0>; + + accelerometer@0 { + compatible = "adi,adxl355"; + reg = <0>; + spi-max-frequency = <1000000>; + interrupt-parent = <&gpio>; + interrupts = <25 IRQ_TYPE_EDGE_RISING>; + }; + };
Signature · 1 line
2.30.1
Rob Herring
maintainerRe: [PATCH v3 1/2] dt-bindings: iio: accel: Add DT binding doc for ADXL355
Quoted 8 lines · Puranjay Mohan
Add devicetree binding document for ADXL355, a 3-Axis MEMS Accelerometer.
Signed-off-by Puranjay Mohan <[email protected]>--- .../bindings/iio/accel/adi,adxl355.yaml | 75 +++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/accel/adi,adxl355.example.dt.yaml: accelerometer@1D: interrupts: [[25, 1]] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/accel/adi,adxl355.example.dt.yaml: accelerometer@0: interrupts: [[25, 1]] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
\ndoc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1510166
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
Rob Herring
maintainerRe: [PATCH v3 1/2] dt-bindings: iio: accel: Add DT binding doc for ADXL355
In reply to Puranjay MohanQuoted 14 lines · Puranjay Mohan
Add devicetree binding document for ADXL355, a 3-Axis MEMS Accelerometer.
Signed-off-by Puranjay Mohan <[email protected]>--- .../bindings/iio/accel/adi,adxl355.yaml | 75 +++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adxl355.yamlDocumentation/devicetree/bindings/iio/accel/adi,adxl355.yaml new file +0
-0
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml line 1
Quoted 1 line
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml new file +1
-0@@ -0,0 +1,75 @@ +# SPDX-License-Identifier: GPL-2.0
For new bindings:
GPL-2.0-only OR BSD-2-Clause
Quoted 38 lines
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml new file +38
-0+%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/accel/adi,adxl355.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices ADXL355 3-Axis, Low noise MEMS Accelerometer + +maintainers: + - Puranjay Mohan <[email protected]> + +description: | + Analog Devices ADXL355 3-Axis, Low noise MEMS Accelerometer that supports + both I2C & SPI interfaces + https://www.analog.com/en/products/adxl355.html + +properties: + compatible: + enum: + - adi,adxl355 + + reg: + maxItems: 1 + + interrupts: + items: + - description: DRDY PIN + - description: INT1 PIN + - description: INT2 PIN + + vdd-supply: + description: Regulator that provides power to the sensor + + vddio-supply: + description: Regulator that provides power to the bus + + spi-max-frequency: true + +required:
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml line 49
Quoted 10 lines
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml new file +10
-0+ - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + i2c0 {
i2c {
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml line 54
Quoted 5 lines
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml new file +5
-0+ #address-cells = <1>; + #size-cells = <0>; + + /* Example for a I2C device node */ + accelerometer@1D {
lowercase hex.
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml line 64
Quoted 10 lines
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml new file +10
-0+ compatible = "adi,adxl355"; + reg = <0x1D>; + interrupt-parent = <&gpio>; + interrupts = <25 IRQ_TYPE_EDGE_RISING>; + }; + }; + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + spi0 {
spi {
Quoted 15 lines
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml new file +11
-0+ #address-cells = <1>; + #size-cells = <0>; + + accelerometer@0 { + compatible = "adi,adxl355"; + reg = <0>; + spi-max-frequency = <1000000>; + interrupt-parent = <&gpio>; + interrupts = <25 IRQ_TYPE_EDGE_RISING>; + }; + };Signature · 1 line
2.30.1
PATCH v3 2/2 iio: accel: Add driver support for ADXL355
In reply to Puranjay MohanADXL355 is 3-axis MEMS Accelerometer. It offers low noise density, low 0g offset drift, low power with selectable measurement ranges. It also features programmable high-pass and low-pass filters.
Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/adxl354_adxl355.pdf
--- MAINTAINERS | 7 + drivers/iio/accel/Kconfig | 29 ++ drivers/iio/accel/Makefile | 3 + drivers/iio/accel/adxl355.h | 77 +++++ drivers/iio/accel/adxl355_core.c | 545 +++++++++++++++++++++++++++++++ drivers/iio/accel/adxl355_i2c.c | 63 ++++ drivers/iio/accel/adxl355_spi.c | 66 ++++ 7 files changed, 790 insertions(+) create mode 100644 drivers/iio/accel/adxl355.h create mode 100644 drivers/iio/accel/adxl355_core.c create mode 100644 drivers/iio/accel/adxl355_i2c.c create mode 100644 drivers/iio/accel/adxl355_spi.c
MAINTAINERS +7 -0
@@ -586,6 +586,13 @@ W: http://ez.analog.com/community/linux-device-drivers F: Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml F: drivers/input/misc/adxl34x.c +ADXL355 THREE-AXIS DIGITAL ACCELEROMETER DRIVER +M: Puranjay Mohan <[email protected]> +L: [email protected] +S: Supported +F: drivers/iio/accel/adxl34x.c +F: Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml + ADXL372 THREE-AXIS DIGITAL ACCELEROMETER DRIVER M: Michael Hennerich <[email protected]> S: Supported
drivers/iio/accel/Kconfig +29 -0
@@ -61,6 +61,35 @@ config ADXL345_SPI will be called adxl345_spi and you will also get adxl345_core for the core module. +config ADXL355 + tristate + +config ADXL355_I2C + tristate "Analog Devices ADXL355 3-Axis Digital Accelerometer I2C Driver" + depends on I2C + select ADXL355 + select REGMAP_I2C + help + Say Y here if you want to build i2c support for the Analog Devices + ADXL355 3-axis digital accelerometer. + + To compile this driver as a module, choose M here: the module + will be called adxl355_i2c and you will also get adxl355_core + for the core module. + +config ADXL355_SPI + tristate "Analog Devices ADXL355 3-Axis Digital Accelerometer SPI Driver" + depends on SPI + select ADXL355 + select REGMAP_SPI + help + Say Y here if you want to build spi support for the Analog Devices + ADXL355 3-axis digital accelerometer. + + To compile this driver as a module, choose M here: the module + will be called adxl355_spi and you will also get adxl355_core + for the core module. + config ADXL372 tristate select IIO_BUFFER
drivers/iio/accel/Makefile +3 -0
@@ -9,6 +9,9 @@ obj-$(CONFIG_ADIS16209) += adis16209.o obj-$(CONFIG_ADXL345) += adxl345_core.o obj-$(CONFIG_ADXL345_I2C) += adxl345_i2c.o obj-$(CONFIG_ADXL345_SPI) += adxl345_spi.o +obj-$(CONFIG_ADXL355) += adxl355_core.o +obj-$(CONFIG_ADXL355_I2C) += adxl355_i2c.o +obj-$(CONFIG_ADXL355_SPI) += adxl355_spi.o obj-$(CONFIG_ADXL372) += adxl372.o obj-$(CONFIG_ADXL372_I2C) += adxl372_i2c.o obj-$(CONFIG_ADXL372_SPI) += adxl372_spi.o
drivers/iio/accel/adxl355.h new file +77 -0
77 lines not on this page · raw message
drivers/iio/accel/adxl355_core.c new file +545 -0
545 lines not on this page · raw message
drivers/iio/accel/adxl355_i2c.c new file +63 -0
63 lines not on this page · raw message
drivers/iio/accel/adxl355_spi.c new file +66 -0
66 lines not on this page · raw message
Signature · 1 line
2.30.1