niu: read property length only if we use it
Subsystems (2)
PATCH 1/1 niu: read property length only if we use it
In three places, the driver calls of_get_property and reads the property length although the length is not used. Update the calls to not request the length.
Signed-off-by Martin Kaiser <[email protected]>
--- drivers/net/ethernet/sun/niu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/sun/niu.c +3 -3
@@ -9208,7 +9208,7 @@ static int niu_get_of_props(struct niu *np)else dp =pci_device_to_OF_node (np->pdev); - phy_type =of_get_property (dp,"phy-type" , &prop_len); + phy_type =of_get_property (dp,"phy-type" ,NULL );if (!phy_type) {netdev_err (dev,"%pOF: OF node lacks phy-type property\n" , dp);return -EINVAL ;
@@ -9242,12 +9242,12 @@ static int niu_get_of_props(struct niu *np)return -EINVAL ; } - model =of_get_property (dp,"model" , &prop_len); + model =of_get_property (dp,"model" ,NULL );if (model)strcpy (np->vpd.model, model); -if (of_find_property (dp,"hot-swappable-phy" , &prop_len)) { +if (of_find_property (dp,"hot-swappable-phy" ,NULL )) { np->flags |= (NIU_FLAGS_10G |NIU_FLAGS_FIBER |NIU_FLAGS_HOTPLUG_PHY ); }
Signature · 1 line
2.20.1
This patch was applied to netdev/net-next.git (refs/heads/master):
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
Quoted 8 lines · On Thu, 29 Jul 2021 09:43:54 +0200 you wrote:
In three places, the driver calls
of_get_propertyand reads the property length although the length is not used. Update the calls to not request the length.Signed-off-by Martin Kaiser <[email protected]>--- drivers/net/ethernet/sun/niu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
- niu: read property length only if we use it
https://git.kernel.org/netdev/net-next/c/451395f798a3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html