Skip to contentSkip to conversation

selftests/net: remove min gso test in packet_snd

PATCH Applied Dust Li 2 participants 2 messages Jul 30, 2021 – Aug 2, 2021

Subsystems (3)
lore
Share & tools
lore

Dust Li

author
#0 lore raw

PATCH 1/1 selftests/net: remove min gso test in packet_snd

This patch removed the 'raw gso min size - 1' test which always fails now:
./in_netns.sh ./psock_snd -v -c -g -l "${mss}"
raw gso min size - 1 (expected to fail)
tx: 1524
rx: 1472
OK

After commit 7c6d2ecbda83 ("net: be more gentle about silly gso requests coming from user"), we relaxed the min gso_size check in virtio_net_hdr_to_skb().
So when a packet which is smaller then the gso_size, GSO for this packet will not be set, the packet will be send/recv successfully.

---
 tools/testing/selftests/net/psock_snd.sh | 3 ---
 1 file changed, 3 deletions(-)
tools/testing/selftests/net/psock_snd.sh +0 -3
index 170be65e0816..1cbfeb5052ec 100755
@@ -86,9 +86,6 @@ echo "raw truncate hlen - 1 (expected to fail: EINVAL)"
 echo "raw gso min size"
 ./in_netns.sh ./psock_snd -v -c -g -l "${mss_exceeds}"
 
-echo "raw gso min size - 1 (expected to fail)"
-(! ./in_netns.sh ./psock_snd -v -c -g -l "${mss}")
-
 echo "raw gso max size"
 ./in_netns.sh ./psock_snd -v -c -g -l "${max_mss}"
 
Signature · 1 line
2.19.1.3.ge56e4f7
#1 lore raw
This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 9 lines · On Fri, 30 Jul 2021 11:41:55 +0800 you wrote:

This patch removed the 'raw gso min size - 1' test which always fails now:
./in_netns.sh ./psock_snd -v -c -g -l "${mss}"
raw gso min size - 1 (expected to fail)
tx: 1524
rx: 1472
OK

[...]

Here is the summary with links:
- selftests/net: remove min gso test in packet_snd

    https://git.kernel.org/netdev/net-next/c/cfba3fb68960

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html