Skip to contentSkip to conversation

qed: Avoid db_recovery during recovery

PATCH Applied Shai Malin 2 participants 2 messages Aug 1, 2021 – Aug 3, 2021

Subsystems (3)
lore
Share & tools
lore

Shai Malin

author
#0 lore raw

PATCH 1/1 qed: Avoid db_recovery during recovery

Avoid calling the qed doorbell recovery - qed_db_rec_handler() during device recovery.

---
 drivers/net/ethernet/qlogic/qed/qed_main.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/net/ethernet/qlogic/qed/qed_main.c +5 -0
index aa48b1b7eddc..6871d892eabf 100644
@@ -1215,6 +1215,10 @@ static void qed_slowpath_task(struct work_struct *work)
 
 	if (test_and_clear_bit(QED_SLOWPATH_PERIODIC_DB_REC,
 			       &hwfn->slowpath_task_flags)) {
+		/* skip qed_db_rec_handler during recovery/unload */
+		if (hwfn->cdev->recov_in_prog || !hwfn->slowpath_wq_active)
+			goto out;
+
 		qed_db_rec_handler(hwfn, ptt);
 		if (hwfn->periodic_db_rec_count--)
 			qed_slowpath_delayed_work(hwfn,
@@ -1222,6 +1226,7 @@ static void qed_slowpath_task(struct work_struct *work)
 						  QED_PERIODIC_DB_REC_INTERVAL);
 	}
 
+out:
 	qed_ptt_release(hwfn, ptt);
 }
 
Signature · 1 line
2.22.0
#1 lore raw
This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 8 lines · On Sun, 1 Aug 2021 13:23:40 +0300 you wrote:

Avoid calling the qed doorbell recovery - qed_db_rec_handler() during device recovery.

---
 drivers/net/ethernet/qlogic/qed/qed_main.c | 5 +++++
 1 file changed, 5 insertions(+)

Here is the summary with links:
- qed: Avoid db_recovery during recovery

    https://git.kernel.org/netdev/net-next/c/995c3d49bd71

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html