Skip to contentSkip to conversation

qed: Skip DORQ attention handling during recovery

PATCH Applied Shai Malin 2 participants 2 messages Aug 1, 2021 – Aug 3, 2021

Subsystems (3)
lore
Share & tools
lore

Shai Malin

author
#0 lore raw

PATCH 1/1 qed: Skip DORQ attention handling during recovery

The device recovery flow will reset the entire HW device, in that case the DORQ HW block attention is redundant.

---
 drivers/net/ethernet/qlogic/qed/qed_int.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
drivers/net/ethernet/qlogic/qed/qed_int.c +11 -1
index 578935f643b8..ab6d4f737316 100644
@@ -464,12 +464,19 @@ static int qed_dorq_attn_int_sts(struct qed_hwfn *p_hwfn)
 	u32 int_sts, first_drop_reason, details, address, all_drops_reason;
 	struct qed_ptt *p_ptt = p_hwfn->p_dpc_ptt;
 
+	int_sts = qed_rd(p_hwfn, p_ptt, DORQ_REG_INT_STS);
+	if (int_sts == 0xdeadbeaf) {
+		DP_NOTICE(p_hwfn->cdev,
+			  "DORQ is being reset, skipping int_sts handler\n");
+
+		return 0;
+	}
+
 	/* int_sts may be zero since all PFs were interrupted for doorbell
 	 * overflow but another one already handled it. Can abort here. If
 	 * This PF also requires overflow recovery we will be interrupted again.
 	 * The masked almost full indication may also be set. Ignoring.
 	 */
-	int_sts = qed_rd(p_hwfn, p_ptt, DORQ_REG_INT_STS);
 	if (!(int_sts & ~DORQ_REG_INT_STS_DORQ_FIFO_AFULL))
 		return 0;
 
@@ -528,6 +535,9 @@ static int qed_dorq_attn_int_sts(struct qed_hwfn *p_hwfn)
 
 static int qed_dorq_attn_cb(struct qed_hwfn *p_hwfn)
 {
+	if (p_hwfn->cdev->recov_in_prog)
+		return 0;
+
 	p_hwfn->db_recovery_info.dorq_attn = true;
 	qed_dorq_attn_overflow(p_hwfn);
 
Signature · 1 line
2.22.0
#1 lore raw
This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 8 lines · On Sun, 1 Aug 2021 13:26:38 +0300 you wrote:

The device recovery flow will reset the entire HW device, in that case the DORQ HW block attention is redundant.

---
 drivers/net/ethernet/qlogic/qed/qed_int.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Here is the summary with links:
- qed: Skip DORQ attention handling during recovery

    https://git.kernel.org/netdev/net-next/c/cdc1d8686658

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html