VSOCK: handle VIRTIO_VSOCK_OP_CREDIT_REQUEST
Subsystems (6)
PATCH 1/1 VSOCK: handle VIRTIO_VSOCK_OP_CREDIT_REQUEST
The original implementation of the virtio-vsock driver does not handle a VIRTIO_VSOCK_OP_CREDIT_REQUEST as required by the virtio-vsock specification. The vsock device emulated by vhost-vsock and the virtio-vsock driver never uses this request, which was probably why nobody noticed it. However, another implementation of the device may use this request type.
Hence, this commit introduces a way to handle an explicit credit request by responding with a corresponding credit update as required by the virtio-vsock specification.
--- net/vmw_vsock/virtio_transport_common.c | 3 +++ 1 file changed, 3 insertions(+)
net/vmw_vsock/virtio_transport_common.c +3 -0
@@ -1079,6 +1079,9 @@ virtio_transport_recv_connected(struct sock *sk,virtio_transport_recv_enqueue (vsk, pkt); sk->sk_data_ready (sk);return err; +case VIRTIO_VSOCK_OP_CREDIT_REQUEST : +virtio_transport_send_credit_update (vsk); +break ;case VIRTIO_VSOCK_OP_CREDIT_UPDATE : sk->sk_write_space (sk);break ;
Signature · 1 line
2.17.1
Quoted 24 lines · Harshavardhan Unnibhavi
The original implementation of the virtio-vsock driver does not handle a
VIRTIO_VSOCK_OP_CREDIT_REQUESTas required by the virtio-vsock specification. The vsock device emulated by vhost-vsock and the virtio-vsock driver never uses this request, which was probably why nobody noticed it. However, another implementation of the device may use this request type.Hence, this commit introduces a way to handle an explicit credit request by responding with a corresponding credit update as required by the virtio-vsock specification.
Fixes 06a8fc78367d ("VSOCK: Introduce virtio_vsock_common.ko")Signed-off-by Harshavardhan Unnibhavi <[email protected]>---
net/vmw_vsock/virtio_transport_common.c| 3 +++1 file changed, 3 insertions(+)net/vmw_vsock/virtio_transport_common.c +0
-0
net/vmw_vsock/virtio_transport_common.c virtio_transport_recv_connected(struct sock *sk,
Quoted 10 lines
net/vmw_vsock/virtio_transport_common.c +3
-1@@ -1079,6 +1079,9 @@ virtio_transport_recv_connected(struct sock *sk,virtio_transport_recv_enqueue (vsk, pkt); sk->sk_data_ready (sk);return err; +case VIRTIO_VSOCK_OP_CREDIT_REQUEST : +virtio_transport_send_credit_update (vsk); +break ;case VIRTIO_VSOCK_OP_CREDIT_UPDATE : sk->sk_write_space (sk);break ; -- 2.17.1
The patch LGTM, thanks for fixing this long-time issue!
Quoted 7 lines · Harshavardhan Unnibhavi
The original implementation of the virtio-vsock driver does not handle a
VIRTIO_VSOCK_OP_CREDIT_REQUESTas required by the virtio-vsock specification. The vsock device emulated by vhost-vsock and the virtio-vsock driver never uses this request, which was probably why nobody noticed it. However, another implementation of the device may use this request type.
Quoted 7 lines
Hence, this commit introduces a way to handle an explicit credit request by responding with a corresponding credit update as required by the virtio-vsock specification.
Fixes 06a8fc78367d ("VSOCK: Introduce virtio_vsock_common.ko")Signed-off-by Harshavardhan Unnibhavi <[email protected]>
Quoted 20 lines
--- net/vmw_vsock/virtio_transport_common.c | 3 +++ 1 file changed, 3 insertions(+)net/vmw_vsock/virtio_transport_common.c +3
-0@@ -1079,6 +1079,9 @@ virtio_transport_recv_connected(struct sock *sk,virtio_transport_recv_enqueue (vsk, pkt); sk->sk_data_ready (sk);return err; +case VIRTIO_VSOCK_OP_CREDIT_REQUEST : +virtio_transport_send_credit_update (vsk); +break ;case VIRTIO_VSOCK_OP_CREDIT_UPDATE : sk->sk_write_space (sk);break ;Signature · 1 line
2.17.1
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 8 lines · On Mon, 2 Aug 2021 19:35:06 +0200 you wrote:
The original implementation of the virtio-vsock driver does not handle a
VIRTIO_VSOCK_OP_CREDIT_REQUESTas required by the virtio-vsock specification. The vsock device emulated by vhost-vsock and the virtio-vsock driver never uses this request, which was probably why nobody noticed it. However, another implementation of the device may use this request type.[...]
Here is the summary with links:
- [net] VSOCK: handle VIRTIO_VSOCK_OP_CREDIT_REQUEST
https://git.kernel.org/netdev/net/c/e3ea110d6e79
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html