Skip to contentSkip to conversation

Add DT files for sc7280 IDP2 board

PATCH In review Rajendra Nayak 3 participants 6 messages Aug 4, 2021 – Aug 5, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v2 cover Add DT files for sc7280 IDP2 board

v2:
* Added the google,piglin compatible for the IDP2 board
* Rebased on the recent pmic cleanups [1]
* Moved pmr735a_die_temp into idp dts

The IDP2 board based off sc7280 SoC is derived from the existing IDP platform, but has some differences like
* on board Embedded controller and H1 secure microprocessor
* PMIC changes (some pmic functionality handled by EC)
* MDP/Display power grid changes
* USB configuration changes

To handle the differences, all common functionality is now moved to sc7280-idp.dtsi, which is included in both sc7280-idp and sc7280-idp2 dts files.

Additional functionality differences in IDP2 as listed above will be added by subsequent patches, this series just makes sure we have the split done to handle the commonalities and differences.

[1] https://lore.kernel.org/patchwork/patch/1471665/

Rajendra Nayak (2):
dt-bindings: arm: qcom: Document qcom,sc7280-idp2 board
arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2

 Documentation/devicetree/bindings/arm/qcom.yaml    |   2 +
 arch/arm64/boot/dts/qcom/Makefile                  |   1 +
 arch/arm64/boot/dts/qcom/sc7280-idp.dts            | 328 +--------------------
 .../dts/qcom/{sc7280-idp.dts => sc7280-idp.dtsi}   |  55 +---
 arch/arm64/boot/dts/qcom/sc7280-idp2.dts           |  23 ++
 5 files changed, 29 insertions(+), 380 deletions(-)
 copy arch/arm64/boot/dts/qcom/{sc7280-idp.dts => sc7280-idp.dtsi} (84%)
 create mode 100644 arch/arm64/boot/dts/qcom/sc7280-idp2.dts
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw

PATCH v2 1/2 dt-bindings: arm: qcom: Document qcom,sc7280-idp2 board

Document the qcom,sc7280-idp2 board based off sc7280 SoC, The board is also known as piglin in the Chrome OS builds, so document the google,piglin compatible as well.

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +2 -0
index 7163e5f..8c07690 100644
@@ -187,6 +187,8 @@ properties:
       - items:
           - enum:
               - qcom,sc7280-idp
+              - qcom,sc7280-idp2
+              - google,piglin
               - google,senor
           - const: qcom,sc7280
 
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Document qcom,sc7280-idp2 board

Quoting Rajendra Nayak (2021-08-04 06:03:18)

Quoted 6 lines

Document the qcom,sc7280-idp2 board based off sc7280 SoC, The board is also known as piglin in the Chrome OS builds, so document the google,piglin compatible as well.

---

#3 lore raw

PATCH v2 2/2 arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2

In reply to Rajendra Nayak

Move all the common device tree bits for both sc7280 IDPs into a sc7280-idp.dtsi and create 2 different dts files (sc7280-idp.dts and sc7280-idp2.dts) in order to manage differences across the IDP SKU1 and SKU2 Boards.
PMR735A is present on IDP board only and is not present on IDP2.

---
 arch/arm64/boot/dts/qcom/Makefile                  |   1 +
 arch/arm64/boot/dts/qcom/sc7280-idp.dts            | 328 +--------------------
 .../dts/qcom/{sc7280-idp.dts => sc7280-idp.dtsi}   |  55 +---
 arch/arm64/boot/dts/qcom/sc7280-idp2.dts           |  23 ++
 4 files changed, 27 insertions(+), 380 deletions(-)
 copy arch/arm64/boot/dts/qcom/{sc7280-idp.dts => sc7280-idp.dtsi} (84%)
 create mode 100644 arch/arm64/boot/dts/qcom/sc7280-idp2.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
index a571bfdd..50cf2cf 100644
@@ -61,6 +61,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sc7180-trogdor-pompom-r3-lte.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc7180-trogdor-r1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc7180-trogdor-r1-lte.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc7280-idp.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sc7280-idp2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm630-sony-xperia-ganges-kirin.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm630-sony-xperia-nile-discovery.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm630-sony-xperia-nile-pioneer.dtb
arch/arm64/boot/dts/qcom/sc7280-idp.dts +2 -326

353 lines not on this page · raw message

arch/arm64/boot/dts/qcom/sc7280-idp.dtsi renamed from arch/arm64/boot/dts/qcom/sc7280-idp.dts +1 -54

83 lines not on this page · raw message

arch/arm64/boot/dts/qcom/sc7280-idp2.dts new file +23 -0
new file mode 100644
index 0000000..1fc2add
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * sc7280 IDP2 board device tree source
+ *
+ * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "sc7280-idp.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. sc7280 IDP SKU2 platform";
+	compatible = "qcom,sc7280-idp2", "google,piglin", "qcom,sc7280";
+
+	aliases {
+		serial0 = &uart5;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v2 2/2
#4 lore raw

Re: [PATCH v2 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2

Quoted 10 lines · Rajendra Nayak

Move all the common device tree bits for both sc7280 IDPs into a sc7280-idp.dtsi and create 2 different dts files (sc7280-idp.dts and sc7280-idp2.dts) in order to manage differences across the IDP SKU1 and SKU2 Boards.
PMR735A is present on IDP board only and is not present on IDP2.

---
 arch/arm64/boot/dts/qcom/Makefile                  |   1 +
 arch/arm64/boot/dts/qcom/sc7280-idp.dts            | 328 +--------------------

I'm still for calling this sc7280-idp-sku1/2.dts, but other than that it looks good.

#5 lore raw

Re: [PATCH v2 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2

Quoted 8 lines · Konrad Dybcio
Quoted 6 lines · Rajendra Nayak

Move all the common device tree bits for both sc7280 IDPs into a sc7280-idp.dtsi and create 2 different dts files (sc7280-idp.dts and sc7280-idp2.dts) in order to manage differences across the IDP SKU1 and SKU2 Boards.
PMR735A is present on IDP board only and is not present on IDP2.

Quoted 6 lines
Quoted 4 lines
---
  arch/arm64/boot/dts/qcom/Makefile                  |   1 +
  arch/arm64/boot/dts/qcom/sc7280-idp.dts            | 328 +--------------------

I'm still for calling this sc7280-idp-sku1/2.dts, but other than that it looks good.

sure, I'll just wait for others to chime in, and if that's the consensus I would be happy to re-spin.

Quoted 1 line

Thanks.

Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation