Skip to contentSkip to conversation

fix eeprom entries for ls1046afrwy and ls1046ardb

PATCH Applied Raag Jadav 4 participants 6 messages Aug 4, 2021 – Aug 9, 2021

Subsystems (4)
lore
Share & tools
lore

Raag Jadav

author
#0 lore raw

v2 cover fix eeprom entries for ls1046afrwy and ls1046ardb

This series fixes eeprom entries for ls1046afrwy and ls1046ardb boards.

Changes since v1:
- Update patch description.
- Add bindings for ON Semi CAT24C04 and CAT24C05 eeproms.

Raag Jadav (2):
arm64: dts: ls1046a: fix eeprom entries
dt-bindings: at24: add ON Semi CAT24C04 and CAT24C05

 Documentation/devicetree/bindings/eeprom/at24.yaml | 6 ++++++
 arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts | 8 +-------
 arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts  | 7 +------
 3 files changed, 8 insertions(+), 13 deletions(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v2 1/2 arm64: dts: ls1046a: fix eeprom entries

ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2] eeproms respectively. Both are 4Kb (512 bytes) in size,
and compatible with AT24C04[3].
Remove multi-address entries, as both the boards have a single chip each.

[1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf
[2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf
[3] https://ww1.microchip.com/downloads/en/DeviceDoc/doc0180.pdf

---
 arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts | 8 +-------
 arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts  | 7 +------
 2 files changed, 2 insertions(+), 13 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts +1 -7
index db3d303..6d22efb 100644
@@ -83,15 +83,9 @@
 			};
 
 			eeprom@52 {
-				compatible = "atmel,24c512";
+				compatible = "onnn,cat24c04", "atmel,24c04";
 				reg = <0x52>;
 			};
-
-			eeprom@53 {
-				compatible = "atmel,24c512";
-				reg = <0x53>;
-			};
-
 		};
 	};
 };
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts +1 -6
index 60acdf0..7025aad 100644
@@ -59,14 +59,9 @@
 	};
 
 	eeprom@52 {
-		compatible = "atmel,24c512";
+		compatible = "onnn,cat24c05", "atmel,24c04";
 		reg = <0x52>;
 	};
-
-	eeprom@53 {
-		compatible = "atmel,24c512";
-		reg = <0x53>;
-	};
 };
 
 &i2c3 {
Signature · 1 line
2.7.4
Acked-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] arm64: dts: ls1046a: fix eeprom entries

Quoted 11 lines · Raag Jadav

ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2] eeproms respectively. Both are 4Kb (512 bytes) in size,
and compatible with AT24C04[3].
Remove multi-address entries, as both the boards have a single chip each.

[1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf
[2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf
[3] https://ww1.microchip.com/downloads/en/DeviceDoc/doc0180.pdf

Quoted 49 lines
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts | 8 +-------
 arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts  | 7 +------
 2 files changed, 2 insertions(+), 13 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts +1 -7
index db3d303..6d22efb 100644
@@ -83,15 +83,9 @@
                        };
 
                        eeprom@52 {
-                               compatible = "atmel,24c512";
+                               compatible = "onnn,cat24c04", "atmel,24c04";
                                reg = <0x52>;
                        };
-
-                       eeprom@53 {
-                               compatible = "atmel,24c512";
-                               reg = <0x53>;
-                       };
-
                };
        };
 };
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts +1 -7
index 60acdf0..7025aad 100644
@@ -59,14 +59,9 @@
        };
 
        eeprom@52 {
-               compatible = "atmel,24c512";
+               compatible = "onnn,cat24c05", "atmel,24c04";
                reg = <0x52>;
        };
-
-       eeprom@53 {
-               compatible = "atmel,24c512";
-               reg = <0x53>;
-       };
 };
 
 &i2c3 {
--

2.7.4

Applied
#3 lore raw

Re: [PATCH v2 1/2] arm64: dts: ls1046a: fix eeprom entries

In reply to Raag Jadav
Quoted 10 lines · Raag Jadav

ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2] eeproms respectively. Both are 4Kb (512 bytes) in size,
and compatible with AT24C04[3].
Remove multi-address entries, as both the boards have a single chip each.

[1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf
[2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf
[3] https://ww1.microchip.com/downloads/en/DeviceDoc/doc0180.pdf

Applied, thanks!

author
#4 lore raw

PATCH v2 2/2 dt-bindings: at24: add ON Semi CAT24C04 and CAT24C05

In reply to Raag Jadav

Add bindings for ON Semi CAT24C04 and CAT24C05 eeproms, which are compatible with Atmel AT24C04.

---
 Documentation/devicetree/bindings/eeprom/at24.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/eeprom/at24.yaml +6 -0
index 914a423..4c5396a 100644
@@ -98,6 +98,12 @@ properties:
           - const: nxp,se97b
           - const: atmel,24c02
       - items:
+          - const: onnn,cat24c04
+          - const: atmel,24c04
+      - items:
+          - const: onnn,cat24c05
+          - const: atmel,24c04
+      - items:
           - const: renesas,r1ex24002
           - const: atmel,24c02
       - items:
Signature · 1 line
2.7.4
#5 lore raw

Re: [PATCH v2 2/2] dt-bindings: at24: add ON Semi CAT24C04 and CAT24C05

Quoted 27 lines · Raag Jadav

Add bindings for ON Semi CAT24C04 and CAT24C05 eeproms, which are compatible with Atmel AT24C04.

---
 Documentation/devicetree/bindings/eeprom/at24.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/eeprom/at24.yaml +6 -1
index 914a423..4c5396a 100644
@@ -98,6 +98,12 @@ properties:
           - const: nxp,se97b
           - const: atmel,24c02
       - items:
+          - const: onnn,cat24c04
+          - const: atmel,24c04
+      - items:
+          - const: onnn,cat24c05
+          - const: atmel,24c04
+      - items:
           - const: renesas,r1ex24002
           - const: atmel,24c02
       - items:
--
Quoted 2 lines

2.7.4

Applied, thanks!

Bartosz