Skip to contentSkip to conversation

selftests/bpf: Fix bpf-iter-tcp4 test to print correctly the dest IP

PATCH Applied Jose Blanquicet 3 participants 3 messages Aug 5, 2021 – Aug 6, 2021

Subsystems (5)
Networking Network drivers Kselftest BPF +1 more subsystems
lore
Share & tools
lore

Jose Blanquicet

author
#0 lore raw

PATCH 1/1 selftests/bpf: Fix bpf-iter-tcp4 test to print correctly the dest IP

Currently, this test is incorrectly printing the destination port in place of the destination IP.

Signed-off-by Jose Blanquicet <[email protected]>
---
 tools/testing/selftests/bpf/progs/bpf_iter_tcp4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/progs/bpf_iter_tcp4.c +1 -1
index 2e4775c35414..92267abb462f 100644
@@ -121,7 +121,7 @@ static int dump_tcp_sock(struct seq_file *seq, struct tcp_sock *tp,
 	}
 
 	BPF_SEQ_PRINTF(seq, "%4d: %08X:%04X %08X:%04X ",
-		       seq_num, src, srcp, destp, destp);
+		       seq_num, src, srcp, dest, destp);
 	BPF_SEQ_PRINTF(seq, "%02X %08X:%08X %02X:%08lX %08X %5u %8d %lu %d ",
 		       state,
 		       tp->write_seq - tp->snd_una, rx_queue,
Signature · 1 line
2.25.1
CI Applied
#2 lore raw
In reply to Jose Blanquicet
This patch was applied to bpf/bpf-next.git (refs/heads/master):

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

Quoted 7 lines · On Thu, 5 Aug 2021 18:40:36 +0200 you wrote:

Currently, this test is incorrectly printing the destination port in place of the destination IP.

Signed-off-by Jose Blanquicet <[email protected]>
---
 tools/testing/selftests/bpf/progs/bpf_iter_tcp4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- selftests/bpf: Fix bpf-iter-tcp4 test to print correctly the dest IP

    https://git.kernel.org/bpf/bpf-next/c/277b13405703

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html