arm64: dts: qcom: sc7280: Add clock controller ID headers
Subsystems (4)
PATCH 1/1 arm64: dts: qcom: sc7280: Add clock controller ID headers
Add the GPUCC, DISPCC and VIDEOCC clock headers which were dropped earlier.
--- arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/qcom/sc7280.dtsi +3 -0
@@ -5,8 +5,11 @@ * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved. */ +#include <dt-bindings/clock/qcom,dispcc-sc7280.h> #include <dt-bindings/clock/qcom,gcc-sc7280.h> +#include <dt-bindings/clock/qcom,gpucc-sc7280.h> #include <dt-bindings/clock/qcom,rpmh.h> +#include <dt-bindings/clock/qcom,videocc-sc7280.h> #include <dt-bindings/interconnect/qcom,sc7280.h> #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/mailbox/qcom-ipcc.h>
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.
Hi,
Quoted 5 lines · Taniya Das
Add the GPUCC, DISPCC and VIDEOCC clock headers which were dropped earlier.
Fixes 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")
IMO drop the "Fixes". To me having the "Fixes" there means that there was a bug in the old patch. This isn't really fixing a bug.
Quoted 4 lines
Signed-off-by Taniya Das <[email protected]>--- arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ 1 file changed, 3 insertions(+)
Other than removing the "Fixes" then this seems like it would be nice to land soon after the next -rc1 comes out so that patches that start referring to the clocks in these controllers can take advantage of them. Snooze 3 weeks till (presumably) -rc1 might come out.
Hi,
Quoted 18 lines · Doug Anderson
Hi,
Quoted 5 lines · Taniya Das
Add the GPUCC, DISPCC and VIDEOCC clock headers which were dropped earlier.
Fixes 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")IMO drop the "Fixes". To me having the "Fixes" there means that there was a bug in the old patch. This isn't really fixing a bug.
Quoted 4 lines
Signed-off-by Taniya Das <[email protected]>--- arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ 1 file changed, 3 insertions(+)
Quoted 6 lines
Other than removing the "Fixes" then this seems like it would be nice to land soon after the next -rc1 comes out so that patches that start referring to the clocks in these controllers can take advantage of them. Snooze 3 weeks till (presumably) -rc1 might come out.
Reviewed-by Douglas Anderson <[email protected]>
Bjorn: if you agree and are willing to drop the "Fixes" line yourself when applying then I think this is ready to land since it's now "soon after the next -rc1". ;-)
-Doug