wwan: core: Unshadow error code returned by ida_alloc_range()
Subsystems (3)
PATCH v4 1/1 wwan: core: Unshadow error code returned by ida_alloc_range()
ida_alloc_range() may return other than -ENOMEM error code. Unshadow it in the wwan_create_port().
Signed-off-by Andy Shevchenko <[email protected]>
Reviewed-by Sergey Ryazanov <[email protected]>
Reviewed-by Loic Poulain <[email protected]>
---
v4: actually fixed typo in the subject (Sergey)
drivers/net/wwan/wwan_core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/wwan/wwan_core.c +5 -2
@@ -359,8 +359,8 @@ struct wwan_port *wwan_create_port(struct device *parent, {struct wwan_device *wwandev;struct wwan_port *port; -int minor, err = -ENOMEM ;char namefmt[0x20 ]; +int minor, err;if (type >WWAN_PORT_MAX || !ops)return ERR_PTR (-EINVAL );
@@ -374,11 +374,14 @@ struct wwan_port *wwan_create_port(struct device *parent,/* A port is exposed as character device, get a minor */ minor =ida_alloc_range (&minors,0 ,WWAN_MAX_MINORS -1 ,GFP_KERNEL ); -if (minor <0 ) +if (minor <0 ) { + err = minor; goto error_wwandev_remove; + } port =kzalloc (sizeof (*port),GFP_KERNEL );if (!port) { + err = -ENOMEM ;ida_free (&minors, minor); goto error_wwandev_remove; }
Signature · 1 line
2.30.2
This patch was applied to netdev/net-next.git (refs/heads/master):
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
Quoted 8 lines · On Wed, 11 Aug 2021 16:39:32 +0300 you wrote:
ida_alloc_range()may return other than-ENOMEMerror code. Unshadow it in thewwan_create_port().Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Sergey Ryazanov <[email protected]>Reviewed-by Loic Poulain <[email protected]>[...]
Here is the summary with links:
- [v4,net-next,1/1] wwan: core: Unshadow error code returned by ida_alloc_range()
https://git.kernel.org/netdev/net-next/c/0de6fd5fd51c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html