Skip to contentSkip to conversation

Kconfig symbol clean-up on net

PATCH Applied Lukas Bulwahn 4 participants 7 messages Aug 12, 2021 – Aug 13, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Kconfig symbol clean-up on net

Dear David, dear Jakub,

The script ./scripts/checkkconfigsymbols.py warns on invalid references to Kconfig symbols (often, minor typos, name confusions or outdated references).

This patch series addresses all issues reported by ./scripts/checkkconfigsymbols.py in ./net/ and ./drivers/net/ for Kconfig and Makefile files. Issues in the Kconfig and Makefile files indicate some shortcomings in the overall build definitions, and often are true actionable issues to address.

These issues can be identified and filtered by:

  ./scripts/checkkconfigsymbols.py \
  | grep -E "(drivers/)?net/.*(Kconfig|Makefile)" -B 1 -A 1

After applying this patch series on linux-next (next-20210811), the command above yields no further issues to address.

Please pick this patch series into your net-next tree.

Best regards,

Lukas

Lukas Bulwahn (3):
net: Kconfig: remove obsolete reference to config MICROBLAZE_64K_PAGES
net: 802: remove dead leftover after ipx driver removal
net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH

 drivers/net/Kconfig                         |  4 +-
 drivers/net/ethernet/freescale/dpaa/Kconfig |  1 -
 net/802/Makefile                            |  1 -
 net/802/p8023.c                             | 60 ---------------------
 4 files changed, 2 insertions(+), 64 deletions(-)
 delete mode 100644 net/802/p8023.c
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/3 net: Kconfig: remove obsolete reference to config MICROBLAZE_64K_PAGES

Commit 05cdf457477d ("microblaze: Remove noMMU code") removes config MICROBLAZE_64K_PAGES in arch/microblaze/Kconfig. However, there is still a reference to MICROBLAZE_64K_PAGES in the config VMXNET3 in ./drivers/net/Kconfig.

Remove this obsolete reference to config MICROBLAZE_64K_PAGES.

---
 drivers/net/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/Kconfig +2 -2
index 995c613086aa..f37b1c56f7c4 100644
@@ -551,8 +551,8 @@ config VMXNET3
 	tristate "VMware VMXNET3 ethernet driver"
 	depends on PCI && INET
 	depends on !(PAGE_SIZE_64KB || ARM64_64K_PAGES || \
-		     IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \
-		     PARISC_PAGE_SIZE_64KB || PPC_64K_PAGES)
+		     IA64_PAGE_SIZE_64KB || PARISC_PAGE_SIZE_64KB || \
+		     PPC_64K_PAGES)
 	help
 	  This driver supports VMware's vmxnet3 virtual ethernet NIC.
 	  To compile this driver as a module, choose M here: the
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/3 net: 802: remove dead leftover after ipx driver removal

In reply to Lukas Bulwahn

Commit 7a2e838d28cf ("staging: ipx: delete it from the tree") removes the ipx driver and the config IPX. Since then, there is some dead leftover in ./net/802/, that was once used by the IPX driver, but has no other user.

Remove this dead leftover.

---
 net/802/Makefile |  1 -
 net/802/p8023.c  | 60 ------------------------------------------------
 2 files changed, 61 deletions(-)
 delete mode 100644 net/802/p8023.c
net/802/Makefile +0 -1
index 19406a87bdaa..bfed80221b8b 100644
@@ -8,7 +8,6 @@ obj-$(CONFIG_LLC)	+= p8022.o psnap.o
 obj-$(CONFIG_NET_FC)	+=                 fc.o
 obj-$(CONFIG_FDDI)	+=                 fddi.o
 obj-$(CONFIG_HIPPI)	+=                 hippi.o
-obj-$(CONFIG_IPX)	+= p8022.o psnap.o p8023.o
 obj-$(CONFIG_ATALK)	+= p8022.o psnap.o
 obj-$(CONFIG_STP)	+= stp.o
 obj-$(CONFIG_GARP)	+= garp.o
net/802/p8023.c deleted +0 -60

60 lines not on this page · raw message

Signature · 1 line
2.17.1
#3 lore raw

PATCH 3/3 net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH

In reply to Lukas Bulwahn

The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config FSL_FMAN_MAC never existed in the kernel tree.

Hence, ./scripts/checkkconfigsymbols.py warns:

FSL_FMAN_MAC
Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig

Remove this dead select in menuconfig FSL_DPAA_ETH.

Fixes 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
---
 drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/net/ethernet/freescale/dpaa/Kconfig +0 -1
index 626ec58a0afc..0e1439fd00bd 100644
@@ -4,7 +4,6 @@ menuconfig FSL_DPAA_ETH
 	depends on FSL_DPAA && FSL_FMAN
 	select PHYLIB
 	select FIXED_PHY
-	select FSL_FMAN_MAC
 	help
 	  Data Path Acceleration Architecture Ethernet driver,
 	  supporting the Freescale QorIQ chips.
Signature · 1 line
2.17.1
Acked-by on v1 3/3
#4 lore raw

RE: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH

Quoted 41 lines

-----Original Message-----
From: Lukas Bulwahn <[email protected]>
Sent: 12 August 2021 11:38
To: David S . Miller <[email protected]>; Jakub Kicinski <[email protected]>; [email protected]
Cc: Madalin Bucur <[email protected]>; Randy Dunlap <[email protected]>; [email protected]; linux- [email protected]; Lukas Bulwahn <[email protected]>
Subject: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH

The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config FSL_FMAN_MAC never existed in the kernel tree.

Hence, ./scripts/checkkconfigsymbols.py warns:

FSL_FMAN_MAC
Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig

Remove this dead select in menuconfig FSL_DPAA_ETH.

Fixes 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
---
 drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/net/ethernet/freescale/dpaa/Kconfig +0 -2
index 626ec58a0afc..0e1439fd00bd 100644
@@ -4,7 +4,6 @@ menuconfig FSL_DPAA_ETH
 	depends on FSL_DPAA && FSL_FMAN
 	select PHYLIB
 	select FIXED_PHY
-	select FSL_FMAN_MAC
 	help
 	  Data Path Acceleration Architecture Ethernet driver,
 	  supporting the Freescale QorIQ chips.
--
Quoted 1 line

2.17.1

maintainer
#5 lore raw
In reply to Lukas Bulwahn
Quoted 9 lines · On Thu, 12 Aug 2021 10:38:03 +0200 Lukas Bulwahn wrote:

The script ./scripts/checkkconfigsymbols.py warns on invalid references to Kconfig symbols (often, minor typos, name confusions or outdated references).

This patch series addresses all issues reported by ./scripts/checkkconfigsymbols.py in ./net/ and ./drivers/net/ for Kconfig and Makefile files. Issues in the Kconfig and Makefile files indicate some shortcomings in the overall build definitions, and often are true actionable issues to address.

Quoted 7 lines

These issues can be identified and filtered by:

  ./scripts/checkkconfigsymbols.py \
  | grep -E "(drivers/)?net/.*(Kconfig|Makefile)" -B 1 -A 1

After applying this patch series on linux-next (next-20210811), the command above yields no further issues to address.

FWIW there's also:

arch/arm/configs/ixp4xx_defconfig:79:CONFIG_IPX=m

#6 lore raw
In reply to Lukas Bulwahn
This series was applied to netdev/net-next.git (refs/heads/master):

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

Quoted 5 lines · On Thu, 12 Aug 2021 10:38:03 +0200 you wrote:

Dear David, dear Jakub,

The script ./scripts/checkkconfigsymbols.py warns on invalid references to Kconfig symbols (often, minor typos, name confusions or outdated references).

Quoted 7 lines

This patch series addresses all issues reported by ./scripts/checkkconfigsymbols.py in ./net/ and ./drivers/net/ for Kconfig and Makefile files. Issues in the Kconfig and Makefile files indicate some shortcomings in the overall build definitions, and often are true actionable issues to address.

[...]

Here is the summary with links:
- [1/3] net: Kconfig: remove obsolete reference to config MICROBLAZE_64K_PAGES

    https://git.kernel.org/netdev/net-next/c/4fb464db9c72
  - [2/3] net: 802: remove dead leftover after ipx driver removal
    https://git.kernel.org/netdev/net-next/c/d8d9ba8dc9c7
  - [3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH
    https://git.kernel.org/netdev/net-next/c/f75d81556a38

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html