Skip to contentSkip to conversation

ptp_pch: Restore dependency on PCI

PATCH Applied Andy Shevchenko 3 participants 3 messages Aug 13, 2021 – Aug 16, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ptp_pch: Restore dependency on PCI

During the swap dependency on PCH_GBE to selection PTP_1588_CLOCK_PCH incidentally dropped the implicit dependency on the PCI. Restore it.

Fixes 18d359ceb044 ("pch_gbe, ptp_pch: Fix the dependency direction between these drivers")
---
 drivers/ptp/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/ptp/Kconfig +2 -1
index 8c20e524e9ad..e085c255da0c 100644
@@ -90,7 +90,8 @@ config PTP_1588_CLOCK_INES
 config PTP_1588_CLOCK_PCH
 	tristate "Intel PCH EG20T as PTP clock"
 	depends on X86_32 || COMPILE_TEST
-	depends on HAS_IOMEM && NET
+	depends on HAS_IOMEM && PCI
+	depends on NET
 	imply PTP_1588_CLOCK
 	help
 	  This driver adds support for using the PCH EG20T as a PTP
Signature · 1 line
2.30.2
maintainer
#1 lore raw
Quoted 4 lines · On Fri, 13 Aug 2021 20:33:27 +0300 Andy Shevchenko wrote:

During the swap dependency on PCH_GBE to selection PTP_1588_CLOCK_PCH incidentally dropped the implicit dependency on the PCI. Restore it.

Fixes 18d359ceb044 ("pch_gbe, ptp_pch: Fix the dependency direction between these drivers")

It was breaking build for 9 years and nobody hit it? What's the build failure?

#2 lore raw
In reply to Andy Shevchenko
This patch was applied to netdev/net.git (refs/heads/master):

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

Quoted 8 lines · On Fri, 13 Aug 2021 20:33:27 +0300 you wrote:

During the swap dependency on PCH_GBE to selection PTP_1588_CLOCK_PCH incidentally dropped the implicit dependency on the PCI. Restore it.

Fixes 18d359ceb044 ("pch_gbe, ptp_pch: Fix the dependency direction between these drivers")

[...]

Here is the summary with links:
- [v1,net,1/1] ptp_pch: Restore dependency on PCI

    https://git.kernel.org/netdev/net/c/55c8fca1dae1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html