checkpatch: Do not warn __initconst for const char *.
PATCH 1/1 checkpatch: Do not warn __initconst for const char *.
checkpatch.pl warns if an '__initdata' variable has 'const' attribute to use __initconst, but it doesn't check that attribute affects the type of a pointer or the variable. Thus it reports an false error if 'const char *' variable is '__initdata'. e.g.
ERROR: Use of const init definition must use __initconst #32: FILE: lib/bootconfig.c:32:
+static const char *xbc_err_msg __initdata;
To fix this issue, this ensures that the 'const' does not follows any type string and a pointer ('*') too.
Signed-off-by Masami Hiramatsu <[email protected]>
--- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/checkpatch.pl +1 -1
@@ -6330,7 +6330,7 @@ sub process { } # check for $InitAttributeData (ie: __initdata) with const - if ($line =~ /\bconst\b/ && $line =~ /($InitAttributeData)/) { + if ($line =~ /\bconst\b/ && $line !~ /\bconst\b[^\*\(]+\*/ && $line =~ /($InitAttributeData)/) { my $attr = $1; $attr =~ /($InitAttributePrefix)(.*)/; my $attr_prefix = $1;