ptp: ocp: Simplify Kconfig.
Subsystems (3)
PATCH 1/1 ptp: ocp: Simplify Kconfig.
Remove the 'imply' statements, these apparently are not doing what I expected. Platform modules which are used by the driver still need to be enabled in the overall config for them to be used, but there isn't a hard dependency on them.
Use 'depend' for selectable modules which provide functions used directly by the driver.
--- drivers/ptp/Kconfig | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/ptp/Kconfig +2 -8
@@ -171,16 +171,10 @@ config PTP_1588_CLOCK_OCP tristate "OpenCompute TimeCard as PTP clock" depends on PTP_1588_CLOCK depends on HAS_IOMEM && PCI - depends on SPI && I2C && MTD + depends on I2C && MTD + depends on SERIAL_8250 depends on !S390 - imply SPI_MEM - imply SPI_XILINX - imply MTD_SPI_NOR - imply I2C_XILINX - select SERIAL_8250 select NET_DEVLINK - - default n help This driver adds support for an OpenCompute time card.
Signature · 1 line
2.31.1
Quoted 6 lines · Jonathan Lemon
Remove the 'imply' statements, these apparently are not doing what I expected. Platform modules which are used by the driver still need to be enabled in the overall config for them to be used, but there isn't a hard dependency on them.
Quoted 7 lines
Use 'depend' for selectable modules which provide functions used directly by the driver.
Signed-off-by Jonathan Lemon <[email protected]>--- drivers/ptp/Kconfig | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
Quoted 27 lines · Jonathan Lemon
Remove the 'imply' statements, these apparently are not doing what I expected. Platform modules which are used by the driver still need to be enabled in the overall config for them to be used, but there isn't a hard dependency on them.
Use 'depend' for selectable modules which provide functions used directly by the driver.
Signed-off-by Jonathan Lemon <[email protected]>--- drivers/ptp/Kconfig | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)drivers/ptp/Kconfig +2
-2@@ -171,16 +171,10 @@ config PTP_1588_CLOCK_OCP tristate "OpenCompute TimeCard as PTP clock" depends on PTP_1588_CLOCK depends on HAS_IOMEM && PCI - depends on SPI && I2C && MTD + depends on I2C && MTD + depends on SERIAL_8250 depends on !S390 - imply SPI_MEM
drivers/ptp/Kconfig config PTP_1588_CLOCK_OCP · line 180
Quoted 10 lines
drivers/ptp/Kconfig +0
-6- imply SPI_XILINX - imply MTD_SPI_NOR - imply I2C_XILINX - select SERIAL_8250 select NET_DEVLINK - - default n help This driver adds support for an OpenCompute time card.
Thanks.
Signature · 1 line
~Randy
This patch was applied to netdev/net-next.git (refs/heads/master):
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
Quoted 9 lines · On Wed, 25 Aug 2021 14:17:33 -0700 you wrote:
Remove the 'imply' statements, these apparently are not doing what I expected. Platform modules which are used by the driver still need to be enabled in the overall config for them to be used, but there isn't a hard dependency on them.
Use 'depend' for selectable modules which provide functions used directly by the driver.
[...]
Here is the summary with links:
- [net-next] ptp: ocp: Simplify Kconfig.
https://git.kernel.org/netdev/net-next/c/bc8e05d6b965
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html