Skip to contentSkip to conversation

bus: mhi: Update documentation for MHI error callbacks

PATCH New Bhaumik Bhatt 1 participant 1 message Aug 26, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus: mhi: Update documentation for MHI error callbacks

Design changes prompted redefinition of the FATAL and SYSTEM ERROR callbacks such that FATAL ERROR should be treated as a callback arriving from an atomic or interrupt context and taken as an indication that the device has reset to one of the PBL execution environments. Whereas, a SYSTEM ERROR (SYS_ERROR) callback is sleep-capable and allowed to block such that the controller can pursue its clean-up before core driver handles further processing. Updated documentation for the same.

---
 include/linux/mhi.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/mhi.h +2 -2
index b8ca694..a8b2c25 100644
@@ -31,8 +31,8 @@ struct mhi_buf_info;
  * @MHI_CB_LPM_EXIT: MHI host about to exit low power mode
  * @MHI_CB_EE_RDDM: MHI device entered RDDM exec env
  * @MHI_CB_EE_MISSION_MODE: MHI device entered Mission Mode exec env
- * @MHI_CB_SYS_ERROR: MHI device entered error state (may recover)
- * @MHI_CB_FATAL_ERROR: MHI device entered fatal error state
+ * @MHI_CB_SYS_ERROR: MHI device entered error state (uses non-atomic context)
+ * @MHI_CB_FATAL_ERROR: MHI device reset to a PBL exec env (uses atomic context)
  * @MHI_CB_BW_REQ: Received a bandwidth switch request from device
  */
 enum mhi_callback {
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project