Skip to contentSkip to conversation

Introduce SoC sleep stats driver

PATCH Superseded Maulik Shah 3 participants 11 messages Sep 6, 2021 – Oct 5, 2021

Subsystems (4)

v9 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

v9 cover Introduce SoC sleep stats driver

Changes in v9:
- Remove soft dependency on smem module
- Return -EIO to userspace in case of error
- Make struct sleep_stats *stat a const pointer
- Remove the driver from soc_sleep_stats_driver name
- Remove offset address and directly mention the msgram address in dtsi
- Use devm_platform_get_and_ioremap_resource() to ioremap dtsi address
- Update device node name to mention aop_msgram instead rpmh-sleep-stats
- Update dtsi and documentation accordingly but retain the reviews

Changes in v8:
- Addressed bjorn's comments in driver from v7
- Update aoss_qmp device node reg size for sc7280

Changes in v7:
- Fix example in bindings documentation as per #address/size-cells = <1>.
- Add comment in driver from where 'ddr' subsystems name is read.
- Update comment in driver to s/beside/besides and others from v6.
- Rename debugfs_create_entries() from v6.
- Drop use of memcpy_fromio() to find the name.
- Use sizeof(*prv_data) in devm_kzalloc().
- Add change to define readq() if its not yet defined for compile support.
- Add wpss subsystem in the list of subsystems.
- Add module soft dependency on smem module.
- Add new change to add device node for sc7280.

Changes in v6:
- Address stephen's comments from v5 which includes below
- Pad 0 in documentation example to make address 8 digit
- define macro to calculate offset in driver
- Add appended_stats_avail to prv_data instead of using entire stats_config
- make array subsystems[] as const
- Add comment for SSR case
- Use memcpy_fromio() and devm_kcalloc() during probe
- Change file permission mode from 444 to 400

- Address guenter's comments to add depends on QCOM_SMEM

- Add adsp_island and cdsp_island subsystems
- Use strim() to remove whitespace in stat name

Changes in v5:
- Remove underscore from node name in Documentation and DTSI change
- Remove global config from driver change

Changes in v4:
- Address bjorn's comments from v3 on change 2.
- Add bjorn's Reviewed-by on change 3 and 4.

Changes in v3:
- Address stephen's comments from v2 in change 1 and 2.
- Address bjorn's comments from v2 in change 3 and 4.
- Add Rob and bjorn's Reviewed-by on YAML change.

Changes in v2:
- Convert Documentation to YAML.
- Address stephen's comments from v1.
- Use debugfs instead of sysfs.
- Add sc7180 dts changes for sleep stats
- Add defconfig changes to enable driver
- Include subsystem stats from [1] in this single stats driver.
- Address stephen's comments from [1]
- Update cover letter inline to mention [1]

Qualcomm Technologies, Inc. (QTI)'s chipsets support SoC level low power modes. SoCs Always On Processor/Resource Power Manager produces statistics of the SoC sleep modes involving lowering or powering down of the rails and the oscillator clock.

Additionally multiple subsystems present on SoC like modem, spss, adsp, cdsp maintains their low power mode statistics in shared memory (SMEM).

Statistics includes SoC sleep mode type, number of times LPM entered, time of last entry, exit, and accumulated sleep duration in seconds.

This series adds a driver to read the stats and export to debugfs.

[1] https://lore.kernel.org/patchwork/patch/1149381/

Mahesh Sivasubramanian (2):
dt-bindings: Introduce SoC sleep stats bindings
soc: qcom: Add SoC sleep stats driver

Maulik Shah (3):
arm64: dts: qcom: sc7180: Enable SoC sleep stats
arm64: defconfig: Enable SoC sleep stats driver
arm64: dts: qcom: sc7280: Enable SoC sleep stats

 .../bindings/soc/qcom/soc-sleep-stats.yaml         |  48 ++++
 arch/arm64/boot/dts/qcom/sc7180.dtsi               |   7 +-
 arch/arm64/boot/dts/qcom/sc7280.dtsi               |   7 +-
 arch/arm64/configs/defconfig                       |   1 +
 drivers/soc/qcom/Kconfig                           |  10 +
 drivers/soc/qcom/Makefile                          |   1 +
 drivers/soc/qcom/soc_sleep_stats.c                 | 241 +++++++++++++++++++++
 7 files changed, 313 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
 create mode 100644 drivers/soc/qcom/soc_sleep_stats.c
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw

PATCH v9 1/5 dt-bindings: Introduce SoC sleep stats bindings

From: Mahesh Sivasubramanian <[email protected]>

Add device binding documentation for Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver. The driver is used for displaying SoC sleep statistic maintained by Always On Processor or Resource Power Manager.

---
 .../bindings/soc/qcom/soc-sleep-stats.yaml         | 48 ++++++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +48 -0
new file mode 100644
index 0000000..4161156
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
+
+maintainers:
+  - Maulik Shah <[email protected]>
+  - Lina Iyer <[email protected]>
+
+description:
+  Always On Processor/Resource Power Manager maintains statistics of the SoC
+  sleep modes involving powering down of the rails and oscillator clock.
+
+  Statistics includes SoC sleep mode type, number of times low power mode were
+  entered, time of last entry, time of last exit and accumulated sleep duration.
+
+properties:
+  compatible:
+    enum:
+      - qcom,rpmh-sleep-stats
+      - qcom,rpm-sleep-stats
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  # Example of rpmh sleep stats
+  - |
+    aop_msgram@c3f0048 {
+      compatible = "qcom,rpmh-sleep-stats";
+      reg = <0x0c3f0048 0x400>;
+    };
+  # Example of rpm sleep stats
+  - |
+    rpm_msgram@4690000 {
+      compatible = "qcom,rpm-sleep-stats";
+      reg = <0x04690000 0x400>;
+    };
+...
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#2 lore raw

Re: [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings

Quoting Maulik Shah (2021-09-05 22:27:59)

Quoted 34 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +28 -0
new file mode 100644
index 0000000..4161156
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
+
+maintainers:
+  - Maulik Shah <[email protected]>
+  - Lina Iyer <[email protected]>
+
+description:
+  Always On Processor/Resource Power Manager maintains statistics of the SoC
+  sleep modes involving powering down of the rails and oscillator clock.
+
+  Statistics includes SoC sleep mode type, number of times low power mode were
+  entered, time of last entry, time of last exit and accumulated sleep duration.
+
+properties:
+  compatible:
+    enum:
+      - qcom,rpmh-sleep-stats
+      - qcom,rpm-sleep-stats
+
+  reg:
+    maxItems: 1
+

Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml line 38

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +10 -0
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  # Example of rpmh sleep stats
+  - |
+    aop_msgram@c3f0048 {

Node names should be generic and not have any underscores in them. I still think 'memory' is more appropriate here. I doubt anyone will confuse it for DDR.

Quoted 3 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +3 -0
+      compatible = "qcom,rpmh-sleep-stats";
+      reg = <0x0c3f0048 0x400>;
+    };
#3 lore raw

Re: [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings

In reply to Maulik Shah
Quoted 25 lines · Maulik Shah

From: Mahesh Sivasubramanian <[email protected]>

Add device binding documentation for Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver. The driver is used for displaying SoC sleep statistic maintained by Always On Processor or Resource Power Manager.

---
 .../bindings/soc/qcom/soc-sleep-stats.yaml         | 48 ++++++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +1 -0
new file mode 100644
index 0000000..4161156
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml line 11

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +10 -0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
+
+maintainers:
+  - Maulik Shah <[email protected]>
+  - Lina Iyer <[email protected]>

Lina's address is no longer valid.

Quoted 19 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +19 -0
+
+description:
+  Always On Processor/Resource Power Manager maintains statistics of the SoC
+  sleep modes involving powering down of the rails and oscillator clock.
+
+  Statistics includes SoC sleep mode type, number of times low power mode were
+  entered, time of last entry, time of last exit and accumulated sleep duration.
+
+properties:
+  compatible:
+    enum:
+      - qcom,rpmh-sleep-stats
+      - qcom,rpm-sleep-stats
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible

Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml line 40

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +10 -0
+  - reg
+
+additionalProperties: false
+
+examples:
+  # Example of rpmh sleep stats
+  - |
+    aop_msgram@c3f0048 {
+      compatible = "qcom,rpmh-sleep-stats";
+      reg = <0x0c3f0048 0x400>;

As I tested this series I did find it quite odd that the start address of this block is $48 bytes into a page and still the length is an even $400.

Is there any single platform where qcom,rpmh-sleep-stats doesn't start at an offset of $48 from the beginning of its msgram? Could we move this number to the driver?

Regards,
Bjorn

Quoted 12 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +8 -0
+    };
+  # Example of rpm sleep stats
+  - |
+    rpm_msgram@4690000 {
+      compatible = "qcom,rpm-sleep-stats";
+      reg = <0x04690000 0x400>;
+    };
+...
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#4 lore raw

Re: [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings

Hi,

Quoted 31 lines · Bjorn Andersson
Quoted 29 lines · Maulik Shah

From: Mahesh Sivasubramanian <[email protected]>

Add device binding documentation for Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver. The driver is used for displaying SoC sleep statistic maintained by Always On Processor or Resource Power Manager.

---
  .../bindings/soc/qcom/soc-sleep-stats.yaml         | 48 ++++++++++++++++++++++
  1 file changed, 48 insertions(+)

create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml

Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +5 -0
new file mode 100644
index 0000000..4161156
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
Quoted 8 lines

Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml line 11

Quoted 6 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +6 -0
+
+title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
+
+maintainers:
+  - Maulik Shah <[email protected]>
+  - Lina Iyer <[email protected]>

Lina's address is no longer valid.

Removed in v10.

Quoted 35 lines
Quoted 20 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +19 -0
+
+description:
+  Always On Processor/Resource Power Manager maintains statistics of the SoC
+  sleep modes involving powering down of the rails and oscillator clock.
+
+  Statistics includes SoC sleep mode type, number of times low power mode were
+  entered, time of last entry, time of last exit and accumulated sleep duration.
+
+properties:
+  compatible:
+    enum:
+      - qcom,rpmh-sleep-stats
+      - qcom,rpm-sleep-stats
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible

Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml line 40

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +10 -0
+  - reg
+
+additionalProperties: false
+
+examples:
+  # Example of rpmh sleep stats
+  - |
+    aop_msgram@c3f0048 {
+      compatible = "qcom,rpmh-sleep-stats";
+      reg = <0x0c3f0048 0x400>;

As I tested this series I did find it quite odd that the start address of this block is $48 bytes into a page and still the length is an even $400.

Quoted 6 lines

Is there any single platform where qcom,rpmh-sleep-stats doesn't start at an offset of $48 from the beginning of its msgram? Could we move this number to the driver?

Regards,
Bjorn

Sure, i have moved 0x48 into driver in v10.

Thanks,
Maulik

Quoted 13 lines
Quoted 13 lines
Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file +8 -0
+    };
+  # Example of rpm sleep stats
+  - |
+    rpm_msgram@4690000 {
+      compatible = "qcom,rpm-sleep-stats";
+      reg = <0x04690000 0x400>;
+    };
+...
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#5 lore raw

PATCH v9 2/5 soc: qcom: Add SoC sleep stats driver

In reply to Maulik Shah

From: Mahesh Sivasubramanian <[email protected]>

Let's add a driver to read the stats from remote processor and export to debugfs.

The driver creates "qcom_sleep_stats" directory in debugfs and adds files for various low power mode available. Below is sample output with command

cat /sys/kernel/debug/qcom_sleep_stats/ddr
count = 0
Last Entered At = 0
Last Exited At = 0
Accumulated Duration = 0

[mkshah: add subsystem sleep stats, create one file for each stat]
---
 drivers/soc/qcom/Kconfig           |  10 ++
 drivers/soc/qcom/Makefile          |   1 +
 drivers/soc/qcom/soc_sleep_stats.c | 241 +++++++++++++++++++++++++++++++++++++
 3 files changed, 252 insertions(+)
 create mode 100644 drivers/soc/qcom/soc_sleep_stats.c
drivers/soc/qcom/Kconfig +10 -0
index 79b568f..e80b63a 100644
@@ -190,6 +190,16 @@ config QCOM_SOCINFO
 	 Say yes here to support the Qualcomm socinfo driver, providing
 	 information about the SoC to user space.
 
+config QCOM_SOC_SLEEP_STATS
+	tristate "Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver"
+	depends on ARCH_QCOM && DEBUG_FS || COMPILE_TEST
+	depends on QCOM_SMEM
+	help
+	  Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver to read
+	  the shared memory exported by the remote processor related to
+	  various SoC level low power modes statistics and export to debugfs
+	  interface.
+
 config QCOM_WCNSS_CTRL
 	tristate "Qualcomm WCNSS control driver"
 	depends on ARCH_QCOM || COMPILE_TEST
drivers/soc/qcom/Makefile +1 -0
index ad675a6..5f30d74 100644
@@ -20,6 +20,7 @@ obj-$(CONFIG_QCOM_SMEM_STATE) += smem_state.o
 obj-$(CONFIG_QCOM_SMP2P)	+= smp2p.o
 obj-$(CONFIG_QCOM_SMSM)	+= smsm.o
 obj-$(CONFIG_QCOM_SOCINFO)	+= socinfo.o
+obj-$(CONFIG_QCOM_SOC_SLEEP_STATS)	+= soc_sleep_stats.o
 obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o
 obj-$(CONFIG_QCOM_APR) += apr.o
 obj-$(CONFIG_QCOM_LLCC) += llcc-qcom.o
drivers/soc/qcom/soc_sleep_stats.c new file +241 -0

241 lines not on this page · raw message

Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#6 lore raw

Re: [PATCH v9 2/5] soc: qcom: Add SoC sleep stats driver

Quoted 52 lines · Maulik Shah

From: Mahesh Sivasubramanian <[email protected]>

Let's add a driver to read the stats from remote processor and export to debugfs.

The driver creates "qcom_sleep_stats" directory in debugfs and adds files for various low power mode available. Below is sample output with command

cat /sys/kernel/debug/qcom_sleep_stats/ddr
count = 0
Last Entered At = 0
Last Exited At = 0
Accumulated Duration = 0

[mkshah: add subsystem sleep stats, create one file for each stat]
---
 drivers/soc/qcom/Kconfig           |  10 ++
 drivers/soc/qcom/Makefile          |   1 +
 drivers/soc/qcom/soc_sleep_stats.c | 241 +++++++++++++++++++++++++++++++++++++
 3 files changed, 252 insertions(+)
 create mode 100644 drivers/soc/qcom/soc_sleep_stats.c
drivers/soc/qcom/Kconfig +10 -0
index 79b568f..e80b63a 100644
@@ -190,6 +190,16 @@ config QCOM_SOCINFO
 	 Say yes here to support the Qualcomm socinfo driver, providing
 	 information about the SoC to user space.
 
+config QCOM_SOC_SLEEP_STATS
+	tristate "Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver"
+	depends on ARCH_QCOM && DEBUG_FS || COMPILE_TEST
+	depends on QCOM_SMEM
+	help
+	  Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver to read
+	  the shared memory exported by the remote processor related to
+	  various SoC level low power modes statistics and export to debugfs
+	  interface.
+
 config QCOM_WCNSS_CTRL
 	tristate "Qualcomm WCNSS control driver"
 	depends on ARCH_QCOM || COMPILE_TEST
drivers/soc/qcom/Makefile +0 -0
index ad675a6..5f30d74 100644

drivers/soc/qcom/Makefile obj-$(CONFIG_QCOM_SMEM_STATE) += smem_state.o · line 23

Quoted 4 lines
drivers/soc/qcom/Makefile +1 -0
@@ -20,6 +20,7 @@ obj-$(CONFIG_QCOM_SMEM_STATE) += smem_state.o
 obj-$(CONFIG_QCOM_SMP2P)	+= smp2p.o
 obj-$(CONFIG_QCOM_SMSM)	+= smsm.o
 obj-$(CONFIG_QCOM_SOCINFO)	+= socinfo.o
+obj-$(CONFIG_QCOM_SOC_SLEEP_STATS)	+= soc_sleep_stats.o

I know that the rest of the modules here does a bad job and have completely generic names, but could we rename this "qcom_sleep_stats" instead?

Quoted 4 lines
drivers/soc/qcom/Makefile +0 -0
 obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o
 obj-$(CONFIG_QCOM_APR) += apr.o
 obj-$(CONFIG_QCOM_LLCC) += llcc-qcom.o
drivers/soc/qcom/soc_sleep_stats.c +0 -0

[..]

Quoted 6 lines
drivers/soc/qcom/soc_sleep_stats.c +6 -0
+static int qcom_soc_sleep_stats_probe(struct platform_device *pdev)
+{
+	struct resource *res;
+	void __iomem *reg;
+	struct dentry *root;
+	const struct stats_config *config;

drivers/soc/qcom/soc_sleep_stats.c line 181

Quoted 10 lines
drivers/soc/qcom/soc_sleep_stats.c +10 -0
+	struct stats_data *d;
+	int i;
+
+	config = device_get_match_data(&pdev->dev);
+	if (!config)
+		return -ENODEV;
+
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!res)
+		return PTR_ERR(res);

You no longer use this "res".

drivers/soc/qcom/soc_sleep_stats.c line 184

Quoted 3 lines
drivers/soc/qcom/soc_sleep_stats.c +3 -0
+
+	reg = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
+	if (!reg)

IS_ERR()

Quoted 34 lines
drivers/soc/qcom/soc_sleep_stats.c +34 -0
+		return -ENOMEM;
+
+	d = devm_kcalloc(&pdev->dev, config->num_records,
+			 sizeof(*d), GFP_KERNEL);
+	if (!d)
+		return -ENOMEM;
+
+	for (i = 0; i < config->num_records; i++)
+		d[i].appended_stats_avail = config->appended_stats_avail;
+
+	root = debugfs_create_dir("qcom_sleep_stats", NULL);
+
+	qcom_create_subsystem_stat_files(root);
+	qcom_create_soc_sleep_stat_files(root, reg, d, config->num_records);
+
+	platform_set_drvdata(pdev, root);
+
+	return 0;
+}
+
+static int qcom_soc_sleep_stats_remove(struct platform_device *pdev)
+{
+	struct dentry *root = platform_get_drvdata(pdev);
+
+	debugfs_remove_recursive(root);
+
+	return 0;
+}
+
+static const struct stats_config rpm_data = {
+	.num_records = 2,
+	.appended_stats_avail = true,
+};
+

drivers/soc/qcom/soc_sleep_stats.c line 228

Quoted 10 lines
drivers/soc/qcom/soc_sleep_stats.c +10 -0
+static const struct stats_config rpmh_data = {
+	.num_records = 3,
+	.appended_stats_avail = false,
+};
+
+static const struct of_device_id qcom_soc_sleep_stats_table[] = {
+	{ .compatible = "qcom,rpm-sleep-stats", .data = &rpm_data },
+	{ .compatible = "qcom,rpmh-sleep-stats", .data = &rpmh_data },
+	{ }
+};

MODULE_DEVICE_TABLE(of, qcom_soc_sleep_stats_table);

Otherwise the module doesn't load automatically.

Regards,
Bjorn

Quoted 17 lines
drivers/soc/qcom/soc_sleep_stats.c +13 -0
+
+static struct platform_driver soc_sleep_stats = {
+	.probe = qcom_soc_sleep_stats_probe,
+	.remove = qcom_soc_sleep_stats_remove,
+	.driver = {
+		.name = "soc_sleep_stats",
+		.of_match_table = qcom_soc_sleep_stats_table,
+	},
+};
+module_platform_driver(soc_sleep_stats);
+
+MODULE_DESCRIPTION("Qualcomm Technologies, Inc. (QTI) SoC Sleep Stats driver");
+MODULE_LICENSE("GPL v2");
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#7 lore raw

Re: [PATCH v9 2/5] soc: qcom: Add SoC sleep stats driver

Hi,

Quoted 54 lines · Bjorn Andersson
Quoted 52 lines · Maulik Shah

From: Mahesh Sivasubramanian <[email protected]>

Let's add a driver to read the stats from remote processor and export to debugfs.

The driver creates "qcom_sleep_stats" directory in debugfs and adds files for various low power mode available. Below is sample output with command

cat /sys/kernel/debug/qcom_sleep_stats/ddr
count = 0
Last Entered At = 0
Last Exited At = 0
Accumulated Duration = 0

[mkshah: add subsystem sleep stats, create one file for each stat]
---
  drivers/soc/qcom/Kconfig           |  10 ++
  drivers/soc/qcom/Makefile          |   1 +
  drivers/soc/qcom/soc_sleep_stats.c | 241 +++++++++++++++++++++++++++++++++++++
  3 files changed, 252 insertions(+)

create mode 100644 drivers/soc/qcom/soc_sleep_stats.c

drivers/soc/qcom/Kconfig +10 -0
index 79b568f..e80b63a 100644
@@ -190,6 +190,16 @@ config QCOM_SOCINFO
  	 Say yes here to support the Qualcomm socinfo driver, providing
  	 information about the SoC to user space.
 
+config QCOM_SOC_SLEEP_STATS
+	tristate "Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver"
+	depends on ARCH_QCOM && DEBUG_FS || COMPILE_TEST
+	depends on QCOM_SMEM
+	help
+	  Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver to read
+	  the shared memory exported by the remote processor related to
+	  various SoC level low power modes statistics and export to debugfs
+	  interface.
+
  config QCOM_WCNSS_CTRL
  	tristate "Qualcomm WCNSS control driver"
  	depends on ARCH_QCOM || COMPILE_TEST
drivers/soc/qcom/Makefile +0 -0
index ad675a6..5f30d74 100644
@@ -20,6 +20,7 @@ obj-$(CONFIG_QCOM_SMEM_STATE) += smem_state.o
Quoted 8 lines

drivers/soc/qcom/Makefile obj-$(CONFIG_QCOM_SMEM_STATE) += smem_state.o · line 23

Quoted 4 lines
drivers/soc/qcom/Makefile +1 -0
  obj-$(CONFIG_QCOM_SMP2P)	+= smp2p.o
  obj-$(CONFIG_QCOM_SMSM)	+= smsm.o
  obj-$(CONFIG_QCOM_SOCINFO)	+= socinfo.o
+obj-$(CONFIG_QCOM_SOC_SLEEP_STATS)	+= soc_sleep_stats.o

I know that the rest of the modules here does a bad job and have completely generic names, but could we rename this "qcom_sleep_stats" instead?

Sure renamed in v10.

Quoted 16 lines
Quoted 5 lines
drivers/soc/qcom/Makefile +0 -0
  obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o
  obj-$(CONFIG_QCOM_APR) += apr.o
  obj-$(CONFIG_QCOM_LLCC) += llcc-qcom.o
drivers/soc/qcom/soc_sleep_stats.c +0 -0

[..]

Quoted 10 lines
drivers/soc/qcom/soc_sleep_stats.c +10 -0
+static int qcom_soc_sleep_stats_probe(struct platform_device *pdev)
+{
+	struct resource *res;
+	void __iomem *reg;
+	struct dentry *root;
+	const struct stats_config *config;
+	struct stats_data *d;
+	int i;
+
+	config = device_get_match_data(&pdev->dev);
Quoted 8 lines

drivers/soc/qcom/soc_sleep_stats.c line 181

Quoted 6 lines
drivers/soc/qcom/soc_sleep_stats.c +6 -0
+	if (!config)
+		return -ENODEV;
+
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!res)
+		return PTR_ERR(res);

You no longer use this "res".

Thanks for catching this, removed in v10.

Quoted 6 lines

drivers/soc/qcom/soc_sleep_stats.c line 184

Quoted 4 lines
drivers/soc/qcom/soc_sleep_stats.c +3 -0
+
+	reg = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
+	if (!reg)

IS_ERR()

Updated in v10 to use IS_ERR().

Quoted 48 lines
Quoted 35 lines
drivers/soc/qcom/soc_sleep_stats.c +34 -0
+		return -ENOMEM;
+
+	d = devm_kcalloc(&pdev->dev, config->num_records,
+			 sizeof(*d), GFP_KERNEL);
+	if (!d)
+		return -ENOMEM;
+
+	for (i = 0; i < config->num_records; i++)
+		d[i].appended_stats_avail = config->appended_stats_avail;
+
+	root = debugfs_create_dir("qcom_sleep_stats", NULL);
+
+	qcom_create_subsystem_stat_files(root);
+	qcom_create_soc_sleep_stat_files(root, reg, d, config->num_records);
+
+	platform_set_drvdata(pdev, root);
+
+	return 0;
+}
+
+static int qcom_soc_sleep_stats_remove(struct platform_device *pdev)
+{
+	struct dentry *root = platform_get_drvdata(pdev);
+
+	debugfs_remove_recursive(root);
+
+	return 0;
+}
+
+static const struct stats_config rpm_data = {
+	.num_records = 2,
+	.appended_stats_avail = true,
+};
+

drivers/soc/qcom/soc_sleep_stats.c line 228

Quoted 10 lines
drivers/soc/qcom/soc_sleep_stats.c +10 -0
+static const struct stats_config rpmh_data = {
+	.num_records = 3,
+	.appended_stats_avail = false,
+};
+
+static const struct of_device_id qcom_soc_sleep_stats_table[] = {
+	{ .compatible = "qcom,rpm-sleep-stats", .data = &rpm_data },
+	{ .compatible = "qcom,rpmh-sleep-stats", .data = &rpmh_data },
+	{ }
+};

MODULE_DEVICE_TABLE(of, qcom_soc_sleep_stats_table);

Quoted 4 lines

Otherwise the module doesn't load automatically.

Regards,
Bjorn

Added MODULE_DEVICE_TABLE in v10.

Thanks,
Maulik

Quoted 18 lines
Quoted 18 lines
drivers/soc/qcom/soc_sleep_stats.c +13 -0
+
+static struct platform_driver soc_sleep_stats = {
+	.probe = qcom_soc_sleep_stats_probe,
+	.remove = qcom_soc_sleep_stats_remove,
+	.driver = {
+		.name = "soc_sleep_stats",
+		.of_match_table = qcom_soc_sleep_stats_table,
+	},
+};
+module_platform_driver(soc_sleep_stats);
+
+MODULE_DESCRIPTION("Qualcomm Technologies, Inc. (QTI) SoC Sleep Stats driver");
+MODULE_LICENSE("GPL v2");
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#8 lore raw

PATCH v9 3/5 arm64: dts: qcom: sc7180: Enable SoC sleep stats

In reply to Maulik Shah

Add device node for SoC sleep stats driver which provides various low power mode stats.

Also update the reg size of aoss_qmp device to 0x400.

---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +6 -1
index c8921e2..c339605b 100644
@@ -3219,7 +3219,7 @@
 
 		aoss_qmp: power-controller@c300000 {
 			compatible = "qcom,sc7180-aoss-qmp";
-			reg = <0 0x0c300000 0 0x100000>;
+			reg = <0 0x0c300000 0 0x400>;
 			interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
 			mboxes = <&apss_shared 0>;
 
@@ -3227,6 +3227,11 @@
 			#power-domain-cells = <1>;
 		};
 
+		aop_msgram@c3f0048 {
+			compatible = "qcom,rpmh-sleep-stats";
+			reg = <0 0x0c3f0048 0 0x400>;
+		};
+
 		spmi_bus: spmi@c440000 {
 			compatible = "qcom,spmi-pmic-arb";
 			reg = <0 0x0c440000 0 0x1100>,
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#9 lore raw

PATCH v9 4/5 arm64: defconfig: Enable SoC sleep stats driver

In reply to Maulik Shah

Enable SoC sleep stats driver. The driver gives statistics for various low power modes on Qualcomm Technologies, Inc. (QTI) SoCs.

---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
index 3bf6f8a..ba7c403 100644
@@ -1040,6 +1040,7 @@ CONFIG_QCOM_SMD_RPM=y
 CONFIG_QCOM_SMP2P=y
 CONFIG_QCOM_SMSM=y
 CONFIG_QCOM_SOCINFO=m
+CONFIG_QCOM_SOC_SLEEP_STATS=m
 CONFIG_QCOM_APR=m
 CONFIG_ARCH_R8A774A1=y
 CONFIG_ARCH_R8A774B1=y
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#10 lore raw

PATCH v9 5/5 arm64: dts: qcom: sc7280: Enable SoC sleep stats

In reply to Maulik Shah

Add device node for SoC sleep stats driver which provides various low power mode stats.

Also update the reg size of aoss_qmp device to 0x400.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sc7280.dtsi +6 -1
index 53a21d0..aba7dd1 100644
@@ -1473,7 +1473,7 @@
 
 		aoss_qmp: power-controller@c300000 {
 			compatible = "qcom,sc7280-aoss-qmp";
-			reg = <0 0x0c300000 0 0x100000>;
+			reg = <0 0x0c300000 0 0x400>;
 			interrupts-extended = <&ipcc IPCC_CLIENT_AOP
 						     IPCC_MPROC_SIGNAL_GLINK_QMP
 						     IRQ_TYPE_EDGE_RISING>;
@@ -1484,6 +1484,11 @@
 			#power-domain-cells = <1>;
 		};
 
+		aop_msgram@c3f0048 {
+			compatible = "qcom,rpmh-sleep-stats";
+			reg = <0 0x0c3f0048 0 0x400>;
+		};
+
 		spmi_bus: spmi@c440000 {
 			compatible = "qcom,spmi-pmic-arb";
 			reg = <0 0x0c440000 0 0x1100>,
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation