Skip to contentSkip to conversation

ASoC: dt-bindings: lpass: add binding headers for digital codecs

PATCH Superseded Srinivasa Rao Mandadapu 4 participants 8 messages Sep 6, 2021 – Sep 13, 2021

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: lpass: add binding headers for digital codecs

Add header defining for lpass internal digital codecs rx,tx and va dai node id's.

---
 include/dt-bindings/sound/qcom,lpass.h | 5 +++++
 1 file changed, 5 insertions(+)
include/dt-bindings/sound/qcom,lpass.h +5 -0
index 7b0b80b..187af45 100644
@@ -10,6 +10,11 @@
 
 #define LPASS_DP_RX	5
 
+#define LPASS_CDC_DMA_RX0 6
+#define LPASS_CDC_DMA_TX3 7
+#define LPASS_CDC_DMA_VA0 8
+#define LPASS_MAX_PORTS 9
+
 #define LPASS_MCLK0	0
 
 #endif /* __DT_QCOM_LPASS_H */
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#1 lore raw

Quoting Srinivasa Rao Mandadapu (2021-09-06 06:27:34)

Quoted 13 lines

Add header defining for lpass internal digital codecs rx,tx and va dai node id's.

---
 include/dt-bindings/sound/qcom,lpass.h | 5 +++++
 1 file changed, 5 insertions(+)
include/dt-bindings/sound/qcom,lpass.h +0 -0
index 7b0b80b..187af45 100644

include/dt-bindings/sound/qcom,lpass.h line 16

Quoted 7 lines
include/dt-bindings/sound/qcom,lpass.h +4 -0
@@ -10,6 +10,11 @@
 
 #define LPASS_DP_RX    5
 
+#define LPASS_CDC_DMA_RX0 6
+#define LPASS_CDC_DMA_TX3 7
+#define LPASS_CDC_DMA_VA0 8
+#define LPASS_MAX_PORTS 9

Do we need LPASS_MAX_PORTS in the binding?

#2 lore raw

Thanks For Review Stephen!!!

Quoted 15 lines · Stephen Boyd

Quoting Srinivasa Rao Mandadapu (2021-09-06 06:27:34)

Quoted 14 lines

Add header defining for lpass internal digital codecs rx,tx and va dai node id's.

---
  include/dt-bindings/sound/qcom,lpass.h | 5 +++++
  1 file changed, 5 insertions(+)
include/dt-bindings/sound/qcom,lpass.h +0 -0
index 7b0b80b..187af45 100644
@@ -10,6 +10,11 @@
 
Quoted 7 lines

include/dt-bindings/sound/qcom,lpass.h line 16

Quoted 6 lines
include/dt-bindings/sound/qcom,lpass.h +4 -0
  #define LPASS_DP_RX    5
 
+#define LPASS_CDC_DMA_RX0 6
+#define LPASS_CDC_DMA_TX3 7
+#define LPASS_CDC_DMA_VA0 8
+#define LPASS_MAX_PORTS 9

Do we need LPASS_MAX_PORTS in the binding?

Yes.  based on this creating array of streams in machine driver. So to make upper limit introduced this macro.

Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
maintainer
#3 lore raw
Quoted 10 lines · Srinivasa Rao Mandadapu
Quoted 6 lines · Stephen Boyd

Quoting Srinivasa Rao Mandadapu (2021-09-06 06:27:34)

include/dt-bindings/sound/qcom,lpass.h line 16

Quoted 2 lines
include/dt-bindings/sound/qcom,lpass.h +2 -0
+#define LPASS_CDC_DMA_VA0 8
+#define LPASS_MAX_PORTS 9

Do we need LPASS_MAX_PORTS in the binding?

Yes.  based on this creating array of streams in machine driver. So to make upper limit introduced this macro.

That's saying it's useful to have it in the code, do we need it in the binding itself though?

#4 lore raw

Thanks for Your Time Mark Brown!!!

Quoted 10 lines · Mark Brown
Quoted 7 lines · Srinivasa Rao Mandadapu
Quoted 4 lines · Stephen Boyd

Quoting Srinivasa Rao Mandadapu (2021-09-06 06:27:34)

include/dt-bindings/sound/qcom,lpass.h line 16

Quoted 2 lines
include/dt-bindings/sound/qcom,lpass.h +2 -0
+#define LPASS_CDC_DMA_VA0 8
+#define LPASS_MAX_PORTS 9

Do we need LPASS_MAX_PORTS in the binding?

Yes.  based on this creating array of streams in machine driver. So to make upper limit introduced this macro.

That's saying it's useful to have it in the code, do we need it in the binding itself though?

Okay.  Got it. will remove it and share new patch.

Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#5 lore raw
In reply to Srinivasa Rao Mandadapu
Quoted 1 line · Srinivasa Rao Mandadapu

+#define LPASS_CDC_DMA_RX0 6

You are only adding RX0, what happens to RX1.. RX7

TBH, skipping other entries for ex CDC_DMA_RX will end up with sparse numbering.

Please add all the entries for CDC_DMA_RX and other ports as well.

Like:

#define LPASS_CDC_DMA_RX0 6
#define LPASS_CDC_DMA_RX1 7
#define LPASS_CDC_DMA_RX2 8
#define LPASS_CDC_DMA_RX3 9
#define LPASS_CDC_DMA_RX4 10
#define LPASS_CDC_DMA_RX5 11
#define LPASS_CDC_DMA_RX6 12
#define LPASS_CDC_DMA_RX7 13

include/dt-bindings/sound/qcom,lpass.h line 15

Quoted 2 lines
include/dt-bindings/sound/qcom,lpass.h +2 -0
+#define LPASS_CDC_DMA_TX3 7
+#define LPASS_CDC_DMA_VA0 8

You mean VA_TX0?

Quoted 1 line

+#define LPASS_MAX_PORTS 9

We really do not need this in bindings.
You could add this is some of the driver header files instead.

--srini

Quoted 1 line

+

#6 lore raw

Thanks for your time and valuable suggestions Srini!!

Quoted 13 lines · Srinivas Kandagatla
Quoted 1 line · Srinivasa Rao Mandadapu

+#define LPASS_CDC_DMA_RX0 6

You are only adding RX0, what happens to RX1.. RX7

TBH, skipping other entries for ex CDC_DMA_RX will end up with sparse numbering.

Please add all the entries for CDC_DMA_RX and other ports as well.

Like:

Quoted 10 lines

#define LPASS_CDC_DMA_RX0    6
#define LPASS_CDC_DMA_RX1    7
#define LPASS_CDC_DMA_RX2    8
#define LPASS_CDC_DMA_RX3    9
#define LPASS_CDC_DMA_RX4    10
#define LPASS_CDC_DMA_RX5    11
#define LPASS_CDC_DMA_RX6    12
#define LPASS_CDC_DMA_RX7    13

Okay. Will add and Share new patch.

Quoted 4 lines

include/dt-bindings/sound/qcom,lpass.h line 15

Quoted 2 lines
include/dt-bindings/sound/qcom,lpass.h +2 -0
+#define LPASS_CDC_DMA_TX3 7
+#define LPASS_CDC_DMA_VA0 8

You mean VA_TX0?

Yes. Will change accordingly.

Quoted 5 lines
Quoted 2 lines

+#define LPASS_MAX_PORTS 9

We really do not need this in bindings.
You could add this is some of the driver header files instead.

Okay Will remove.

Quoted 2 lines

--srini

Quoted 1 line

+

Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
maintainer
#7 lore raw
In reply to Srinivasa Rao Mandadapu
Quoted 4 lines · Srinivasa Rao Mandadapu

Add header defining for lpass internal digital codecs rx,tx and va dai node id's.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: lpass: add binding headers for digital codecs

      commit: bfad37c53ae6168d03ab06868ea44e77995c43d5

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark