Skip to contentSkip to conversation

arm64: dts: qcom: sc7280-idp: Add vcc-supply for qfprom

PATCH In review Rajendra Nayak 3 participants 4 messages Sep 13, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sc7280-idp: Add vcc-supply for qfprom

Add vcc-supply for the IDP boards that was missed when the qfprom device tree properties were added for the sc7280 SoC.

Fixes c1b2189a19cf ("arm64: dts: qcom: sc7280: Add qfprom node")
---
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +4 -0
index 371a2a9..99f9ee5 100644
@@ -207,6 +207,10 @@
 	};
 };
 
+&qfprom {
+	vcc-supply = <&vreg_l1c_1p8>;
+};
+
 &qupv3_id_0 {
 	status = "okay";
 };
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v1 1/1
#1 lore raw

Quoting Rajendra Nayak (2021-09-13 03:58:55)

Quoted 7 lines

Add vcc-supply for the IDP boards that was missed when the qfprom device tree properties were added for the sc7280 SoC.

Fixes c1b2189a19cf ("arm64: dts: qcom: sc7280: Add qfprom node")

---

arch/arm64/boot/dts/qcom/sc7280-idp.dtsi line 210

Quoted 12 lines
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +1 -0
index 371a2a9..99f9ee5 100644
@@ -207,6 +207,10 @@
        };
 };
 
+&qfprom {

Maybe that node should also be marked status = "disabled" by default so that it can only be marked OK if the board has setup the regulator properly?

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +3 -0
+       vcc-supply = <&vreg_l1c_1p8>;
+};
+
 &qupv3_id_0 {
        status = "okay";
 };
#2 lore raw

Hi,

Quoted 23 lines · Stephen Boyd

Quoting Rajendra Nayak (2021-09-13 03:58:55)

Quoted 7 lines

Add vcc-supply for the IDP boards that was missed when the qfprom device tree properties were added for the sc7280 SoC.

Fixes c1b2189a19cf ("arm64: dts: qcom: sc7280: Add qfprom node")

---

Quoted 11 lines
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +0 -0
index 371a2a9..99f9ee5 100644
@@ -207,6 +207,10 @@
        };
 };
 
Quoted 5 lines

arch/arm64/boot/dts/qcom/sc7280-idp.dtsi line 210

Quoted 1 line
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +1 -0
+&qfprom {

Maybe that node should also be marked status = "disabled" by default so that it can only be marked OK if the board has setup the regulator properly?

I don't think that's a good idea. You still want to be able to use the nvmem in "read only" mode and it doesn't seem to need the regulator for that. This is only for burning.

I believe that actually everything will work out fine-ish for boards that leave this regulator off. They'll get a dummy regulator. When they start trying to burn fuses and the call the regulator_set_voltage() happens then that'll fail (you can't do that on a dummy) and we should error out of writing. Reading will work fine. It would probably be better if qfprom_probe() used devm_regulator_get_optional() though and fell back to read-only mode. I'm happy to review a patch that does that.

-Doug

Reviewed-by on v1 1/1
#3 lore raw
In reply to Rajendra Nayak

Hi,

Quoted 10 lines · Rajendra Nayak

Add vcc-supply for the IDP boards that was missed when the qfprom device tree properties were added for the sc7280 SoC.

Fixes c1b2189a19cf ("arm64: dts: qcom: sc7280: Add qfprom node")
---
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++++
 1 file changed, 4 insertions(+)