Skip to contentSkip to conversation

arm: aspeed: Add UART routing support

PATCH Superseded Chia-Wei Wang 3 participants 9 messages Sep 13, 2021 – Sep 15, 2021

Subsystems (3)

v4 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v4 cover arm: aspeed: Add UART routing support

Add UART routing driver and the device tree nodes.

v4:
- Convert aspeed-lpc bindings to YAML schema to resolve dependecy issues

v3:
- Add individual bindings in YAML
- Add support for AST24xx (AST25xx shares the same design)
- Add more explanation for the sysfs ABI

v2:
- Add dt-bindings
- Add ABI documents for the exported sysfs interface
- Revise driver implementation suggested by Joel

Chia-Wei Wang (4):
dt-bindings: mfd: aspeed-lpc: Convert to YAML schema
dt-bindings: aspeed: Add UART routing controller
soc: aspeed: Add UART routing support
ARM: dts: aspeed: Add uart routing to device tree

 .../testing/sysfs-driver-aspeed-uart-routing  |  15 +
 .../devicetree/bindings/mfd/aspeed-lpc.txt    | 157 -----
 .../devicetree/bindings/mfd/aspeed-lpc.yaml   | 191 ++++++
 .../bindings/soc/aspeed/uart-routing.yaml     |  70 ++
 arch/arm/boot/dts/aspeed-g4.dtsi              |   6 +
 arch/arm/boot/dts/aspeed-g5.dtsi              |   6 +
 arch/arm/boot/dts/aspeed-g6.dtsi              |   6 +
 drivers/soc/aspeed/Kconfig                    |  10 +
 drivers/soc/aspeed/Makefile                   |   9 +-
 drivers/soc/aspeed/aspeed-uart-routing.c      | 603 ++++++++++++++++++
 10 files changed, 912 insertions(+), 161 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-aspeed-uart-routing
 delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml
 create mode 100644 drivers/soc/aspeed/aspeed-uart-routing.c
Signature · 1 line
2.17.1
#1 lore raw

PATCH v4 1/4 dt-bindings: mfd: aspeed-lpc: Convert to YAML schema

Convert the bindings of Aspeed LPC from text file into YAML schema.

---
 .../devicetree/bindings/mfd/aspeed-lpc.txt    | 157 ---------------
 .../devicetree/bindings/mfd/aspeed-lpc.yaml   | 187 ++++++++++++++++++
 2 files changed, 187 insertions(+), 157 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0 -157
deleted file mode 100644
index 936aa108eab4..000000000000
@@ -1,157 +0,0 @@
-======================================================================
-Device tree bindings for the Aspeed Low Pin Count (LPC) Bus Controller
-======================================================================
-
-The LPC bus is a means to bridge a host CPU to a number of low-bandwidth
-peripheral devices, replacing the use of the ISA bus in the age of PCI[0]. The
-primary use case of the Aspeed LPC controller is as a slave on the bus
-(typically in a Baseboard Management Controller SoC), but under certain
-conditions it can also take the role of bus master.
-
-The LPC controller is represented as a multi-function device to account for the
-mix of functionality, which includes, but is not limited to:
-
-* An IPMI Block Transfer[2] Controller
-
-* An LPC Host Controller: Manages LPC functions such as host vs slave mode, the
-  physical properties of some LPC pins, configuration of serial IRQs, and
-  APB-to-LPC bridging amonst other functions.
-
-* An LPC Host Interface Controller: Manages functions exposed to the host such
-  as LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART
-  management and bus snoop configuration.
-
-* A set of SuperIO[3] scratch registers: Enables implementation of e.g. custom
-  hardware management protocols for handover between the host and baseboard
-  management controller.
-
-Additionally the state of the LPC controller influences the pinmux
-configuration, therefore the host portion of the controller is exposed as a
-syscon as a means to arbitrate access.
-
-[0] http://www.intel.com/design/chipsets/industry/25128901.pdf
-[1] https://www.renesas.com/en-sg/doc/products/mpumcu/001/rej09b0078_h8s2168.pdf?key=7c88837454702128622bee53acbda8f4
-[2] https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf
-[3] https://en.wikipedia.org/wiki/Super_I/O
-
-Required properties
-===================
-
-- compatible:	One of:
-		"aspeed,ast2400-lpc-v2", "simple-mfd", "syscon"
-		"aspeed,ast2500-lpc-v2", "simple-mfd", "syscon"
-		"aspeed,ast2600-lpc-v2", "simple-mfd", "syscon"
-
-- reg:		contains the physical address and length values of the Aspeed
-                LPC memory region.
-
-- #address-cells: <1>
-- #size-cells:	<1>
-- ranges:	Maps 0 to the physical address and length of the LPC memory
-                region
-
-Example:
-
-lpc: lpc at 1e789000 {
-	compatible = "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon";
-	reg = <0x1e789000 0x1000>;
-
-	#address-cells = <1>;
-	#size-cells = <1>;
-	ranges = <0x0 0x1e789000 0x1000>;
-
-	lpc_snoop: lpc-snoop at 0 {
-		compatible = "aspeed,ast2600-lpc-snoop";
-		reg = <0x0 0x80>;
-		interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
-		snoop-ports = <0x80>;
-	};
-};
-
-
-LPC Host Interface Controller
--------------------
-
-The LPC Host Interface Controller manages functions exposed to the host such as
-LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART
-management and bus snoop configuration.
-
-Required properties:
-
-- compatible:	One of:
-		"aspeed,ast2400-lpc-ctrl";
-		"aspeed,ast2500-lpc-ctrl";
-		"aspeed,ast2600-lpc-ctrl";
-
-- reg:		contains offset/length values of the host interface controller
-		memory regions
-
-- clocks:	contains a phandle to the syscon node describing the clocks.
-		There should then be one cell representing the clock to use
-
-Optional properties:
-
-- memory-region: A phandle to a reserved_memory region to be used for the LPC
-		to AHB mapping
-
-- flash:	A phandle to the SPI flash controller containing the flash to
-		be exposed over the LPC to AHB mapping
-
-Example:
-
-lpc_ctrl: lpc-ctrl at 80 {
-	compatible = "aspeed,ast2500-lpc-ctrl";
-	reg = <0x80 0x80>;
-	clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
-	memory-region = <&flash_memory>;
-	flash = <&spi>;
-};
-
-LPC Host Controller
--------------------
-
-The Aspeed LPC Host Controller configures the Low Pin Count (LPC) bus behaviour
-between the host and the baseboard management controller. The registers exist
-in the "host" portion of the Aspeed LPC controller, which must be the parent of
-the LPC host controller node.
-
-Required properties:
-
-- compatible:	One of:
-		"aspeed,ast2400-lhc";
-		"aspeed,ast2500-lhc";
-		"aspeed,ast2600-lhc";
-
-- reg:		contains offset/length values of the LHC memory regions. In the
-		AST2400 and AST2500 there are two regions.
-
-Example:
-
-lhc: lhc at a0 {
-	compatible = "aspeed,ast2500-lhc";
-	reg = <0xa0 0x24 0xc8 0x8>;
-};
-
-LPC reset control
------------------
-
-The UARTs present in the ASPEED SoC can have their resets tied to the reset
-state of the LPC bus. Some systems may chose to modify this configuration.
-
-Required properties:
-
- - compatible:		One of:
-			"aspeed,ast2600-lpc-reset";
-			"aspeed,ast2500-lpc-reset";
-			"aspeed,ast2400-lpc-reset";
-
- - reg:			offset and length of the IP in the LHC memory region
- - #reset-controller	indicates the number of reset cells expected
-
-Example:
-
-lpc_reset: reset-controller at 98 {
-        compatible = "aspeed,ast2500-lpc-reset";
-        reg = <0x98 0x4>;
-        #reset-cells = <1>;
-};
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +187 -0

187 lines not on this page · raw message

Signature · 1 line
2.17.1
maintainer
#2 lore raw

Re: [PATCH v4 1/4] dt-bindings: mfd: aspeed-lpc: Convert to YAML schema

Quoted 10 lines · Chia-Wei Wang

Convert the bindings of Aspeed LPC from text file into YAML schema.

---
 .../devicetree/bindings/mfd/aspeed-lpc.txt    | 157 ---------------
 .../devicetree/bindings/mfd/aspeed-lpc.yaml   | 187 ++++++++++++++++++
 2 files changed, 187 insertions(+), 157 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mfd/aspeed-lpc.example.dts:30.35-36.15: Warning (unique_unit_address): /example-0/lpc at 1e789000/lpc-ctrl at 80: duplicate unit-address (also used in node /example-0/lpc at 1e789000/lpc-snoop at 80) Documentation/devicetree/bindings/mfd/aspeed-lpc.example.dt.yaml:0:0: /example-0/lpc at 1e789000/lpc-ctrl at 80: failed to match any schema with compatible: ['aspeed,ast2600-lpc-ctrl'] Documentation/devicetree/bindings/mfd/aspeed-lpc.example.dt.yaml:0:0: /example-0/lpc at 1e789000/reset-controller at 98: failed to match any schema with compatible: ['aspeed,ast2600-lpc-reset'] Documentation/devicetree/bindings/mfd/aspeed-lpc.example.dt.yaml:0:0: /example-0/lpc at 1e789000/lpc-snoop at 80: failed to match any schema with compatible: ['aspeed,ast2600-lpc-snoop']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1527193

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit.

#3 lore raw

RE: [PATCH v4 1/4] dt-bindings: mfd: aspeed-lpc: Convert to YAML schema

Quoted 23 lines

From: Rob Herring <[email protected]>
Sent: Monday, September 13, 2021 8:19 PM

Quoted 6 lines · Chia-Wei Wang

Convert the bindings of Aspeed LPC from text file into YAML schema.

---
 .../devicetree/bindings/mfd/aspeed-lpc.txt    | 157 ---------------
 .../devicetree/bindings/mfd/aspeed-lpc.yaml   | 187

++++++++++++++++++

Quoted 5 lines
 2 files changed, 187 insertions(+), 157 deletions(-)  delete mode
100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
 create mode 100644

Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

Quoted 15 lines

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mfd/aspeed-lpc.example.dts:30.35-36.15:
Warning (unique_unit_address): /example-0/lpc at 1e789000/lpc-ctrl at 80:
duplicate unit-address (also used in node
/example-0/lpc at 1e789000/lpc-snoop at 80) Documentation/devicetree/bindings/mfd/aspeed-lpc.example.dt.yaml:0:0:
/example-0/lpc at 1e789000/lpc-ctrl at 80: failed to match any schema with
compatible: ['aspeed,ast2600-lpc-ctrl'] Documentation/devicetree/bindings/mfd/aspeed-lpc.example.dt.yaml:0:0:
/example-0/lpc at 1e789000/reset-controller at 98: failed to match any schema with compatible: ['aspeed,ast2600-lpc-reset'] Documentation/devicetree/bindings/mfd/aspeed-lpc.example.dt.yaml:0:0:
/example-0/lpc at 1e789000/lpc-snoop at 80: failed to match any schema with
compatible: ['aspeed,ast2600-lpc-snoop']

I also encountered this error locally.
However, I couldn't find the root cause as these three compatible strings have been described in the same YAML file. Could you guys help to give me some hints to resolve this issue? Greatly appreciate that.

Quoted 7 lines

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1527193

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

Quoted 7 lines

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit.

My dtschema & yamllint version:
dtschema-2021.7
yamllint-1.26.3

Regards,
Chiawei

#4 lore raw

Re: [PATCH v4 1/4] dt-bindings: mfd: aspeed-lpc: Convert to YAML schema

In reply to Chia-Wei Wang
Quoted 239 lines · Chia-Wei Wang

Convert the bindings of Aspeed LPC from text file into YAML schema.

---
 .../devicetree/bindings/mfd/aspeed-lpc.txt    | 157 ---------------
 .../devicetree/bindings/mfd/aspeed-lpc.yaml   | 187 ++++++++++++++++++
 2 files changed, 187 insertions(+), 157 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0 -157
deleted file mode 100644
index 936aa108eab4..000000000000
@@ -1,157 +0,0 @@
-======================================================================
-Device tree bindings for the Aspeed Low Pin Count (LPC) Bus Controller
-======================================================================
-
-The LPC bus is a means to bridge a host CPU to a number of low-bandwidth
-peripheral devices, replacing the use of the ISA bus in the age of PCI[0]. The
-primary use case of the Aspeed LPC controller is as a slave on the bus
-(typically in a Baseboard Management Controller SoC), but under certain
-conditions it can also take the role of bus master.
-
-The LPC controller is represented as a multi-function device to account for the
-mix of functionality, which includes, but is not limited to:
-
-* An IPMI Block Transfer[2] Controller
-
-* An LPC Host Controller: Manages LPC functions such as host vs slave mode, the
-  physical properties of some LPC pins, configuration of serial IRQs, and
-  APB-to-LPC bridging amonst other functions.
-
-* An LPC Host Interface Controller: Manages functions exposed to the host such
-  as LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART
-  management and bus snoop configuration.
-
-* A set of SuperIO[3] scratch registers: Enables implementation of e.g. custom
-  hardware management protocols for handover between the host and baseboard
-  management controller.
-
-Additionally the state of the LPC controller influences the pinmux
-configuration, therefore the host portion of the controller is exposed as a
-syscon as a means to arbitrate access.
-
-[0] http://www.intel.com/design/chipsets/industry/25128901.pdf
-[1] https://www.renesas.com/en-sg/doc/products/mpumcu/001/rej09b0078_h8s2168.pdf?key=7c88837454702128622bee53acbda8f4
-[2] https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf
-[3] https://en.wikipedia.org/wiki/Super_I/O
-
-Required properties
-===================
-
-- compatible:  One of:
-               "aspeed,ast2400-lpc-v2", "simple-mfd", "syscon"
-               "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon"
-               "aspeed,ast2600-lpc-v2", "simple-mfd", "syscon"
-
-- reg:         contains the physical address and length values of the Aspeed
-                LPC memory region.
-
-- #address-cells: <1>
-- #size-cells: <1>
-- ranges:      Maps 0 to the physical address and length of the LPC memory
-                region
-
-Example:
-
-lpc: lpc at 1e789000 {
-       compatible = "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon";
-       reg = <0x1e789000 0x1000>;
-
-       #address-cells = <1>;
-       #size-cells = <1>;
-       ranges = <0x0 0x1e789000 0x1000>;
-
-       lpc_snoop: lpc-snoop at 0 {
-               compatible = "aspeed,ast2600-lpc-snoop";
-               reg = <0x0 0x80>;
-               interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
-               snoop-ports = <0x80>;
-       };
-};
-
-
-LPC Host Interface Controller
--------------------
-
-The LPC Host Interface Controller manages functions exposed to the host such as
-LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART
-management and bus snoop configuration.
-
-Required properties:
-
-- compatible:  One of:
-               "aspeed,ast2400-lpc-ctrl";
-               "aspeed,ast2500-lpc-ctrl";
-               "aspeed,ast2600-lpc-ctrl";
-
-- reg:         contains offset/length values of the host interface controller
-               memory regions
-
-- clocks:      contains a phandle to the syscon node describing the clocks.
-               There should then be one cell representing the clock to use
-
-Optional properties:
-
-- memory-region: A phandle to a reserved_memory region to be used for the LPC
-               to AHB mapping
-
-- flash:       A phandle to the SPI flash controller containing the flash to
-               be exposed over the LPC to AHB mapping
-
-Example:
-
-lpc_ctrl: lpc-ctrl at 80 {
-       compatible = "aspeed,ast2500-lpc-ctrl";
-       reg = <0x80 0x80>;
-       clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
-       memory-region = <&flash_memory>;
-       flash = <&spi>;
-};
-
-LPC Host Controller
--------------------
-
-The Aspeed LPC Host Controller configures the Low Pin Count (LPC) bus behaviour
-between the host and the baseboard management controller. The registers exist
-in the "host" portion of the Aspeed LPC controller, which must be the parent of
-the LPC host controller node.
-
-Required properties:
-
-- compatible:  One of:
-               "aspeed,ast2400-lhc";
-               "aspeed,ast2500-lhc";
-               "aspeed,ast2600-lhc";
-
-- reg:         contains offset/length values of the LHC memory regions. In the
-               AST2400 and AST2500 there are two regions.
-
-Example:
-
-lhc: lhc at a0 {
-       compatible = "aspeed,ast2500-lhc";
-       reg = <0xa0 0x24 0xc8 0x8>;
-};
-
-LPC reset control
------------------
-
-The UARTs present in the ASPEED SoC can have their resets tied to the reset
-state of the LPC bus. Some systems may chose to modify this configuration.
-
-Required properties:
-
- - compatible:         One of:
-                       "aspeed,ast2600-lpc-reset";
-                       "aspeed,ast2500-lpc-reset";
-                       "aspeed,ast2400-lpc-reset";
-
- - reg:                        offset and length of the IP in the LHC memory region
- - #reset-controller   indicates the number of reset cells expected
-
-Example:
-
-lpc_reset: reset-controller at 98 {
-        compatible = "aspeed,ast2500-lpc-reset";
-        reg = <0x98 0x4>;
-        #reset-cells = <1>;
-};
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +59 -0
new file mode 100644
index 000000000000..4e3862cf2a4b
@@ -0,0 +1,187 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# # Copyright (c) 2021 Aspeed Tehchnology Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Aspeed Low Pin Count (LPC) Bus Controller
+
+maintainers:
+  - Andrew Jeffery <[email protected]>
+  - Chia-Wei Wang <[email protected]>
+
+description:
+  The LPC bus is a means to bridge a host CPU to a number of low-bandwidth
+  peripheral devices, replacing the use of the ISA bus in the age of PCI[0]. The
+  primary use case of the Aspeed LPC controller is as a slave on the bus
+  (typically in a Baseboard Management Controller SoC), but under certain
+  conditions it can also take the role of bus master.
+
+  The LPC controller is represented as a multi-function device to account for the
+  mix of functionality, which includes, but is not limited to
+
+  * An IPMI Block Transfer[2] Controller
+
+  * An LPC Host Interface Controller manages functions exposed to the host such
+    as LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART
+    management and bus snoop configuration.
+
+  * A set of SuperIO[3] scratch registers enableing implementation of e.g. custom
+    hardware management protocols for handover between the host and baseboard
+    management controller.
+
+  Additionally the state of the LPC controller influences the pinmux
+  configuration, therefore the host portion of the controller is exposed as a
+  syscon as a means to arbitrate access.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - aspeed,ast2400-lpc-v2
+          - aspeed,ast2500-lpc-v2
+          - aspeed,ast2600-lpc-v2
+      - const: simple-mfd
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+  ranges: true
+
+patternProperties:

Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml line 69

Quoted 10 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +10 -0
+  "^lpc-ctrl@[0-9a-f]+$":
+    type: object
+
+    description:
+      The LPC Host Interface Controller manages functions exposed to the host such as
+      LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART management
+      and bus snoop configuration.
+
+    properties:
+      comptabile:

typo here. This is the source of your warnings.

Rob

#5 lore raw

RE: [PATCH v4 1/4] dt-bindings: mfd: aspeed-lpc: Convert to YAML schema

Quoted 33 lines

From: Rob Herring <[email protected]>
Sent: Tuesday, September 14, 2021 8:28 PM

Quoted 7 lines · Chia-Wei Wang

Convert the bindings of Aspeed LPC from text file into YAML schema.

---
 .../devicetree/bindings/mfd/aspeed-lpc.txt    | 157 ---------------
 .../devicetree/bindings/mfd/aspeed-lpc.yaml   | 187

++++++++++++++++++

Quoted 12 lines
 2 files changed, 187 insertions(+), 157 deletions(-)  delete mode
100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
 create mode 100644

Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml

Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0 -0
deleted file mode 100644
index 936aa108eab4..000000000000

Documentation/devicetree/bindings/mfd/aspeed-lpc.txt

Quoted 7 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +6 -0
@@ -1,157 +0,0 @@
 
+patternProperties:
+  "^lpc-ctrl@[0-9a-f]+$":
+    type: object
+
+    description:
+      The LPC Host Interface Controller manages functions exposed to the

host such as

Quoted 8 lines
Quoted 1 line

+ LPC firmware hub cycles, configuration of the LPC-to-AHB mapping,

UART management

Documentation/devicetree/bindings/mfd/aspeed-lpc.txt

Quoted 4 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +4 -0
+      and bus snoop configuration.
+
+    properties:
+      comptabile:

typo here. This is the source of your warnings.

Thanks! Sorry for making this typo.
Will keep in mind to check the spelling in the future.

A v5 patch will be sent to fix these warning.

Regards,
Chiawei

#6 lore raw

PATCH v4 2/4 dt-bindings: aspeed: Add UART routing controller

In reply to Chia-Wei Wang

Add dt-bindings for Aspeed UART routing controller.

---
 .../devicetree/bindings/mfd/aspeed-lpc.yaml   |  4 ++
 .../bindings/soc/aspeed/uart-routing.yaml     | 70 +++++++++++++++++++
 2 files changed, 74 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml +4 -0
index 4e3862cf2a4b..f9aa431127ee 100644
@@ -142,6 +142,10 @@ patternProperties:
       - interrupts
       - snoop-ports
 
+  "^uart-routing@[0-9a-f]+$":
+    $ref: /schemas/soc/aspeed/uart-routing.yaml#
+    description: The UART routing control under LPC register space
+
 required:
   - compatible
   - reg
Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml new file +70 -0

70 lines not on this page · raw message

Signature · 1 line
2.17.1
#7 lore raw

PATCH v4 3/4 soc: aspeed: Add UART routing support

In reply to Chia-Wei Wang

Add driver support for the UART routing control. Users can perform runtime configuration of the RX muxes among the UART controllers and the UART IO pins.

The sysfs interface is also exported for the convenience of routing paths check and update.

---
 .../testing/sysfs-driver-aspeed-uart-routing  |  15 +
 drivers/soc/aspeed/Kconfig                    |  10 +
 drivers/soc/aspeed/Makefile                   |   9 +-
 drivers/soc/aspeed/aspeed-uart-routing.c      | 603 ++++++++++++++++++
 4 files changed, 633 insertions(+), 4 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-aspeed-uart-routing
 create mode 100644 drivers/soc/aspeed/aspeed-uart-routing.c
Documentation/ABI/testing/sysfs-driver-aspeed-uart-routing new file +15 -0
new file mode 100644
index 000000000000..65f899f1f055
@@ -0,0 +1,15 @@
+What:		/sys/bus/platform/drivers/aspeed-uart-routing/*/uart*
+Date:		September 2021
+Contact:	Chia-Wei Wang <[email protected]>
+Description:	Selects the RX source of the UARTx device. The current
+		selection will be marked with the '[]' brackets.
+Users:		OpenBMC.  Proposed changes should be mailed to
+		openbmc at lists.ozlabs.org
+
+What:		/sys/bus/platform/drivers/aspeed-uart-routing/*/io*
+Date:		September 2021
+Contact:	Chia-Wei Wang <[email protected]>
+Description:	Selects the RX source of IOx pins. The current selection
+		will be marked with the '[]' brackets.
+Users:		OpenBMC.  Proposed changes should be mailed to
+		openbmc at lists.ozlabs.org
drivers/soc/aspeed/Kconfig +10 -0
index 243ca196e6ad..f579ee0b5afa 100644
@@ -24,6 +24,16 @@ config ASPEED_LPC_SNOOP
 	  allows the BMC to listen on and save the data written by
 	  the host to an arbitrary LPC I/O port.
 
+config ASPEED_UART_ROUTING
+	tristate "ASPEED uart routing control"
+	select REGMAP
+	select MFD_SYSCON
+	default ARCH_ASPEED
+	help
+	  Provides a driver to control the UART routing paths, allowing
+	  users to perform runtime configuration of the RX muxes among
+	  the UART controllers and I/O pins.
+
 config ASPEED_P2A_CTRL
 	tristate "ASPEED P2A (VGA MMIO to BMC) bridge control"
 	select REGMAP
drivers/soc/aspeed/Makefile +5 -4
index fcab7192e1a4..b35d74592964 100644
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
-obj-$(CONFIG_ASPEED_LPC_CTRL)	+= aspeed-lpc-ctrl.o
-obj-$(CONFIG_ASPEED_LPC_SNOOP)	+= aspeed-lpc-snoop.o
-obj-$(CONFIG_ASPEED_P2A_CTRL)	+= aspeed-p2a-ctrl.o
-obj-$(CONFIG_ASPEED_SOCINFO)	+= aspeed-socinfo.o
+obj-$(CONFIG_ASPEED_LPC_CTRL)		+= aspeed-lpc-ctrl.o
+obj-$(CONFIG_ASPEED_LPC_SNOOP)		+= aspeed-lpc-snoop.o
+obj-$(CONFIG_ASPEED_UART_ROUTING)	+= aspeed-uart-routing.o
+obj-$(CONFIG_ASPEED_P2A_CTRL)		+= aspeed-p2a-ctrl.o
+obj-$(CONFIG_ASPEED_SOCINFO)		+= aspeed-socinfo.o
drivers/soc/aspeed/aspeed-uart-routing.c new file +603 -0

603 lines not on this page · raw message

Signature · 1 line
2.17.1
#8 lore raw

PATCH v4 4/4 ARM: dts: aspeed: Add uart routing to device tree

In reply to Chia-Wei Wang

Add LPC uart routing to the device tree for Aspeed SoCs.

---
 arch/arm/boot/dts/aspeed-g4.dtsi | 6 ++++++
 arch/arm/boot/dts/aspeed-g5.dtsi | 6 ++++++
 arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++++++
 3 files changed, 18 insertions(+)
arch/arm/boot/dts/aspeed-g4.dtsi +6 -0
index c5aeb3cf3a09..b313a1cf5f73 100644
@@ -383,6 +383,12 @@
 					interrupts = <8>;
 					status = "disabled";
 				};
+
+				uart_routing: uart-routing at 9c {
+					compatible = "aspeed,ast2400-uart-routing";
+					reg = <0x9c 0x4>;
+					status = "disabled";
+				};
 			};
 
 			uart2: serial at 1e78d000 {
arch/arm/boot/dts/aspeed-g5.dtsi +6 -0
index 73ca1ec6fc24..c7049454c7cb 100644
@@ -491,6 +491,12 @@
 					#reset-cells = <1>;
 				};
 
+				uart_routing: uart-routing at 9c {
+					compatible = "aspeed,ast2500-uart-routing";
+					reg = <0x9c 0x4>;
+					status = "disabled";
+				};
+
 				lhc: lhc at a0 {
 					compatible = "aspeed,ast2500-lhc";
 					reg = <0xa0 0x24 0xc8 0x8>;
arch/arm/boot/dts/aspeed-g6.dtsi +6 -0
index 1b47be1704f8..cdc59c5d86fe 100644
@@ -551,6 +551,12 @@
 					#reset-cells = <1>;
 				};
 
+				uart_routing: uart-routing at 98 {
+					compatible = "aspeed,ast2600-uart-routing";
+					reg = <0x98 0x8>;
+					status = "disabled";
+				};
+
 				ibt: ibt at 140 {
 					compatible = "aspeed,ast2600-ibt-bmc";
 					reg = <0x140 0x18>;
Signature · 1 line
2.17.1