Saw "Failed to get diagnostic page 0x1"
v4 cover Saw "Failed to get diagnostic page 0x1"
From: Wen Xiong <[email protected]>
v4:
Add checking return value before calling scsi_sense_valid() v3:
checked to retry on NOT_READY and UNIT_ATTENTION v2:
checked to retry on UNIT_ATTENTION in ses_recv_diag(); v1:
called scsi_test_unit_ready() to eat UA in ses_recv_diag()
Wen Xiong (1):
scsi/ses: Saw "Failed to get diagnostic page 0x1"
drivers/scsi/ses.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-)
Signature · 1 line
2.27.0
PATCH RESEND v4 1/1 scsi/ses: Saw "Failed to get diagnostic page 0x1"
From: Wen Xiong <[email protected]>
Setting scsi logging level with error=3, we saw some errors from enclosues:
[108017.360833] ses 0:0:9:0: tag#641 Done: NEEDS_RETRY Result: hostbyte=DID_ERROR driverbyte=DRIVER_OK cmd_age=0s [108017.360838] ses 0:0:9:0: tag#641 CDB: Receive Diagnostic 1c 01 01 00 20 00 [108017.427778] ses 0:0:9:0: Power-on or device reset occurred [108017.427784] ses 0:0:9:0: tag#641 Done: SUCCESS Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s [108017.427788] ses 0:0:9:0: tag#641 CDB: Receive Diagnostic 1c 01 01 00 20 00 [108017.427791] ses 0:0:9:0: tag#641 Sense Key : Unit Attention [current] [108017.427793] ses 0:0:9:0: tag#641 Add. Sense: Bus device reset function occurred [108017.427801] ses 0:0:9:0: Failed to get diagnostic page 0x1 [108017.427804] ses 0:0:9:0: Failed to bind enclosure -19 [108017.427895] ses 0:0:10:0: Attached Enclosure device [108017.427942] ses 0:0:10:0: Attached scsi generic sg18 type 13
As Martin's suggestion, the patch checks to retry on NOT_READY as well as UNIT_ATTENTION with ASC 0x29.
--- drivers/scsi/ses.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-)
drivers/scsi/ses.c +18 -4
@@ -87,9 +87,16 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code, 0 };unsigned char recv_page_code; +struct scsi_sense_hdr sshdr; +int retries =SES_RETRIES ; + +do { + ret =scsi_execute_req (sdev, cmd,DMA_FROM_DEVICE , buf, bufflen, + &sshdr,SES_TIMEOUT ,1 ,NULL ); + }while (ret >0 &&scsi_sense_valid (&sshdr) && --retries && + (sshdr.sense_key ==NOT_READY || + (sshdr.sense_key ==UNIT_ATTENTION && sshdr.asc ==0x29 ))); - ret =scsi_execute_req (sdev, cmd,DMA_FROM_DEVICE , buf, bufflen, -NULL ,SES_TIMEOUT ,SES_RETRIES ,NULL );if (unlikely (ret))return ret;
@@ -121,9 +128,16 @@ static int ses_send_diag(struct scsi_device *sdev, int page_code, bufflen &0xff , 0 }; +struct scsi_sense_hdr sshdr; +int retries =SES_RETRIES ; + +do { + result =scsi_execute_req (sdev, cmd,DMA_TO_DEVICE , buf, bufflen, + &sshdr,SES_TIMEOUT ,1 ,NULL ); + }while (result >0 &&scsi_sense_valid (&sshdr) && --retries && + (sshdr.sense_key ==NOT_READY || + (sshdr.sense_key ==UNIT_ATTENTION && sshdr.asc ==0x29 ))); - result =scsi_execute_req (sdev, cmd,DMA_TO_DEVICE , buf, bufflen, -NULL ,SES_TIMEOUT ,SES_RETRIES ,NULL );if (result)sdev_printk (KERN_ERR , sdev,"SEND DIAGNOSTIC result: %8x\n" , result);
Signature · 1 line
2.27.0
Martin K. Petersen
AppliedQuoted 11 lines · On Thu, 16 Sep 2021 22:24:20 -0500, [email protected] wrote:
From: Wen Xiong <[email protected]>
v4:
Add checking return value before callingscsi_sense_valid()v3:
checked to retry onNOT_READYandUNIT_ATTENTIONv2:
checked to retry onUNIT_ATTENTIONinses_recv_diag(); v1:
calledscsi_test_unit_ready()to eat UA inses_recv_diag()
Quoted 1 line
[...]
Applied to 5.15/scsi-fixes, thanks!
[1/1] scsi/ses: Saw "Failed to get diagnostic page 0x1"
https://git.kernel.org/mkp/scsi/c/fbdac19e6428
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering