Skip to contentSkip to conversation

clk: rockchip: add missing rk3288 npll rate table

PATCH New Heiko Stübner 4 participants 6 messages Sep 24, 2014 – Sep 25, 2014

Subsystems (2)
lore
Share & tools
lore

Heiko Stübner

author maintainer
#0 lore raw

PATCH 1/1 clk: rockchip: add missing rk3288 npll rate table

The npll on rk3288 is exactly the same pll type as the other 4. Yet it was missing the link to the rate table, making rate changes impossible. Change that by setting the table.

---
 drivers/clk/rockchip/clk-rk3288.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/rockchip/clk-rk3288.c +1 -1
index 8ea885b..938d30b 100644
@@ -143,7 +143,7 @@ static struct rockchip_pll_clock rk3288_pll_clks[] __initdata = {
 	[gpll] = PLL(pll_rk3066, PLL_GPLL, "gpll", mux_pll_p, 0, RK3288_PLL_CON(12),
 		     RK3288_MODE_CON, 12, 8, rk3288_pll_rates),
 	[npll] = PLL(pll_rk3066, PLL_NPLL, "npll",  mux_pll_p, 0, RK3288_PLL_CON(16),
-		     RK3288_MODE_CON, 14, 9, NULL),
+		     RK3288_MODE_CON, 14, 9, rk3288_pll_rates),
 };
 
 static struct clk_div_table div_hclk_cpu_t[] = {
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 clk: rockchip: add missing rk3288 npll rate table

Heiko,

Quoted 14 lines · Heiko St?bner

The npll on rk3288 is exactly the same pll type as the other 4. Yet it was missing the link to the rate table, making rate changes impossible. Change that by setting the table.

---
 drivers/clk/rockchip/clk-rk3288.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/rockchip/clk-rk3288.c +0 -0
index 8ea885b..938d30b 100644

drivers/clk/rockchip/clk-rk3288.c static struct rockchip_pll_clock rk3288_pll_clks[] __initdata = { · line 147

Quoted 6 lines
drivers/clk/rockchip/clk-rk3288.c +1 -1
@@ -143,7 +143,7 @@ static struct rockchip_pll_clock rk3288_pll_clks[] __initdata = {
        [gpll] = PLL(pll_rk3066, PLL_GPLL, "gpll", mux_pll_p, 0, RK3288_PLL_CON(12),
                     RK3288_MODE_CON, 12, 8, rk3288_pll_rates),
        [npll] = PLL(pll_rk3066, PLL_NPLL, "npll",  mux_pll_p, 0, RK3288_PLL_CON(16),
-                    RK3288_MODE_CON, 14, 9, NULL),
+                    RK3288_MODE_CON, 14, 9, rk3288_pll_rates),
 };

Works for me. Any reason not to add it to dpll, too?

-Doug

#2 lore raw

PATCH 1/1 clk: rockchip: add missing rk3288 npll rate table

Doug,

Quoted 12 lines · Doug Anderson

Heiko,

Quoted 9 lines · Heiko St?bner

The npll on rk3288 is exactly the same pll type as the other 4. Yet it was missing the link to the rate table, making rate changes impossible. Change that by setting the table.

---
  drivers/clk/rockchip/clk-rk3288.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

drivers/clk/rockchip/clk-rk3288.c static struct rockchip_pll_clock rk3288_pll_clks[] __initdata = { · line 147

Quoted 11 lines
drivers/clk/rockchip/clk-rk3288.c +1 -1
index 8ea885b..938d30b 100644
@@ -143,7 +143,7 @@ static struct rockchip_pll_clock rk3288_pll_clks[] __initdata = {
         [gpll] = PLL(pll_rk3066, PLL_GPLL, "gpll", mux_pll_p, 0, RK3288_PLL_CON(12),
                      RK3288_MODE_CON, 12, 8, rk3288_pll_rates),
         [npll] = PLL(pll_rk3066, PLL_NPLL, "npll",  mux_pll_p, 0, RK3288_PLL_CON(16),
-                    RK3288_MODE_CON, 14, 9, NULL),
+                    RK3288_MODE_CON, 14, 9, rk3288_pll_rates),
  };

Works for me. Any reason not to add it to dpll, too?

dpll is used for DDR controller only, I'm not sure memory scaling driver will use
the clock module API, because the code for memory scaling must moved to intmem
(dram is not available at that time), which need to be small enough, and it's not
possible to use the API from clock module.

So, I think it is no need to add the rate table to dpll.

-Kever

#3 lore raw

PATCH 1/1 clk: rockchip: add missing rk3288 npll rate table

Kever,

Quoted 44 lines · Kever Yang

Doug,

Quoted 23 lines · Doug Anderson

Heiko,

Quoted 19 lines · Heiko St?bner

The npll on rk3288 is exactly the same pll type as the other 4. Yet it was missing the link to the rate table, making rate changes impossible. Change that by setting the table.

---
  drivers/clk/rockchip/clk-rk3288.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/rockchip/clk-rk3288.c +0 -0
index 8ea885b..938d30b 100644
@@ -143,7 +143,7 @@ static struct rockchip_pll_clock rk3288_pll_clks[]
 __initdata = {
         [gpll] = PLL(pll_rk3066, PLL_GPLL, "gpll", mux_pll_p, 0,
 RK3288_PLL_CON(12),
Quoted 8 lines
Quoted 6 lines
drivers/clk/rockchip/clk-rk3288.c +1 -1
                      RK3288_MODE_CON, 12, 8, rk3288_pll_rates),
         [npll] = PLL(pll_rk3066, PLL_NPLL, "npll",  mux_pll_p, 0,
 RK3288_PLL_CON(16),
-                    RK3288_MODE_CON, 14, 9, NULL),
+                    RK3288_MODE_CON, 14, 9, rk3288_pll_rates),
  };

Works for me. Any reason not to add it to dpll, too?

dpll is used for DDR controller only, I'm not sure memory scaling driver will use
the clock module API, because the code for memory scaling must moved to intmem
(dram is not available at that time), which need to be small enough, and it's not
possible to use the API from clock module.

Quoted 1 line

So, I think it is no need to add the rate table to dpll.

Sure. It seems to me like it wouldn't hurt to have it listed, but you're right that it's probably impossible that it would ever be used so I won't push for it.

-Doug

#4 lore raw

PATCH 1/1 clk: rockchip: add missing rk3288 npll rate table

In reply to Heiko Stübner

Heiko,

Quoted 14 lines · Heiko St?bner

The npll on rk3288 is exactly the same pll type as the other 4. Yet it was missing the link to the rate table, making rate changes impossible. Change that by setting the table.

---
  drivers/clk/rockchip/clk-rk3288.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/rockchip/clk-rk3288.c +0 -0
index 8ea885b..938d30b 100644

drivers/clk/rockchip/clk-rk3288.c static struct rockchip_pll_clock rk3288_pll_clks[] __initdata = { · line 149

Quoted 8 lines
drivers/clk/rockchip/clk-rk3288.c +1 -1
@@ -143,7 +143,7 @@ static struct rockchip_pll_clock rk3288_pll_clks[] __initdata = {
  	[gpll] = PLL(pll_rk3066, PLL_GPLL, "gpll", mux_pll_p, 0, RK3288_PLL_CON(12),
  		     RK3288_MODE_CON, 12, 8, rk3288_pll_rates),
  	[npll] = PLL(pll_rk3066, PLL_NPLL, "npll",  mux_pll_p, 0, RK3288_PLL_CON(16),
-		     RK3288_MODE_CON, 14, 9, NULL),
+		     RK3288_MODE_CON, 14, 9, rk3288_pll_rates),
  };
 
  static struct clk_div_table div_hclk_cpu_t[] = {
#5 lore raw

PATCH 1/1 clk: rockchip: add missing rk3288 npll rate table

In reply to Heiko Stübner

Quoting Heiko St?bner (2014-09-24 14:41:54)

Quoted 5 lines

The npll on rk3288 is exactly the same pll type as the other 4. Yet it was missing the link to the rate table, making rate changes impossible. Change that by setting the table.

Applied.

Thanks,
Mike

Quoted 21 lines
---
 drivers/clk/rockchip/clk-rk3288.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/rockchip/clk-rk3288.c +1 -1
index 8ea885b..938d30b 100644
@@ -143,7 +143,7 @@ static struct rockchip_pll_clock rk3288_pll_clks[] __initdata = {
        [gpll] = PLL(pll_rk3066, PLL_GPLL, "gpll", mux_pll_p, 0, RK3288_PLL_CON(12),
                     RK3288_MODE_CON, 12, 8, rk3288_pll_rates),
        [npll] = PLL(pll_rk3066, PLL_NPLL, "npll",  mux_pll_p, 0, RK3288_PLL_CON(16),
-                    RK3288_MODE_CON, 14, 9, NULL),
+                    RK3288_MODE_CON, 14, 9, rk3288_pll_rates),
 };
 
 static struct clk_div_table div_hclk_cpu_t[] = {
Signature · 1 line
2.1.0