Add SA lifetime in security
cover Add SA lifetime in security
Add SA lifetime configuration in security. SA lifetime tracking can be offloaded on supported PMDs.
SA lifetime would cover soft & hard expiry in units of number of packets and bytes. When SA soft expiry happens, the packet is successfuly processed but with additional expiry notification. Crypto op structure, ``rte_crypto_op`` is updated to cover such notifications with lookaside protocol offloads.
SA hard expiration would cause IPsec processing to return an error.
PMDs crypto_cn10k and crypto_octeontx2 are updated with their respective lifetime tracking capabilities. Unit tests are added for soft and hard expiry with number of packets.
Depends on
1. http://patches.dpdk.org/project/dpdk/list/?series=18253
2. http://patches.dpdk.org/project/dpdk/list/?series=18292
Anoob Joseph (5):
security: add SA lifetime configuration common/cnxk: support lifetime configuration crypto/octeontx2: add checks for life configuration test/crypto: add packets soft expiry tests test/crypto: add packets hard expiry tests
app/test/test_cryptodev.c | 38 +++++++++++- app/test/test_cryptodev_security_ipsec.c | 40 +++++++++++-- app/test/test_cryptodev_security_ipsec.h | 5 +- .../test_cryptodev_security_ipsec_test_vectors.h | 3 - drivers/common/cnxk/cnxk_security.c | 70 ++++++++++++++++++++++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 48 +++++++++++---- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++ examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h | 2 +- lib/cryptodev/rte_crypto.h | 18 +++++- lib/security/rte_security.h | 28 ++++++++- 11 files changed, 233 insertions(+), 27 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/5 security: add SA lifetime configuration
Add SA lifetime configuration to register soft and hard expiry limits. Expiry can be in units of number of packets or bytes. Crypto op status is also updated to include new field, aux_flags, which can be used to indicate cases such as soft expiry in case of lookaside protocol operations.
In case of soft expiry, the packets are successfully IPsec processed but the soft expiry would indicate that SA needs to be reconfigured. For inline protocol capable ethdev, this would result in an eth event while for lookaside protocol capable cryptodev, this can be communicated via rte_crypto_op.aux_flags field.
In case of hard expiry, the packets will not be IPsec processed and would result in error.
--- .../test_cryptodev_security_ipsec_test_vectors.h | 3 --- examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h | 2 +- lib/cryptodev/rte_crypto.h | 18 +++++++++++++- lib/security/rte_security.h | 28 ++++++++++++++++++++-- 5 files changed, 45 insertions(+), 8 deletions(-)
app/test/test_cryptodev_security_ipsec_test_vectors.h +0 -3
@@ -98,7 +98,6 @@ struct ipsec_test_data pkt_aes_128_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
@@ -195,7 +194,6 @@ struct ipsec_test_data pkt_aes_192_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
@@ -295,7 +293,6 @@ struct ipsec_test_data pkt_aes_256_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
examples/ipsec-secgw/ipsec.c +1 -1
@@ -49,7 +49,7 @@ set_ipsec_conf(struct ipsec_sa *sa, struct rte_security_ipsec_xform *ipsec) }/* TODO support for Transport */ } - ipsec->esn_soft_limit =IPSEC_OFFLOAD_ESN_SOFTLIMIT ; + ipsec->life.packets_soft_limit =IPSEC_OFFLOAD_PKTS_SOFTLIMIT ; ipsec->replay_win_sz = app_sa_prm.window_size; ipsec->options.esn = app_sa_prm.enable_esn; ipsec->options.udp_encap = sa->udp_encap;
examples/ipsec-secgw/ipsec.h +1 -1
@@ -23,7 +23,7 @@#define MAX_DIGEST_SIZE 32/* Bytes -- 256 bits */ -#define IPSEC_OFFLOAD_ESN_SOFTLIMIT 0xffffff00 +#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ sizeof(struct rte_crypto_sym_op))
lib/cryptodev/rte_crypto.h +17 -1
@@ -66,6 +66,17 @@ enum rte_crypto_op_sess_type { };/** +* Auxiliary flags to indicate additional info from the operation +*/ + +/** +* Auxiliary flags related to IPsec offload with RTE_SECURITY +*/ + +#define RTE_CRYPTO_OP_AUX_FLAGS_IPSEC_SOFT_EXPIRY (1 << 0) +/**< SA soft expiry limit has been reached */ + +/** * Cryptographic Operation. * * This structure contains data relating to performing cryptographic
@@ -93,7 +104,12 @@ struct rte_crypto_op {*/ uint8_t sess_type;/**< operation session type */ -uint8_t reserved[3 ]; +uint8_t aux_flags; +/**< Operation specific auxiliary/additional flags. +* These flags carry additional information from the +* operation. Processing of the same is optional. +*/ +uint8_t reserved[2 ];/**< Reserved bytes to fill 64 bits for * future additions */
lib/security/rte_security.h +26 -2
@@ -206,6 +206,30 @@ enum rte_security_ipsec_sa_direction { };/** +* Configure soft and hard lifetime of an IPsec SA +* +* Lifetime of an IPsec SA would specify the maximum number of packets or bytes +* that can be processed. IPsec operations would start failing once any hard +* limit is reached. +* +* Soft limits can be specified to generate notification when the SA is +* approaching hard limits for lifetime. For inline operations, reaching soft +* expiry limit would result in raising an eth event for the same. For lookaside +* operations, this would result in a warning returned in +* ``rte_crypto_op.aux_flags``. +*/ +struct rte_security_ipsec_lifetime { +uint64_t packets_soft_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_soft_limit; +/**< Soft expiry limit in bytes */ +uint64_t packets_hard_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_hard_limit; +/**< Soft expiry limit in bytes */ +}; + +/** * IPsec security association configuration data. * * This structure contains data required to create an IPsec SA security session.
@@ -225,8 +249,8 @@ struct rte_security_ipsec_xform {/**< IPsec SA Mode - transport/tunnel */ struct rte_security_ipsec_tunnel_param tunnel;/**< Tunnel parameters, NULL for transport mode */ -uint64_t esn_soft_limit; -/**< ESN for which the overflow event need to be raised */ +struct rte_security_ipsec_lifetime life; +/**< IPsec SA lifetime */ uint32_t replay_win_sz;/**< Anti replay window size to enable sequence replay attack handling. * replay checking is disabled if the window size is 0.
Signature · 1 line
2.7.4
PATCH 2/5 common/cnxk: support lifetime configuration
In reply to Anoob JosephAdd support for SA lifetime configuration. Expiry can be either in units of octets or packets.
Also, updated cryptodev dequeue path to update crypto op result to indicate soft expiry.
--- drivers/common/cnxk/cnxk_security.c | 70 +++++++++++++++++++++++++++++++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 48 ++++++++++++++++----- 2 files changed, 107 insertions(+), 11 deletions(-)
drivers/common/cnxk/cnxk_security.c +70 -0
@@ -99,6 +99,26 @@ ot_ipsec_sa_common_param_fill(union roc_ot_ipsec_sa_word2 *w2,return -EINVAL ; } +if (ipsec_xfrm->life.packets_soft_limit !=0 || + ipsec_xfrm->life.packets_hard_limit !=0 ) { +if (ipsec_xfrm->life.bytes_soft_limit !=0 || + ipsec_xfrm->life.bytes_hard_limit !=0 ) { +plt_err ("Expiry tracking with both packets & bytes is not supported" ); +return -EINVAL ; + } + w2->s.life_unit =ROC_IE_OT_SA_LIFE_UNIT_PKTS ; + } + +if (ipsec_xfrm->life.bytes_soft_limit !=0 || + ipsec_xfrm->life.bytes_hard_limit !=0 ) { +if (ipsec_xfrm->life.packets_soft_limit !=0 || + ipsec_xfrm->life.packets_hard_limit !=0 ) { +plt_err ("Expiry tracking with both packets & bytes is not supported" ); +return -EINVAL ; + } + w2->s.life_unit =ROC_IE_OT_SA_LIFE_UNIT_OCTETS ; + } +return 0 ; }
@@ -173,6 +193,31 @@ cnxk_ot_ipsec_inb_sa_fill(struct roc_ot_ipsec_inb_sa *sa, ROC_CTX_UNIT_128B) -1 ; +/** +* CPT MC triggers expiry when counter value changes from 2 to 1. To +* mitigate this behaviour add 1 to the life counter values provided. +*/ + +if (ipsec_xfrm->life.bytes_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.bytes_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.packets_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.bytes_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.bytes_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.packets_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } +/* There are two words of CPT_CTX_HW_S for ucode to skip */ sa->w0.s.ctx_hdr_size =1 ; sa->w0.s.aop_valid =1 ;
@@ -296,6 +341,31 @@ cnxk_ot_ipsec_outb_sa_fill(struct roc_ot_ipsec_outb_sa *sa,/* IPID gen */ sa->w2.s.ipid_gen =1 ; +/** +* CPT MC triggers expiry when counter value changes from 2 to 1. To +* mitigate this behaviour add 1 to the life counter values provided. +*/ + +if (ipsec_xfrm->life.bytes_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.bytes_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.packets_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.bytes_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.bytes_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.packets_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } +/* There are two words of CPT_CTX_HW_S for ucode to skip */ sa->w0.s.ctx_hdr_size =1 ; sa->w0.s.aop_valid =1 ;
drivers/crypto/cnxk/cn10k_cryptodev_ops.c +37 -11
69 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH 3/5 crypto/octeontx2: add checks for life configuration
In reply to Anoob JosephLifetime tracking is not supported by hardware and is not implemented in software either. Return failure when lifetime is configured.
--- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/crypto/octeontx2/otx2_ipsec_po.h +6 -0
@@ -293,6 +293,12 @@ ipsec_po_xform_verify(struct rte_security_ipsec_xform *ipsec,struct rte_crypto_sym_xform *auth_xform, *cipher_xform;int ret; +if (ipsec->life.bytes_hard_limit !=0 || + ipsec->life.bytes_soft_limit !=0 || + ipsec->life.packets_hard_limit !=0 || + ipsec->life.packets_soft_limit !=0 ) +return -ENOTSUP ; +if (xform->type ==RTE_CRYPTO_SYM_XFORM_AEAD )return ipsec_po_xform_aead_verify (ipsec, xform);
Signature · 1 line
2.7.4
PATCH 4/5 test/crypto: add packets soft expiry tests
In reply to Anoob JosephAdd tests to validate packets soft expiry handling.
--- app/test/test_cryptodev.c | 21 +++++++++++++++++++-- app/test/test_cryptodev_security_ipsec.c | 18 ++++++++++++++++-- app/test/test_cryptodev_security_ipsec.h | 4 +++- 3 files changed, 38 insertions(+), 5 deletions(-)
app/test/test_cryptodev.c +19 -2
@@ -8994,7 +8994,7 @@ test_ipsec_proto_process(const struct ipsec_test_data td[],/* Process crypto operation */ process_crypto_request (dev_id, ut_params->op); - ret =test_ipsec_status_check (ut_params->op, flags, dir); + ret =test_ipsec_status_check (ut_params->op, flags, dir, i +1 );if (ret !=TEST_SUCCESS ) goto crypto_op_free;
@@ -9064,7 +9064,8 @@ test_ipsec_proto_all(const struct ipsec_test_flags *flags)unsigned int i, nb_pkts =1 , pass_cnt =0 ;int ret; -if (flags->iv_gen) +if (flags->iv_gen || + flags->sa_expiry_pkts_soft) nb_pkts =IPSEC_TEST_PACKETS_MAX ;for (i =0 ; i <RTE_DIM (aead_list); i++) {
@@ -9129,6 +9130,18 @@ test_ipsec_proto_iv_gen(const void *data __rte_unused) }static int +test_ipsec_proto_sa_exp_pkts_soft(const void *data __rte_unused) +{ +struct ipsec_test_flags flags; + +memset (&flags,0 ,sizeof (flags)); + + flags.sa_expiry_pkts_soft = true; + +return test_ipsec_proto_all (&flags); +} + +static int test_ipsec_proto_err_icv_corrupt(const void *data __rte_unused) {struct ipsec_test_flags flags;
@@ -14067,6 +14080,10 @@ static struct unit_test_suite ipsec_proto_testsuite = { ut_setup_security, ut_teardown, test_ipsec_proto_iv_gen),TEST_CASE_NAMED_ST ( +"SA expiry packets soft" , + ut_setup_security, ut_teardown, + test_ipsec_proto_sa_exp_pkts_soft), +TEST_CASE_NAMED_ST ("Negative test: ICV corruption" , ut_setup_security, ut_teardown, test_ipsec_proto_err_icv_corrupt),
app/test/test_cryptodev_security_ipsec.c +16 -2
@@ -172,6 +172,10 @@ test_ipsec_td_prepare(const struct crypto_param *param1,if (flags->iv_gen) td->ipsec_xform.options.iv_gen_disable =0 ; + +if (flags->sa_expiry_pkts_soft) + td->ipsec_xform.life.packets_soft_limit = +IPSEC_TEST_PACKETS_MAX -1 ; }RTE_SET_USED (param2);
@@ -367,7 +371,8 @@ test_ipsec_post_process(struct rte_mbuf *m, const struct ipsec_test_data *td,int test_ipsec_status_check (struct rte_crypto_op *op,const struct ipsec_test_flags *flags, -enum rte_security_ipsec_sa_direction dir) +enum rte_security_ipsec_sa_direction dir, +int pkt_num) {int ret =TEST_SUCCESS ;
@@ -378,7 +383,16 @@ test_ipsec_status_check(struct rte_crypto_op *op, } }else {if (op->status !=RTE_CRYPTO_OP_STATUS_SUCCESS ) { -printf ("Security op processing failed\n" ); +printf ("Security op processing failed [pkt_num: %d]\n" , + pkt_num); + ret =TEST_FAILED ; + } + } + +if (flags->sa_expiry_pkts_soft && pkt_num ==IPSEC_TEST_PACKETS_MAX ) { +if (!(op->aux_flags & +RTE_CRYPTO_OP_AUX_FLAGS_IPSEC_SOFT_EXPIRY )) { +printf ("SA soft expiry (pkts) test failed\n" ); ret =TEST_FAILED ; } }
app/test/test_cryptodev_security_ipsec.h +3 -1
@@ -49,6 +49,7 @@ struct ipsec_test_data {struct ipsec_test_flags {bool display_alg; +bool sa_expiry_pkts_soft;bool icv_corrupt;bool iv_gen; };
@@ -113,6 +114,7 @@ int test_ipsec_post_process(struct rte_mbuf *m,int test_ipsec_status_check (struct rte_crypto_op *op,const struct ipsec_test_flags *flags, -enum rte_security_ipsec_sa_direction dir); +enum rte_security_ipsec_sa_direction dir, +int pkt_num);#endif
Signature · 1 line
2.7.4
PATCH 5/5 test/crypto: add packets hard expiry tests
In reply to Anoob JosephAdd tests to validate packets hard expiry handling.
--- app/test/test_cryptodev.c | 19 ++++++++++++++++++- app/test/test_cryptodev_security_ipsec.c | 22 +++++++++++++++++++--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 38 insertions(+), 4 deletions(-)
app/test/test_cryptodev.c +18 -1
@@ -9065,7 +9065,8 @@ test_ipsec_proto_all(const struct ipsec_test_flags *flags)int ret;if (flags->iv_gen || - flags->sa_expiry_pkts_soft) + flags->sa_expiry_pkts_soft || + flags->sa_expiry_pkts_hard) nb_pkts =IPSEC_TEST_PACKETS_MAX ;for (i =0 ; i <RTE_DIM (aead_list); i++) {
@@ -9142,6 +9143,18 @@ test_ipsec_proto_sa_exp_pkts_soft(const void *data __rte_unused) }static int +test_ipsec_proto_sa_exp_pkts_hard(const void *data __rte_unused) +{ +struct ipsec_test_flags flags; + +memset (&flags,0 ,sizeof (flags)); + + flags.sa_expiry_pkts_hard = true; + +return test_ipsec_proto_all (&flags); +} + +static int test_ipsec_proto_err_icv_corrupt(const void *data __rte_unused) {struct ipsec_test_flags flags;
@@ -14084,6 +14097,10 @@ static struct unit_test_suite ipsec_proto_testsuite = { ut_setup_security, ut_teardown, test_ipsec_proto_sa_exp_pkts_soft),TEST_CASE_NAMED_ST ( +"SA expiry packets hard" , + ut_setup_security, ut_teardown, + test_ipsec_proto_sa_exp_pkts_hard), +TEST_CASE_NAMED_ST ("Negative test: ICV corruption" , ut_setup_security, ut_teardown, test_ipsec_proto_err_icv_corrupt),
app/test/test_cryptodev_security_ipsec.c +19 -3
@@ -199,6 +199,10 @@ test_ipsec_td_update(struct ipsec_test_data td_inb[], td_inb[i].input_text.data[icv_pos] +=1 ; } +if (flags->sa_expiry_pkts_hard) + td_inb[i].ipsec_xform.life.packets_hard_limit = +IPSEC_TEST_PACKETS_MAX -1 ; +/* Clear outbound specific flags */ td_inb[i].ipsec_xform.options.iv_gen_disable =0 ; }
@@ -281,9 +285,10 @@ test_ipsec_td_verify(struct rte_mbuf *m, const struct ipsec_test_data *td, uint8_t *output_text = rte_pktmbuf_mtod(m, uint8_t *);uint32_t skip, len =rte_pktmbuf_pkt_len (m); -/* For negative tests, no need to do verification */ -if (flags->icv_corrupt && - td->ipsec_xform.direction ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS ) +/* For tests with status as error for test success, skip verification */ +if (td->ipsec_xform.direction ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && + (flags->icv_corrupt || + flags->sa_expiry_pkts_hard))return TEST_SUCCESS ;if (len != td->output_text.len) {
@@ -376,6 +381,17 @@ test_ipsec_status_check(struct rte_crypto_op *op, {int ret =TEST_SUCCESS ; +if (dir ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && + flags->sa_expiry_pkts_hard && + pkt_num ==IPSEC_TEST_PACKETS_MAX ) { +if (op->status !=RTE_CRYPTO_OP_STATUS_ERROR ) { +printf ("SA hard expiry (pkts) test failed\n" ); +return TEST_FAILED ; + }else { +return TEST_SUCCESS ; + } + } +if (dir ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && flags->icv_corrupt) {if (op->status !=RTE_CRYPTO_OP_STATUS_ERROR ) {printf ("ICV corruption test case failed\n" );
app/test/test_cryptodev_security_ipsec.h +1 -0
@@ -50,6 +50,7 @@ struct ipsec_test_data {struct ipsec_test_flags {bool display_alg;bool sa_expiry_pkts_soft; +bool sa_expiry_pkts_hard;bool icv_corrupt;bool iv_gen; };
Signature · 1 line
2.7.4
v2 cover Add SA lifetime in security
In reply to Anoob JosephAdd SA lifetime configuration in security. SA lifetime tracking can be offloaded on supported PMDs.
SA lifetime would cover soft & hard expiry in units of number of packets and bytes. When SA soft expiry happens, the packet is successfuly processed but with additional expiry notification. Crypto op structure, ``rte_crypto_op`` is updated to cover such notifications with lookaside protocol offloads.
SA hard expiration would cause IPsec processing to return an error.
PMDs crypto_cn10k, crypto_cn9k and crypto_octeontx2 are updated with their respective lifetime tracking capabilities. Unit tests are added for soft and hard expiry with number of packets.
Depends on
1. http://patches.dpdk.org/project/dpdk/list/?series=18642
2. http://patches.dpdk.org/project/dpdk/list/?series=18742
Changes in v2:
- Clear soft expiry configuration in ipsec-secgw
- Rebased on v3 of dependent series
- Updated release notes & deprecation notice
Anoob Joseph (6):
security: add SA lifetime configuration common/cnxk: support lifetime configuration crypto/octeontx2: add checks for life configuration test/crypto: add packets soft expiry tests test/crypto: add packets hard expiry tests examples/ipsec-secgw: clear soft expiry configuration
app/test/test_cryptodev.c | 38 +++++++++++- app/test/test_cryptodev_security_ipsec.c | 40 +++++++++++-- app/test/test_cryptodev_security_ipsec.h | 5 +- .../test_cryptodev_security_ipsec_test_vectors.h | 3 - doc/guides/rel_notes/deprecation.rst | 5 -- doc/guides/rel_notes/release_21_11.rst | 13 ++++ drivers/common/cnxk/cnxk_security.c | 70 ++++++++++++++++++++++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 48 +++++++++++---- drivers/crypto/cnxk/cn9k_ipsec.c | 6 +- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++ examples/ipsec-secgw/ipsec.c | 5 +- examples/ipsec-secgw/ipsec.h | 2 - lib/cryptodev/rte_crypto.h | 18 +++++- lib/security/rte_security.h | 28 ++++++++- 14 files changed, 253 insertions(+), 34 deletions(-)
Signature · 1 line
2.7.4
PATCH v2 1/6 security: add SA lifetime configuration
Add SA lifetime configuration to register soft and hard expiry limits. Expiry can be in units of number of packets or bytes. Crypto op status is also updated to include new field, aux_flags, which can be used to indicate cases such as soft expiry in case of lookaside protocol operations.
In case of soft expiry, the packets are successfully IPsec processed but the soft expiry would indicate that SA needs to be reconfigured. For inline protocol capable ethdev, this would result in an eth event while for lookaside protocol capable cryptodev, this can be communicated via rte_crypto_op.aux_flags field.
In case of hard expiry, the packets will not be IPsec processed and would result in error.
--- .../test_cryptodev_security_ipsec_test_vectors.h | 3 --- doc/guides/rel_notes/deprecation.rst | 5 ---- doc/guides/rel_notes/release_21_11.rst | 13 ++++++++++ examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h | 2 +- lib/cryptodev/rte_crypto.h | 18 +++++++++++++- lib/security/rte_security.h | 28 ++++++++++++++++++++-- 7 files changed, 58 insertions(+), 13 deletions(-)
app/test/test_cryptodev_security_ipsec_test_vectors.h +0 -3
@@ -98,7 +98,6 @@ struct ipsec_test_data pkt_aes_128_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
@@ -195,7 +194,6 @@ struct ipsec_test_data pkt_aes_192_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
@@ -295,7 +293,6 @@ struct ipsec_test_data pkt_aes_256_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
doc/guides/rel_notes/deprecation.rst +0 -5
@@ -282,8 +282,3 @@ Deprecation Notices * security: The functions ``rte_security_set_pkt_metadata`` and ``rte_security_get_userdata`` will be made inline functions and additional flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. - -* cryptodev: The structure ``rte_crypto_op`` would be updated to reduce - reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other - information from the crypto/security operation. This field will be used to - communicate events such as soft expiry with IPsec in lookaside mode.
doc/guides/rel_notes/release_21_11.rst +13 -0
@@ -102,6 +102,13 @@ API Changes Also, make sure to start the actual text at the margin. ======================================================= +* cryptodev: use 1 reserved byte from ``rte_crypto_op`` for aux flags + + * Updated the structure ``rte_crypto_op`` to reduce reserved bytes to + 2 (from 3), and use 1 byte to indicate warnings and other information from + the crypto/security operation. This field will be used to communicate events + such as soft expiry with IPsec in lookaside mode. + ABI Changes -----------
@@ -123,6 +130,12 @@ ABI Changes * Added IPsec SA option to disable IV generation to allow known vector tests as well as usage of application provided IV on supported PMDs. +* security: add IPsec SA lifetime configuration + + * Added IPsec SA lifetime configuration to allow applications to configure + soft and hard SA expiry limits. Limits can be either in units of packets or + bytes. + Known Issues ------------
examples/ipsec-secgw/ipsec.c +1 -1
@@ -49,7 +49,7 @@ set_ipsec_conf(struct ipsec_sa *sa, struct rte_security_ipsec_xform *ipsec) }/* TODO support for Transport */ } - ipsec->esn_soft_limit =IPSEC_OFFLOAD_ESN_SOFTLIMIT ; + ipsec->life.packets_soft_limit =IPSEC_OFFLOAD_PKTS_SOFTLIMIT ; ipsec->replay_win_sz = app_sa_prm.window_size; ipsec->options.esn = app_sa_prm.enable_esn; ipsec->options.udp_encap = sa->udp_encap;
examples/ipsec-secgw/ipsec.h +1 -1
@@ -23,7 +23,7 @@#define MAX_DIGEST_SIZE 32/* Bytes -- 256 bits */ -#define IPSEC_OFFLOAD_ESN_SOFTLIMIT 0xffffff00 +#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ sizeof(struct rte_crypto_sym_op))
lib/cryptodev/rte_crypto.h +17 -1
@@ -66,6 +66,17 @@ enum rte_crypto_op_sess_type { };/** +* Auxiliary flags to indicate additional info from the operation +*/ + +/** +* Auxiliary flags related to IPsec offload with RTE_SECURITY +*/ + +#define RTE_CRYPTO_OP_AUX_FLAGS_IPSEC_SOFT_EXPIRY (1 << 0) +/**< SA soft expiry limit has been reached */ + +/** * Cryptographic Operation. * * This structure contains data relating to performing cryptographic
@@ -93,7 +104,12 @@ struct rte_crypto_op {*/ uint8_t sess_type;/**< operation session type */ -uint8_t reserved[3 ]; +uint8_t aux_flags; +/**< Operation specific auxiliary/additional flags. +* These flags carry additional information from the +* operation. Processing of the same is optional. +*/ +uint8_t reserved[2 ];/**< Reserved bytes to fill 64 bits for * future additions */
lib/security/rte_security.h +26 -2
@@ -206,6 +206,30 @@ enum rte_security_ipsec_sa_direction { };/** +* Configure soft and hard lifetime of an IPsec SA +* +* Lifetime of an IPsec SA would specify the maximum number of packets or bytes +* that can be processed. IPsec operations would start failing once any hard +* limit is reached. +* +* Soft limits can be specified to generate notification when the SA is +* approaching hard limits for lifetime. For inline operations, reaching soft +* expiry limit would result in raising an eth event for the same. For lookaside +* operations, this would result in a warning returned in +* ``rte_crypto_op.aux_flags``. +*/ +struct rte_security_ipsec_lifetime { +uint64_t packets_soft_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_soft_limit; +/**< Soft expiry limit in bytes */ +uint64_t packets_hard_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_hard_limit; +/**< Soft expiry limit in bytes */ +}; + +/** * IPsec security association configuration data. * * This structure contains data required to create an IPsec SA security session.
@@ -225,8 +249,8 @@ struct rte_security_ipsec_xform {/**< IPsec SA Mode - transport/tunnel */ struct rte_security_ipsec_tunnel_param tunnel;/**< Tunnel parameters, NULL for transport mode */ -uint64_t esn_soft_limit; -/**< ESN for which the overflow event need to be raised */ +struct rte_security_ipsec_lifetime life; +/**< IPsec SA lifetime */ uint32_t replay_win_sz;/**< Anti replay window size to enable sequence replay attack handling. * replay checking is disabled if the window size is 0.
Signature · 1 line
2.7.4
Re: [dpdk-dev] [PATCH v2 1/6] security: add SA lifetime configuration
Quoted 130 lines
Add SA lifetime configuration to register soft and hard expiry limits. Expiry can be in units of number of packets or bytes. Crypto op status is also updated to include new field,
aux_flags, which can be used to indicate cases such as soft expiry in case of lookaside protocol operations.In case of soft expiry, the packets are successfully IPsec processed but the soft expiry would indicate that SA needs to be reconfigured. For inline protocol capable ethdev, this would result in an eth event while for lookaside protocol capable cryptodev, this can be communicated via
rte_crypto_op.aux_flagsfield.In case of hard expiry, the packets will not be IPsec processed and would result in error.
Signed-off-by Anoob Joseph <[email protected]>--- .../test_cryptodev_security_ipsec_test_vectors.h | 3 --- doc/guides/rel_notes/deprecation.rst | 5 ---- doc/guides/rel_notes/release_21_11.rst | 13 ++++++++++ examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h | 2 +- lib/cryptodev/rte_crypto.h | 18 +++++++++++++- lib/security/rte_security.h | 28 ++++++++++++++++++++-- 7 files changed, 58 insertions(+), 13 deletions(-)app/test/test_cryptodev_security_ipsec_test_vectors.h +0
-3@@ -98,7 +98,6 @@ struct ipsec_test_data pkt_aes_128_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },@@ -195,7 +194,6 @@ struct ipsec_test_data pkt_aes_192_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },@@ -295,7 +293,6 @@ struct ipsec_test_data pkt_aes_256_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },doc/guides/rel_notes/deprecation.rst +0
-5@@ -282,8 +282,3 @@ Deprecation Notices * security: The functions ``rte_security_set_pkt_metadata`` and ``rte_security_get_userdata`` will be made inline functions and additional flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. - -* cryptodev: The structure ``rte_crypto_op`` would be updated to reduce - reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other - information from the crypto/security operation. This field will be used to - communicate events such as soft expiry with IPsec in lookaside mode.doc/guides/rel_notes/release_21_11.rst +13
-0@@ -102,6 +102,13 @@ API Changes Also, make sure to start the actual text at the margin. ======================================================= +* cryptodev: use 1 reserved byte from ``rte_crypto_op`` for aux flags + + * Updated the structure ``rte_crypto_op`` to reduce reserved bytes to + 2 (from 3), and use 1 byte to indicate warnings and other information from + the crypto/security operation. This field will be used to communicate events + such as soft expiry with IPsec in lookaside mode. + ABI Changes -----------@@ -123,6 +130,12 @@ ABI Changes * Added IPsec SA option to disable IV generation to allow known vector tests as well as usage of application provided IV on supported PMDs. +* security: add IPsec SA lifetime configuration + + * Added IPsec SA lifetime configuration to allow applications to configure + soft and hard SA expiry limits. Limits can be either in units of packets or + bytes. + Known Issues ------------examples/ipsec-secgw/ipsec.c +1
-1@@ -49,7 +49,7 @@ set_ipsec_conf(struct ipsec_sa *sa, struct rte_security_ipsec_xform *ipsec) }/* TODO support for Transport */ } - ipsec->esn_soft_limit =IPSEC_OFFLOAD_ESN_SOFTLIMIT ; + ipsec->life.packets_soft_limit =IPSEC_OFFLOAD_PKTS_SOFTLIMIT ; ipsec->replay_win_sz = app_sa_prm.window_size; ipsec->options.esn = app_sa_prm.enable_esn; ipsec->options.udp_encap = sa->udp_encap;examples/ipsec-secgw/ipsec.h +1
-1@@ -23,7 +23,7 @@#define MAX_DIGEST_SIZE 32/* Bytes -- 256 bits */ -#define IPSEC_OFFLOAD_ESN_SOFTLIMIT 0xffffff00 +#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ sizeof(struct rte_crypto_sym_op))lib/cryptodev/rte_crypto.h +0
-0
lib/cryptodev/rte_crypto.h enum rte_crypto_op_sess_type { · line 74
Quoted 9 lines
lib/cryptodev/rte_crypto.h +6
-0@@ -66,6 +66,17 @@ enum rte_crypto_op_sess_type { };/** +* Auxiliary flags to indicate additional info from the operation +*/ + +/** +* Auxiliary flags related to IPsec offload with RTE_SECURITY +*/
Duplicate comments.
Quoted 59 lines
lib/cryptodev/rte_crypto.h +11
-1+ +#define RTE_CRYPTO_OP_AUX_FLAGS_IPSEC_SOFT_EXPIRY (1 << 0) +/**< SA soft expiry limit has been reached */ + +/** * Cryptographic Operation. * * This structure contains data relating to performing cryptographic @@ -93,7 +104,12 @@ struct rte_crypto_op {*/ uint8_t sess_type;/**< operation session type */ -uint8_t reserved[3 ]; +uint8_t aux_flags; +/**< Operation specific auxiliary/additional flags. +* These flags carry additional information from the +* operation. Processing of the same is optional. +*/ +uint8_t reserved[2 ];/**< Reserved bytes to fill 64 bits for * future additions */ lib/security/rte_security.h +24
-0@@ -206,6 +206,30 @@ enum rte_security_ipsec_sa_direction { };/** +* Configure soft and hard lifetime of an IPsec SA +* +* Lifetime of an IPsec SA would specify the maximum number of packets or bytes +* that can be processed. IPsec operations would start failing once any hard +* limit is reached. +* +* Soft limits can be specified to generate notification when the SA is +* approaching hard limits for lifetime. For inline operations, reaching soft +* expiry limit would result in raising an eth event for the same. For lookaside +* operations, this would result in a warning returned in +* ``rte_crypto_op.aux_flags``. +*/ +struct rte_security_ipsec_lifetime { +uint64_t packets_soft_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_soft_limit; +/**< Soft expiry limit in bytes */ +uint64_t packets_hard_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_hard_limit; +/**< Soft expiry limit in bytes */ +}; + +/** * IPsec security association configuration data. * * This structure contains data required to create an IPsec SA security session. @@ -225,8 +249,8 @@ struct rte_security_ipsec_xform {/**< IPsec SA Mode - transport/tunnel */
lib/security/rte_security.h struct rte_security_ipsec_xform {
Quoted 10 lines
lib/security/rte_security.h +2
-3struct rte_security_ipsec_tunnel_param tunnel;/**< Tunnel parameters, NULL for transport mode */ -uint64_t esn_soft_limit; -/**< ESN for which the overflow event need to be raised */ +struct rte_security_ipsec_lifetime life; +/**< IPsec SA lifetime */ uint32_t replay_win_sz;/**< Anti replay window size to enable sequence replay attack handling. * replay checking is disabled if the window size is 0. --
Quoted 1 line
2.7.4
Re: [dpdk-dev] [PATCH v2 1/6] security: add SA lifetime configuration
Hi Konstantin,
Please see inline.
Thanks,
Anoob
Quoted 156 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Thursday, September 16, 2021 4:36 PM
To: Anoob Joseph <[email protected]>; Akhil Goyal <[email protected]>; Doherty, Declan <[email protected]>; Zhang, Roy Fan <[email protected]>
Cc: Jerin Jacob Kollanukkaran <[email protected]>; Archana Muniganti <[email protected]>; Tejasree Kondoj <[email protected]>; Hemant Agrawal <[email protected]>; Nicolau, Radu <[email protected]>; Power, Ciara <[email protected]>; Gagandeep Singh <[email protected]>; [email protected]
Subject: [EXT] RE: [PATCH v2 1/6] security: add SA lifetime configurationExternal Email
----------------------------------------------------------------------
Quoted 78 lines
Add SA lifetime configuration to register soft and hard expiry limits. Expiry can be in units of number of packets or bytes. Crypto op status is also updated to include new field,
aux_flags, which can be used to indicate cases such as soft expiry in case of lookaside protocol operations.In case of soft expiry, the packets are successfully IPsec processed but the soft expiry would indicate that SA needs to be reconfigured. For inline protocol capable ethdev, this would result in an eth event while for lookaside protocol capable cryptodev, this can be communicated via
rte_crypto_op.aux_flagsfield.In case of hard expiry, the packets will not be IPsec processed and would result in error.
Signed-off-by Anoob Joseph <[email protected]>--- .../test_cryptodev_security_ipsec_test_vectors.h | 3 --- doc/guides/rel_notes/deprecation.rst | 5 ---- doc/guides/rel_notes/release_21_11.rst | 13 ++++++++++ examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h | 2 +- lib/cryptodev/rte_crypto.h | 18 +++++++++++++- lib/security/rte_security.h | 28 ++++++++++++++++++++-- 7 files changed, 58 insertions(+), 13 deletions(-)app/test/test_cryptodev_security_ipsec_test_vectors.h +0
-3@@ -98,7 +98,6 @@ struct ipsec_test_data pkt_aes_128_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },@@ -195,7 +194,6 @@ struct ipsec_test_data pkt_aes_192_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },@@ -295,7 +293,6 @@ struct ipsec_test_data pkt_aes_256_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },doc/guides/rel_notes/deprecation.rst +0
-2@@ -282,8 +282,3 @@ Deprecation Notices * security: The functions ``rte_security_set_pkt_metadata`` and ``rte_security_get_userdata`` will be made inline functions and additional flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. - -* cryptodev: The structure ``rte_crypto_op`` would be updated toreduce
- reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other
- information from thecrypto/securityoperation. This field will be used todoc/guides/rel_notes/deprecation.rst +0
-1- communicate events such as soft expiry with IPsec in lookaside mode.doc/guides/rel_notes/release_21_11.rst +0
-0doc/guides/rel_notes/release_21_11.rst API Changes · line 111
Quoted 10 lines
doc/guides/rel_notes/release_21_11.rst +7
-0@@ -102,6 +102,13 @@ API Changes Also, make sure to start the actual text at the margin. ======================================================= +* cryptodev: use 1 reserved byte from ``rte_crypto_op`` for aux flags + + * Updated the structure ``rte_crypto_op`` to reduce reserved bytes + to + 2 (from 3), and use 1 byte to indicate warnings and other + information from the crypto/security operation. This field will be + used to communicate events such as soft expiry with IPsec in lookasidemode.
examples/ipsec-secgw/ipsec.c set_ipsec_conf(struct ipsec_sa *sa, struct
Quoted 22 lines
doc/guides/rel_notes/release_21_11.rst +7
-0+ ABI Changes -----------@@ -123,6 +130,12 @@ ABI Changes * Added IPsec SA option to disable IV generation to allow known vector tests as well as usage of application provided IV on supported PMDs. +* security: add IPsec SA lifetime configuration + + * Added IPsec SA lifetime configuration to allow applications to configure + soft and hard SA expiry limits. Limits can be either in units of packets or + bytes. + Known Issues ------------(quoted diff) +0
-0
b/examples/ipsec-secgw/ipsec.cindex 5b032fe..4868294 100644examples/ipsec-secgw/ipsec.c +0
-0@@ -49,7 +49,7 @@ set_ipsec_conf(struct ipsec_sa *sa, struct
rte_security_ipsec_xform*ipsec)Quoted 27 lines
examples/ipsec-secgw/ipsec.c +1
-1}/* TODO support for Transport */ } - ipsec->esn_soft_limit =IPSEC_OFFLOAD_ESN_SOFTLIMIT ; + ipsec->life.packets_soft_limit =IPSEC_OFFLOAD_PKTS_SOFTLIMIT ; ipsec->replay_win_sz = app_sa_prm.window_size; ipsec->options.esn = app_sa_prm.enable_esn; ipsec->options.udp_encap = sa->udp_encap; diff --git
a/examples/ipsec-secgw/ipsec.hb/examples/ipsec-secgw/ipsec.hindex ae5058d..90c81c1 100644examples/ipsec-secgw/ipsec.h +1
-1@@ -23,7 +23,7 @@#define MAX_DIGEST_SIZE 32/* Bytes -- 256 bits */ -#define IPSEC_OFFLOAD_ESN_SOFTLIMIT 0xffffff00 +#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ sizeof(struct rte_crypto_sym_op)) diff --git
a/lib/cryptodev/rte_crypto.hb/lib/cryptodev/rte_crypto.hindex fd5ef3a..d602183 100644lib/cryptodev/rte_crypto.h +0
-0@@ -66,6 +66,17 @@ enum rte_crypto_op_sess_type { };
Quoted 7 lines
lib/cryptodev/rte_crypto.h enum rte_crypto_op_sess_type {
Quoted 5 lines
lib/cryptodev/rte_crypto.h +4
-0/** +* Auxiliary flags to indicate additional info from the operation */ + +/** +* Auxiliary flags related to IPsec offload with RTE_SECURITY */ Duplicate comments.
[Anoob] The proposal is to make auxiliary flags custom to operation. Like, flags related to IPsec offload may not be applicable for PDCP offload (and vice versa). But then, I agree these could be updated as we add new fields related to other kinds of operations. I'll drop the extra comments in the next version.
Quoted 81 lines
lib/cryptodev/rte_crypto.h enum rte_crypto_op_sess_type { }; · line 73
Quoted 3 lines
lib/cryptodev/rte_crypto.h +2
-0+ +#define RTE_CRYPTO_OP_AUX_FLAGS_IPSEC_SOFT_EXPIRY (1 << 0)/**< SA
Quoted 49 lines
lib/cryptodev/rte_crypto.h +9
-1+soft expiry limit has been reached */ + +/** * Cryptographic Operation. * * This structure contains data relating to performing cryptographic @@ -93,7 +104,12 @@ struct rte_crypto_op {*/ uint8_t sess_type;/**< operation session type */ -uint8_t reserved[3 ]; +uint8_t aux_flags; +/**< Operation specific auxiliary/additional flags. +* These flags carry additional information from the +* operation. Processing of the same is optional. +*/ +uint8_t reserved[2 ];/**< Reserved bytes to fill 64 bits for * future additions */ lib/security/rte_security.h +22
-0@@ -206,6 +206,30 @@ enum rte_security_ipsec_sa_direction { };/** +* Configure soft and hard lifetime of an IPsec SA +* +* Lifetime of an IPsec SA would specify the maximum number of +packets or bytes +* that can be processed. IPsec operations would start failing once +any hard +* limit is reached. +* +* Soft limits can be specified to generate notification when the SA +is +* approaching hard limits for lifetime. For inline operations, +reaching soft +* expiry limit would result in raising an eth event for the same. +For lookaside +* operations, this would result in a warning returned in +* ``rte_crypto_op.aux_flags``. +*/ +struct rte_security_ipsec_lifetime { +uint64_t packets_soft_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_soft_limit; +/**< Soft expiry limit in bytes */ lib/security/rte_security.h enum rte_security_ipsec_sa_direction { };
Quoted 10 lines
lib/security/rte_security.h +7
-0+uint64_t packets_hard_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_hard_limit; +/**< Soft expiry limit in bytes */ +}; + +/** * IPsec security association configuration data. * * This structure contains data required to create an IPsec SA security session.
lib/security/rte_security.h struct rte_security_ipsec_xform { · line 255
Quoted 10 lines
lib/security/rte_security.h +2
-2@@ -225,8 +249,8 @@ struct rte_security_ipsec_xform {/**< IPsec SA Mode - transport/tunnel */ struct rte_security_ipsec_tunnel_param tunnel;/**< Tunnel parameters, NULL for transport mode */ -uint64_t esn_soft_limit; -/**< ESN for which the overflow event need to be raised */ +struct rte_security_ipsec_lifetime life; +/**< IPsec SA lifetime */ uint32_t replay_win_sz;/**< Anti replay window size to enable sequence replay attack handling.
lib/security/rte_security.h struct rte_security_ipsec_xform {
Quoted 2 lines
lib/security/rte_security.h +0
-1* replay checking is disabled if the window size is 0. --Quoted 1 line
2.7.4
PATCH v2 2/6 common/cnxk: support lifetime configuration
In reply to Anoob JosephAdd support for SA lifetime configuration. Expiry can be either in units of octets or packets.
Also, updated cryptodev dequeue path to update crypto op result to indicate soft expiry.
--- drivers/common/cnxk/cnxk_security.c | 70 +++++++++++++++++++++++++++++++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 48 ++++++++++++++++----- drivers/crypto/cnxk/cn9k_ipsec.c | 6 ++- 3 files changed, 112 insertions(+), 12 deletions(-)
drivers/common/cnxk/cnxk_security.c +70 -0
@@ -161,6 +161,26 @@ ot_ipsec_sa_common_param_fill(union roc_ot_ipsec_sa_word2 *w2,return -EINVAL ; } +if (ipsec_xfrm->life.packets_soft_limit !=0 || + ipsec_xfrm->life.packets_hard_limit !=0 ) { +if (ipsec_xfrm->life.bytes_soft_limit !=0 || + ipsec_xfrm->life.bytes_hard_limit !=0 ) { +plt_err ("Expiry tracking with both packets & bytes is not supported" ); +return -EINVAL ; + } + w2->s.life_unit =ROC_IE_OT_SA_LIFE_UNIT_PKTS ; + } + +if (ipsec_xfrm->life.bytes_soft_limit !=0 || + ipsec_xfrm->life.bytes_hard_limit !=0 ) { +if (ipsec_xfrm->life.packets_soft_limit !=0 || + ipsec_xfrm->life.packets_hard_limit !=0 ) { +plt_err ("Expiry tracking with both packets & bytes is not supported" ); +return -EINVAL ; + } + w2->s.life_unit =ROC_IE_OT_SA_LIFE_UNIT_OCTETS ; + } +return 0 ; }
@@ -236,6 +256,31 @@ cnxk_ot_ipsec_inb_sa_fill(struct roc_ot_ipsec_inb_sa *sa, ROC_CTX_UNIT_128B) -1 ; +/** +* CPT MC triggers expiry when counter value changes from 2 to 1. To +* mitigate this behaviour add 1 to the life counter values provided. +*/ + +if (ipsec_xfrm->life.bytes_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.bytes_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.packets_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.bytes_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.bytes_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.packets_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } +/* There are two words of CPT_CTX_HW_S for ucode to skip */ sa->w0.s.ctx_hdr_size =1 ; sa->w0.s.aop_valid =1 ;
@@ -360,6 +405,31 @@ cnxk_ot_ipsec_outb_sa_fill(struct roc_ot_ipsec_outb_sa *sa,/* IPID gen */ sa->w2.s.ipid_gen =1 ; +/** +* CPT MC triggers expiry when counter value changes from 2 to 1. To +* mitigate this behaviour add 1 to the life counter values provided. +*/ + +if (ipsec_xfrm->life.bytes_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.bytes_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.packets_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.bytes_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.bytes_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.packets_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } +/* There are two words of CPT_CTX_HW_S for ucode to skip */ sa->w0.s.ctx_hdr_size =1 ; sa->w0.s.aop_valid =1 ;
drivers/crypto/cnxk/cn10k_cryptodev_ops.c +37 -11
69 lines not on this page · raw message
drivers/crypto/cnxk/cn9k_ipsec.c +5 -1
@@ -485,7 +485,11 @@ cn9k_ipsec_inb_sa_create(struct cnxk_cpt_qp *qp,static inline int cn9k_ipsec_xform_verify (struct rte_security_ipsec_xform *ipsec) { -RTE_SET_USED (ipsec); +if (ipsec->life.bytes_hard_limit !=0 || + ipsec->life.bytes_soft_limit !=0 || + ipsec->life.packets_hard_limit !=0 || + ipsec->life.packets_soft_limit !=0 ) +return -ENOTSUP ;return 0 ; }
Signature · 1 line
2.7.4
PATCH v2 3/6 crypto/octeontx2: add checks for life configuration
In reply to Anoob JosephLifetime tracking is not supported by hardware and is not implemented in software either. Return failure when lifetime is configured.
--- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/crypto/octeontx2/otx2_ipsec_po.h +6 -0
@@ -293,6 +293,12 @@ ipsec_po_xform_verify(struct rte_security_ipsec_xform *ipsec,struct rte_crypto_sym_xform *auth_xform, *cipher_xform;int ret; +if (ipsec->life.bytes_hard_limit !=0 || + ipsec->life.bytes_soft_limit !=0 || + ipsec->life.packets_hard_limit !=0 || + ipsec->life.packets_soft_limit !=0 ) +return -ENOTSUP ; +if (xform->type ==RTE_CRYPTO_SYM_XFORM_AEAD )return ipsec_po_xform_aead_verify (ipsec, xform);
Signature · 1 line
2.7.4
PATCH v2 4/6 test/crypto: add packets soft expiry tests
In reply to Anoob JosephAdd tests to validate packets soft expiry handling.
--- app/test/test_cryptodev.c | 21 +++++++++++++++++++-- app/test/test_cryptodev_security_ipsec.c | 18 ++++++++++++++++-- app/test/test_cryptodev_security_ipsec.h | 4 +++- 3 files changed, 38 insertions(+), 5 deletions(-)
app/test/test_cryptodev.c +19 -2
@@ -8997,7 +8997,7 @@ test_ipsec_proto_process(const struct ipsec_test_data td[],/* Process crypto operation */ process_crypto_request (dev_id, ut_params->op); - ret =test_ipsec_status_check (ut_params->op, flags, dir); + ret =test_ipsec_status_check (ut_params->op, flags, dir, i +1 );if (ret !=TEST_SUCCESS ) goto crypto_op_free;
@@ -9067,7 +9067,8 @@ test_ipsec_proto_all(const struct ipsec_test_flags *flags)unsigned int i, nb_pkts =1 , pass_cnt =0 ;int ret; -if (flags->iv_gen) +if (flags->iv_gen || + flags->sa_expiry_pkts_soft) nb_pkts =IPSEC_TEST_PACKETS_MAX ;for (i =0 ; i <RTE_DIM (aead_list); i++) {
@@ -9132,6 +9133,18 @@ test_ipsec_proto_iv_gen(const void *data __rte_unused) }static int +test_ipsec_proto_sa_exp_pkts_soft(const void *data __rte_unused) +{ +struct ipsec_test_flags flags; + +memset (&flags,0 ,sizeof (flags)); + + flags.sa_expiry_pkts_soft = true; + +return test_ipsec_proto_all (&flags); +} + +static int test_ipsec_proto_err_icv_corrupt(const void *data __rte_unused) {struct ipsec_test_flags flags;
@@ -14087,6 +14100,10 @@ static struct unit_test_suite ipsec_proto_testsuite = { ut_setup_security, ut_teardown, test_ipsec_proto_udp_encap),TEST_CASE_NAMED_ST ( +"SA expiry packets soft" , + ut_setup_security, ut_teardown, + test_ipsec_proto_sa_exp_pkts_soft), +TEST_CASE_NAMED_ST ("Negative test: ICV corruption" , ut_setup_security, ut_teardown, test_ipsec_proto_err_icv_corrupt),
app/test/test_cryptodev_security_ipsec.c +16 -2
@@ -173,6 +173,10 @@ test_ipsec_td_prepare(const struct crypto_param *param1,if (flags->iv_gen) td->ipsec_xform.options.iv_gen_disable =0 ; + +if (flags->sa_expiry_pkts_soft) + td->ipsec_xform.life.packets_soft_limit = +IPSEC_TEST_PACKETS_MAX -1 ; }RTE_SET_USED (param2);
@@ -395,7 +399,8 @@ test_ipsec_post_process(struct rte_mbuf *m, const struct ipsec_test_data *td,int test_ipsec_status_check (struct rte_crypto_op *op,const struct ipsec_test_flags *flags, -enum rte_security_ipsec_sa_direction dir) +enum rte_security_ipsec_sa_direction dir, +int pkt_num) {int ret =TEST_SUCCESS ;
@@ -406,7 +411,16 @@ test_ipsec_status_check(struct rte_crypto_op *op, } }else {if (op->status !=RTE_CRYPTO_OP_STATUS_SUCCESS ) { -printf ("Security op processing failed\n" ); +printf ("Security op processing failed [pkt_num: %d]\n" , + pkt_num); + ret =TEST_FAILED ; + } + } + +if (flags->sa_expiry_pkts_soft && pkt_num ==IPSEC_TEST_PACKETS_MAX ) { +if (!(op->aux_flags & +RTE_CRYPTO_OP_AUX_FLAGS_IPSEC_SOFT_EXPIRY )) { +printf ("SA soft expiry (pkts) test failed\n" ); ret =TEST_FAILED ; } }
app/test/test_cryptodev_security_ipsec.h +3 -1
@@ -49,6 +49,7 @@ struct ipsec_test_data {struct ipsec_test_flags {bool display_alg; +bool sa_expiry_pkts_soft;bool icv_corrupt;bool iv_gen;bool udp_encap;
@@ -114,6 +115,7 @@ int test_ipsec_post_process(struct rte_mbuf *m,int test_ipsec_status_check (struct rte_crypto_op *op,const struct ipsec_test_flags *flags, -enum rte_security_ipsec_sa_direction dir); +enum rte_security_ipsec_sa_direction dir, +int pkt_num);#endif
Signature · 1 line
2.7.4
PATCH v2 5/6 test/crypto: add packets hard expiry tests
In reply to Anoob JosephAdd tests to validate packets hard expiry handling.
--- app/test/test_cryptodev.c | 19 ++++++++++++++++++- app/test/test_cryptodev_security_ipsec.c | 22 +++++++++++++++++++--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 38 insertions(+), 4 deletions(-)
app/test/test_cryptodev.c +18 -1
@@ -9068,7 +9068,8 @@ test_ipsec_proto_all(const struct ipsec_test_flags *flags)int ret;if (flags->iv_gen || - flags->sa_expiry_pkts_soft) + flags->sa_expiry_pkts_soft || + flags->sa_expiry_pkts_hard) nb_pkts =IPSEC_TEST_PACKETS_MAX ;for (i =0 ; i <RTE_DIM (aead_list); i++) {
@@ -9145,6 +9146,18 @@ test_ipsec_proto_sa_exp_pkts_soft(const void *data __rte_unused) }static int +test_ipsec_proto_sa_exp_pkts_hard(const void *data __rte_unused) +{ +struct ipsec_test_flags flags; + +memset (&flags,0 ,sizeof (flags)); + + flags.sa_expiry_pkts_hard = true; + +return test_ipsec_proto_all (&flags); +} + +static int test_ipsec_proto_err_icv_corrupt(const void *data __rte_unused) {struct ipsec_test_flags flags;
@@ -14104,6 +14117,10 @@ static struct unit_test_suite ipsec_proto_testsuite = { ut_setup_security, ut_teardown, test_ipsec_proto_sa_exp_pkts_soft),TEST_CASE_NAMED_ST ( +"SA expiry packets hard" , + ut_setup_security, ut_teardown, + test_ipsec_proto_sa_exp_pkts_hard), +TEST_CASE_NAMED_ST ("Negative test: ICV corruption" , ut_setup_security, ut_teardown, test_ipsec_proto_err_icv_corrupt),
app/test/test_cryptodev_security_ipsec.c +19 -3
@@ -200,6 +200,10 @@ test_ipsec_td_update(struct ipsec_test_data td_inb[], td_inb[i].input_text.data[icv_pos] +=1 ; } +if (flags->sa_expiry_pkts_hard) + td_inb[i].ipsec_xform.life.packets_hard_limit = +IPSEC_TEST_PACKETS_MAX -1 ; +if (flags->udp_encap) td_inb[i].ipsec_xform.options.udp_encap =1 ;
@@ -285,9 +289,10 @@ test_ipsec_td_verify(struct rte_mbuf *m, const struct ipsec_test_data *td, uint8_t *output_text = rte_pktmbuf_mtod(m, uint8_t *);uint32_t skip, len =rte_pktmbuf_pkt_len (m); -/* For negative tests, no need to do verification */ -if (flags->icv_corrupt && - td->ipsec_xform.direction ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS ) +/* For tests with status as error for test success, skip verification */ +if (td->ipsec_xform.direction ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && + (flags->icv_corrupt || + flags->sa_expiry_pkts_hard))return TEST_SUCCESS ; if (td->ipsec_xform.direction == RTE_SECURITY_IPSEC_SA_DIR_EGRESS &&
@@ -404,6 +409,17 @@ test_ipsec_status_check(struct rte_crypto_op *op, {int ret =TEST_SUCCESS ; +if (dir ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && + flags->sa_expiry_pkts_hard && + pkt_num ==IPSEC_TEST_PACKETS_MAX ) { +if (op->status !=RTE_CRYPTO_OP_STATUS_ERROR ) { +printf ("SA hard expiry (pkts) test failed\n" ); +return TEST_FAILED ; + }else { +return TEST_SUCCESS ; + } + } +if (dir ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && flags->icv_corrupt) {if (op->status !=RTE_CRYPTO_OP_STATUS_ERROR ) {printf ("ICV corruption test case failed\n" );
app/test/test_cryptodev_security_ipsec.h +1 -0
@@ -50,6 +50,7 @@ struct ipsec_test_data {struct ipsec_test_flags {bool display_alg;bool sa_expiry_pkts_soft; +bool sa_expiry_pkts_hard;bool icv_corrupt;bool iv_gen;bool udp_encap;
Signature · 1 line
2.7.4
PATCH v2 6/6 examples/ipsec-secgw: clear soft expiry configuration
In reply to Anoob JosephSoft expiry is not a mandatory IPsec feature. It is verified separately with IPsec unit tests. So configuration of the same is not required. Also, soft expiry tracking can cause perf degradation with some PMDs. Since a separate UT is available and the same setting in ipsec-secgw is not verifying the functionality, remove the same by clearing life configuration.
--- examples/ipsec-secgw/ipsec.c | 5 ++++- examples/ipsec-secgw/ipsec.h | 2 -- 2 files changed, 4 insertions(+), 3 deletions(-)
examples/ipsec-secgw/ipsec.c +4 -1
@@ -49,7 +49,10 @@ set_ipsec_conf(struct ipsec_sa *sa, struct rte_security_ipsec_xform *ipsec) }/* TODO support for Transport */ } - ipsec->life.packets_soft_limit =IPSEC_OFFLOAD_PKTS_SOFTLIMIT ; + ipsec->life.packets_soft_limit =0 ; + ipsec->life.packets_hard_limit =0 ; + ipsec->life.bytes_soft_limit =0 ; + ipsec->life.bytes_hard_limit =0 ; ipsec->replay_win_sz = app_sa_prm.window_size; ipsec->options.esn = app_sa_prm.enable_esn; ipsec->options.udp_encap = sa->udp_encap;
examples/ipsec-secgw/ipsec.h +0 -2
@@ -23,8 +23,6 @@#define MAX_DIGEST_SIZE 32/* Bytes -- 256 bits */ -#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00 -#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ sizeof(struct rte_crypto_sym_op))
Signature · 1 line
2.7.4
Re: [dpdk-dev] [PATCH v2 6/6] examples/ipsec-secgw: clear soft expiry configuration
Quoted 21 lines
Soft expiry is not a mandatory IPsec feature. It is verified separately with IPsec unit tests. So configuration of the same is not required. Also, soft expiry tracking can cause perf degradation with some PMDs. Since a separate UT is available and the same setting in ipsec-secgw is not verifying the functionality, remove the same by clearing life configuration.
Signed-off-by Anoob Joseph <[email protected]>--- examples/ipsec-secgw/ipsec.c | 5 ++++- examples/ipsec-secgw/ipsec.h | 2 -- 2 files changed, 4 insertions(+), 3 deletions(-)examples/ipsec-secgw/ipsec.c +0
-0
examples/ipsec-secgw/ipsec.c set_ipsec_conf(struct ipsec_sa *sa, struct rte_security_ipsec_xform *ipsec) · line 55
Quoted 8 lines
examples/ipsec-secgw/ipsec.c +4
-1@@ -49,7 +49,10 @@ set_ipsec_conf(struct ipsec_sa *sa, struct rte_security_ipsec_xform *ipsec) }/* TODO support for Transport */ } - ipsec->life.packets_soft_limit =IPSEC_OFFLOAD_PKTS_SOFTLIMIT ; + ipsec->life.packets_soft_limit =0 ; + ipsec->life.packets_hard_limit =0 ; + ipsec->life.bytes_soft_limit =0 ; + ipsec->life.bytes_hard_limit =0 ;
As a nit: as I can read the code it would be already zeroed at entrance to this function, so explicit zeroing is not really required.
Quoted 18 lines
examples/ipsec-secgw/ipsec.c +0
-0ipsec->replay_win_sz = app_sa_prm.window_size; ipsec->options.esn = app_sa_prm.enable_esn; ipsec->options.udp_encap = sa->udp_encap;examples/ipsec-secgw/ipsec.h +0
-3@@ -23,8 +23,6 @@#define MAX_DIGEST_SIZE 32/* Bytes -- 256 bits */ -#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00 -#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ sizeof(struct rte_crypto_sym_op)) --2.7.4
v3 cover Add SA lifetime in security
In reply to Anoob JosephAdd SA lifetime configuration in security. SA lifetime tracking can be offloaded on supported PMDs.
SA lifetime would cover soft & hard expiry in units of number of packets and bytes. When SA soft expiry happens, the packet is successfuly processed but with additional expiry notification. Crypto op structure, ``rte_crypto_op`` is updated to cover such notifications with lookaside protocol offloads.
SA hard expiration would cause IPsec processing to return an error.
PMDs crypto_cn10k, crypto_cn9k and crypto_octeontx2 are updated with their respective lifetime tracking capabilities. Unit tests are added for soft and hard expiry with number of packets.
Changes in v3:
- Removed explicit 0 setting of soft expiry configuration in ipsec-secgw (comment from Konstantin)
Changes in v2:
- Clear soft expiry configuration in ipsec-secgw
- Rebased on v3 of dependent series
Anoob Joseph (6):
security: add SA lifetime configuration common/cnxk: support lifetime configuration crypto/octeontx2: add checks for life configuration test/crypto: add packets soft expiry tests test/crypto: add packets hard expiry tests examples/ipsec-secgw: clear soft expiry configuration
app/test/test_cryptodev.c | 38 +++++++++++- app/test/test_cryptodev_security_ipsec.c | 40 +++++++++++-- app/test/test_cryptodev_security_ipsec.h | 5 +- .../test_cryptodev_security_ipsec_test_vectors.h | 3 - doc/guides/rel_notes/deprecation.rst | 5 -- doc/guides/rel_notes/release_21_11.rst | 13 ++++ drivers/common/cnxk/cnxk_security.c | 70 ++++++++++++++++++++++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 48 +++++++++++---- drivers/crypto/cnxk/cn9k_ipsec.c | 6 +- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++ examples/ipsec-secgw/ipsec.c | 1 - examples/ipsec-secgw/ipsec.h | 2 - lib/cryptodev/rte_crypto.h | 18 +++++- lib/security/rte_security.h | 28 ++++++++- 14 files changed, 249 insertions(+), 34 deletions(-)
Signature · 1 line
2.7.4
PATCH v3 1/6 security: add SA lifetime configuration
Add SA lifetime configuration to register soft and hard expiry limits. Expiry can be in units of number of packets or bytes. Crypto op status is also updated to include new field, aux_flags, which can be used to indicate cases such as soft expiry in case of lookaside protocol operations.
In case of soft expiry, the packets are successfully IPsec processed but the soft expiry would indicate that SA needs to be reconfigured. For inline protocol capable ethdev, this would result in an eth event while for lookaside protocol capable cryptodev, this can be communicated via rte_crypto_op.aux_flags field.
In case of hard expiry, the packets will not be IPsec processed and would result in error.
--- .../test_cryptodev_security_ipsec_test_vectors.h | 3 --- doc/guides/rel_notes/deprecation.rst | 5 ---- doc/guides/rel_notes/release_21_11.rst | 13 ++++++++++ examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h | 2 +- lib/cryptodev/rte_crypto.h | 18 +++++++++++++- lib/security/rte_security.h | 28 ++++++++++++++++++++-- 7 files changed, 58 insertions(+), 13 deletions(-)
app/test/test_cryptodev_security_ipsec_test_vectors.h +0 -3
@@ -98,7 +98,6 @@ struct ipsec_test_data pkt_aes_128_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
@@ -195,7 +194,6 @@ struct ipsec_test_data pkt_aes_192_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
@@ -295,7 +293,6 @@ struct ipsec_test_data pkt_aes_256_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
doc/guides/rel_notes/deprecation.rst +0 -5
@@ -275,8 +275,3 @@ Deprecation Notices * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific content. On Linux and FreeBSD, supported prior to DPDK 20.11, original structure will be kept until DPDK 21.11. - -* cryptodev: The structure ``rte_crypto_op`` would be updated to reduce - reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other - information from the crypto/security operation. This field will be used to - communicate events such as soft expiry with IPsec in lookaside mode.
doc/guides/rel_notes/release_21_11.rst +13 -0
@@ -147,6 +147,13 @@ API Changes as it is for drivers only and should be private to DPDK, and not installed for app use. +* cryptodev: use 1 reserved byte from ``rte_crypto_op`` for aux flags + + * Updated the structure ``rte_crypto_op`` to reduce reserved bytes to + 2 (from 3), and use 1 byte to indicate warnings and other information from + the crypto/security operation. This field will be used to communicate events + such as soft expiry with IPsec in lookaside mode. + ABI Changes -----------
@@ -168,6 +175,12 @@ ABI Changes * Added IPsec SA option to disable IV generation to allow known vector tests as well as usage of application provided IV on supported PMDs. +* security: add IPsec SA lifetime configuration + + * Added IPsec SA lifetime configuration to allow applications to configure + soft and hard SA expiry limits. Limits can be either in units of packets or + bytes. + Known Issues ------------
examples/ipsec-secgw/ipsec.c +1 -1
@@ -49,7 +49,7 @@ set_ipsec_conf(struct ipsec_sa *sa, struct rte_security_ipsec_xform *ipsec) }/* TODO support for Transport */ } - ipsec->esn_soft_limit =IPSEC_OFFLOAD_ESN_SOFTLIMIT ; + ipsec->life.packets_soft_limit =IPSEC_OFFLOAD_PKTS_SOFTLIMIT ; ipsec->replay_win_sz = app_sa_prm.window_size; ipsec->options.esn = app_sa_prm.enable_esn; ipsec->options.udp_encap = sa->udp_encap;
examples/ipsec-secgw/ipsec.h +1 -1
@@ -23,7 +23,7 @@#define MAX_DIGEST_SIZE 32/* Bytes -- 256 bits */ -#define IPSEC_OFFLOAD_ESN_SOFTLIMIT 0xffffff00 +#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ sizeof(struct rte_crypto_sym_op))
lib/cryptodev/rte_crypto.h +17 -1
@@ -66,6 +66,17 @@ enum rte_crypto_op_sess_type { };/** +* Auxiliary flags to indicate additional info from the operation +*/ + +/** +* Auxiliary flags related to IPsec offload with RTE_SECURITY +*/ + +#define RTE_CRYPTO_OP_AUX_FLAGS_IPSEC_SOFT_EXPIRY (1 << 0) +/**< SA soft expiry limit has been reached */ + +/** * Cryptographic Operation. * * This structure contains data relating to performing cryptographic
@@ -93,7 +104,12 @@ struct rte_crypto_op {*/ uint8_t sess_type;/**< operation session type */ -uint8_t reserved[3 ]; +uint8_t aux_flags; +/**< Operation specific auxiliary/additional flags. +* These flags carry additional information from the +* operation. Processing of the same is optional. +*/ +uint8_t reserved[2 ];/**< Reserved bytes to fill 64 bits for * future additions */
lib/security/rte_security.h +26 -2
@@ -217,6 +217,30 @@ enum rte_security_ipsec_sa_direction { };/** +* Configure soft and hard lifetime of an IPsec SA +* +* Lifetime of an IPsec SA would specify the maximum number of packets or bytes +* that can be processed. IPsec operations would start failing once any hard +* limit is reached. +* +* Soft limits can be specified to generate notification when the SA is +* approaching hard limits for lifetime. For inline operations, reaching soft +* expiry limit would result in raising an eth event for the same. For lookaside +* operations, this would result in a warning returned in +* ``rte_crypto_op.aux_flags``. +*/ +struct rte_security_ipsec_lifetime { +uint64_t packets_soft_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_soft_limit; +/**< Soft expiry limit in bytes */ +uint64_t packets_hard_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_hard_limit; +/**< Soft expiry limit in bytes */ +}; + +/** * IPsec security association configuration data. * * This structure contains data required to create an IPsec SA security session.
@@ -236,8 +260,8 @@ struct rte_security_ipsec_xform {/**< IPsec SA Mode - transport/tunnel */ struct rte_security_ipsec_tunnel_param tunnel;/**< Tunnel parameters, NULL for transport mode */ -uint64_t esn_soft_limit; -/**< ESN for which the overflow event need to be raised */ +struct rte_security_ipsec_lifetime life; +/**< IPsec SA lifetime */ uint32_t replay_win_sz;/**< Anti replay window size to enable sequence replay attack handling. * replay checking is disabled if the window size is 0.
Signature · 1 line
2.7.4
PATCH v3 2/6 common/cnxk: support lifetime configuration
In reply to Anoob JosephAdd support for SA lifetime configuration. Expiry can be either in units of octets or packets.
Also, updated cryptodev dequeue path to update crypto op result to indicate soft expiry.
--- drivers/common/cnxk/cnxk_security.c | 70 +++++++++++++++++++++++++++++++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 48 ++++++++++++++++----- drivers/crypto/cnxk/cn9k_ipsec.c | 6 ++- 3 files changed, 112 insertions(+), 12 deletions(-)
drivers/common/cnxk/cnxk_security.c +70 -0
@@ -161,6 +161,26 @@ ot_ipsec_sa_common_param_fill(union roc_ot_ipsec_sa_word2 *w2,return -EINVAL ; } +if (ipsec_xfrm->life.packets_soft_limit !=0 || + ipsec_xfrm->life.packets_hard_limit !=0 ) { +if (ipsec_xfrm->life.bytes_soft_limit !=0 || + ipsec_xfrm->life.bytes_hard_limit !=0 ) { +plt_err ("Expiry tracking with both packets & bytes is not supported" ); +return -EINVAL ; + } + w2->s.life_unit =ROC_IE_OT_SA_LIFE_UNIT_PKTS ; + } + +if (ipsec_xfrm->life.bytes_soft_limit !=0 || + ipsec_xfrm->life.bytes_hard_limit !=0 ) { +if (ipsec_xfrm->life.packets_soft_limit !=0 || + ipsec_xfrm->life.packets_hard_limit !=0 ) { +plt_err ("Expiry tracking with both packets & bytes is not supported" ); +return -EINVAL ; + } + w2->s.life_unit =ROC_IE_OT_SA_LIFE_UNIT_OCTETS ; + } +return 0 ; }
@@ -236,6 +256,31 @@ cnxk_ot_ipsec_inb_sa_fill(struct roc_ot_ipsec_inb_sa *sa, ROC_CTX_UNIT_128B) -1 ; +/** +* CPT MC triggers expiry when counter value changes from 2 to 1. To +* mitigate this behaviour add 1 to the life counter values provided. +*/ + +if (ipsec_xfrm->life.bytes_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.bytes_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.packets_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.bytes_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.bytes_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.packets_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } +/* There are two words of CPT_CTX_HW_S for ucode to skip */ sa->w0.s.ctx_hdr_size =1 ; sa->w0.s.aop_valid =1 ;
@@ -360,6 +405,31 @@ cnxk_ot_ipsec_outb_sa_fill(struct roc_ot_ipsec_outb_sa *sa,/* IPID gen */ sa->w2.s.ipid_gen =1 ; +/** +* CPT MC triggers expiry when counter value changes from 2 to 1. To +* mitigate this behaviour add 1 to the life counter values provided. +*/ + +if (ipsec_xfrm->life.bytes_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.bytes_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.packets_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.bytes_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.bytes_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.packets_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } +/* There are two words of CPT_CTX_HW_S for ucode to skip */ sa->w0.s.ctx_hdr_size =1 ; sa->w0.s.aop_valid =1 ;
drivers/crypto/cnxk/cn10k_cryptodev_ops.c +37 -11
69 lines not on this page · raw message
drivers/crypto/cnxk/cn9k_ipsec.c +5 -1
@@ -485,7 +485,11 @@ cn9k_ipsec_inb_sa_create(struct cnxk_cpt_qp *qp,static inline int cn9k_ipsec_xform_verify (struct rte_security_ipsec_xform *ipsec) { -RTE_SET_USED (ipsec); +if (ipsec->life.bytes_hard_limit !=0 || + ipsec->life.bytes_soft_limit !=0 || + ipsec->life.packets_hard_limit !=0 || + ipsec->life.packets_soft_limit !=0 ) +return -ENOTSUP ;return 0 ; }
Signature · 1 line
2.7.4
PATCH v3 3/6 crypto/octeontx2: add checks for life configuration
In reply to Anoob JosephLifetime tracking is not supported by hardware and is not implemented in software either. Return failure when lifetime is configured.
--- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/crypto/octeontx2/otx2_ipsec_po.h +6 -0
@@ -293,6 +293,12 @@ ipsec_po_xform_verify(struct rte_security_ipsec_xform *ipsec,struct rte_crypto_sym_xform *auth_xform, *cipher_xform;int ret; +if (ipsec->life.bytes_hard_limit !=0 || + ipsec->life.bytes_soft_limit !=0 || + ipsec->life.packets_hard_limit !=0 || + ipsec->life.packets_soft_limit !=0 ) +return -ENOTSUP ; +if (xform->type ==RTE_CRYPTO_SYM_XFORM_AEAD )return ipsec_po_xform_aead_verify (ipsec, xform);
Signature · 1 line
2.7.4
PATCH v3 4/6 test/crypto: add packets soft expiry tests
In reply to Anoob JosephAdd tests to validate packets soft expiry handling.
--- app/test/test_cryptodev.c | 21 +++++++++++++++++++-- app/test/test_cryptodev_security_ipsec.c | 18 ++++++++++++++++-- app/test/test_cryptodev_security_ipsec.h | 4 +++- 3 files changed, 38 insertions(+), 5 deletions(-)
app/test/test_cryptodev.c +19 -2
@@ -9045,7 +9045,7 @@ test_ipsec_proto_process(const struct ipsec_test_data td[],/* Process crypto operation */ process_crypto_request (dev_id, ut_params->op); - ret =test_ipsec_status_check (ut_params->op, flags, dir); + ret =test_ipsec_status_check (ut_params->op, flags, dir, i +1 );if (ret !=TEST_SUCCESS ) goto crypto_op_free;
@@ -9115,7 +9115,8 @@ test_ipsec_proto_all(const struct ipsec_test_flags *flags)unsigned int i, nb_pkts =1 , pass_cnt =0 ;int ret; -if (flags->iv_gen) +if (flags->iv_gen || + flags->sa_expiry_pkts_soft) nb_pkts =IPSEC_TEST_PACKETS_MAX ;for (i =0 ; i <RTE_DIM (aead_list); i++) {
@@ -9180,6 +9181,18 @@ test_ipsec_proto_iv_gen(const void *data __rte_unused) }static int +test_ipsec_proto_sa_exp_pkts_soft(const void *data __rte_unused) +{ +struct ipsec_test_flags flags; + +memset (&flags,0 ,sizeof (flags)); + + flags.sa_expiry_pkts_soft = true; + +return test_ipsec_proto_all (&flags); +} + +static int test_ipsec_proto_err_icv_corrupt(const void *data __rte_unused) {struct ipsec_test_flags flags;
@@ -14136,6 +14149,10 @@ static struct unit_test_suite ipsec_proto_testsuite = { ut_setup_security, ut_teardown, test_ipsec_proto_udp_encap),TEST_CASE_NAMED_ST ( +"SA expiry packets soft" , + ut_setup_security, ut_teardown, + test_ipsec_proto_sa_exp_pkts_soft), +TEST_CASE_NAMED_ST ("Negative test: ICV corruption" , ut_setup_security, ut_teardown, test_ipsec_proto_err_icv_corrupt),
app/test/test_cryptodev_security_ipsec.c +16 -2
@@ -173,6 +173,10 @@ test_ipsec_td_prepare(const struct crypto_param *param1,if (flags->iv_gen) td->ipsec_xform.options.iv_gen_disable =0 ; + +if (flags->sa_expiry_pkts_soft) + td->ipsec_xform.life.packets_soft_limit = +IPSEC_TEST_PACKETS_MAX -1 ; }RTE_SET_USED (param2);
@@ -395,7 +399,8 @@ test_ipsec_post_process(struct rte_mbuf *m, const struct ipsec_test_data *td,int test_ipsec_status_check (struct rte_crypto_op *op,const struct ipsec_test_flags *flags, -enum rte_security_ipsec_sa_direction dir) +enum rte_security_ipsec_sa_direction dir, +int pkt_num) {int ret =TEST_SUCCESS ;
@@ -406,7 +411,16 @@ test_ipsec_status_check(struct rte_crypto_op *op, } }else {if (op->status !=RTE_CRYPTO_OP_STATUS_SUCCESS ) { -printf ("Security op processing failed\n" ); +printf ("Security op processing failed [pkt_num: %d]\n" , + pkt_num); + ret =TEST_FAILED ; + } + } + +if (flags->sa_expiry_pkts_soft && pkt_num ==IPSEC_TEST_PACKETS_MAX ) { +if (!(op->aux_flags & +RTE_CRYPTO_OP_AUX_FLAGS_IPSEC_SOFT_EXPIRY )) { +printf ("SA soft expiry (pkts) test failed\n" ); ret =TEST_FAILED ; } }
app/test/test_cryptodev_security_ipsec.h +3 -1
@@ -49,6 +49,7 @@ struct ipsec_test_data {struct ipsec_test_flags {bool display_alg; +bool sa_expiry_pkts_soft;bool icv_corrupt;bool iv_gen;bool udp_encap;
@@ -114,6 +115,7 @@ int test_ipsec_post_process(struct rte_mbuf *m,int test_ipsec_status_check (struct rte_crypto_op *op,const struct ipsec_test_flags *flags, -enum rte_security_ipsec_sa_direction dir); +enum rte_security_ipsec_sa_direction dir, +int pkt_num);#endif
Signature · 1 line
2.7.4
PATCH v3 5/6 test/crypto: add packets hard expiry tests
In reply to Anoob JosephAdd tests to validate packets hard expiry handling.
--- app/test/test_cryptodev.c | 19 ++++++++++++++++++- app/test/test_cryptodev_security_ipsec.c | 22 +++++++++++++++++++--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 38 insertions(+), 4 deletions(-)
app/test/test_cryptodev.c +18 -1
@@ -9116,7 +9116,8 @@ test_ipsec_proto_all(const struct ipsec_test_flags *flags)int ret;if (flags->iv_gen || - flags->sa_expiry_pkts_soft) + flags->sa_expiry_pkts_soft || + flags->sa_expiry_pkts_hard) nb_pkts =IPSEC_TEST_PACKETS_MAX ;for (i =0 ; i <RTE_DIM (aead_list); i++) {
@@ -9193,6 +9194,18 @@ test_ipsec_proto_sa_exp_pkts_soft(const void *data __rte_unused) }static int +test_ipsec_proto_sa_exp_pkts_hard(const void *data __rte_unused) +{ +struct ipsec_test_flags flags; + +memset (&flags,0 ,sizeof (flags)); + + flags.sa_expiry_pkts_hard = true; + +return test_ipsec_proto_all (&flags); +} + +static int test_ipsec_proto_err_icv_corrupt(const void *data __rte_unused) {struct ipsec_test_flags flags;
@@ -14153,6 +14166,10 @@ static struct unit_test_suite ipsec_proto_testsuite = { ut_setup_security, ut_teardown, test_ipsec_proto_sa_exp_pkts_soft),TEST_CASE_NAMED_ST ( +"SA expiry packets hard" , + ut_setup_security, ut_teardown, + test_ipsec_proto_sa_exp_pkts_hard), +TEST_CASE_NAMED_ST ("Negative test: ICV corruption" , ut_setup_security, ut_teardown, test_ipsec_proto_err_icv_corrupt),
app/test/test_cryptodev_security_ipsec.c +19 -3
@@ -200,6 +200,10 @@ test_ipsec_td_update(struct ipsec_test_data td_inb[], td_inb[i].input_text.data[icv_pos] +=1 ; } +if (flags->sa_expiry_pkts_hard) + td_inb[i].ipsec_xform.life.packets_hard_limit = +IPSEC_TEST_PACKETS_MAX -1 ; +if (flags->udp_encap) td_inb[i].ipsec_xform.options.udp_encap =1 ;
@@ -285,9 +289,10 @@ test_ipsec_td_verify(struct rte_mbuf *m, const struct ipsec_test_data *td, uint8_t *output_text = rte_pktmbuf_mtod(m, uint8_t *);uint32_t skip, len =rte_pktmbuf_pkt_len (m); -/* For negative tests, no need to do verification */ -if (flags->icv_corrupt && - td->ipsec_xform.direction ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS ) +/* For tests with status as error for test success, skip verification */ +if (td->ipsec_xform.direction ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && + (flags->icv_corrupt || + flags->sa_expiry_pkts_hard))return TEST_SUCCESS ; if (td->ipsec_xform.direction == RTE_SECURITY_IPSEC_SA_DIR_EGRESS &&
@@ -404,6 +409,17 @@ test_ipsec_status_check(struct rte_crypto_op *op, {int ret =TEST_SUCCESS ; +if (dir ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && + flags->sa_expiry_pkts_hard && + pkt_num ==IPSEC_TEST_PACKETS_MAX ) { +if (op->status !=RTE_CRYPTO_OP_STATUS_ERROR ) { +printf ("SA hard expiry (pkts) test failed\n" ); +return TEST_FAILED ; + }else { +return TEST_SUCCESS ; + } + } +if (dir ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && flags->icv_corrupt) {if (op->status !=RTE_CRYPTO_OP_STATUS_ERROR ) {printf ("ICV corruption test case failed\n" );
app/test/test_cryptodev_security_ipsec.h +1 -0
@@ -50,6 +50,7 @@ struct ipsec_test_data {struct ipsec_test_flags {bool display_alg;bool sa_expiry_pkts_soft; +bool sa_expiry_pkts_hard;bool icv_corrupt;bool iv_gen;bool udp_encap;
Signature · 1 line
2.7.4
PATCH v3 6/6 examples/ipsec-secgw: clear soft expiry configuration
In reply to Anoob JosephSoft expiry is not a mandatory IPsec feature. It is verified separately with IPsec unit tests. So configuration of the same is not required. Also, soft expiry tracking can cause perf degradation with some PMDs. Since a separate UT is available and the same setting in ipsec-secgw is not verifying the functionality, remove the same by clearing life configuration.
--- examples/ipsec-secgw/ipsec.c | 1 - examples/ipsec-secgw/ipsec.h | 2 -- 2 files changed, 3 deletions(-)
examples/ipsec-secgw/ipsec.c +0 -1
@@ -49,7 +49,6 @@ set_ipsec_conf(struct ipsec_sa *sa, struct rte_security_ipsec_xform *ipsec) }/* TODO support for Transport */ } - ipsec->life.packets_soft_limit =IPSEC_OFFLOAD_PKTS_SOFTLIMIT ; ipsec->replay_win_sz = app_sa_prm.window_size; ipsec->options.esn = app_sa_prm.enable_esn; ipsec->options.udp_encap = sa->udp_encap;
examples/ipsec-secgw/ipsec.h +0 -2
@@ -23,8 +23,6 @@#define MAX_DIGEST_SIZE 32/* Bytes -- 256 bits */ -#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00 -#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ sizeof(struct rte_crypto_sym_op))
Signature · 1 line
2.7.4
v4 cover Add SA lifetime in security
In reply to Anoob JosephAdd SA lifetime configuration in security. SA lifetime tracking can be offloaded on supported PMDs.
SA lifetime would cover soft & hard expiry in units of number of packets and bytes. When SA soft expiry happens, the packet is successfuly processed but with additional expiry notification. Crypto op structure, ``rte_crypto_op`` is updated to cover such notifications with lookaside protocol offloads.
SA hard expiration would cause IPsec processing to return an error.
PMDs crypto_cn10k, crypto_cn9k and crypto_octeontx2 are updated with their respective lifetime tracking capabilities. Unit tests are added for soft and hard expiry with number of packets.
Changes in v4:
- Removed extra comments around auxilliary flag macros (comment from Konstantin)
Changes in v3:
- Removed explicit 0 setting of soft expiry configuration in ipsec-secgw (comment from Konstantin)
Changes in v2:
- Clear soft expiry configuration in ipsec-secgw
- Rebased on v3 of dependent series
Anoob Joseph (6):
security: add SA lifetime configuration common/cnxk: support lifetime configuration crypto/octeontx2: add checks for life configuration test/crypto: add packets soft expiry cases test/crypto: add packets hard expiry cases examples/ipsec-secgw: clear soft expiry configuration
app/test/test_cryptodev.c | 38 +++++++++++- app/test/test_cryptodev_security_ipsec.c | 40 +++++++++++-- app/test/test_cryptodev_security_ipsec.h | 5 +- .../test_cryptodev_security_ipsec_test_vectors.h | 3 - doc/guides/rel_notes/deprecation.rst | 5 -- doc/guides/rel_notes/release_21_11.rst | 13 ++++ drivers/common/cnxk/cnxk_security.c | 70 ++++++++++++++++++++++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 48 +++++++++++---- drivers/crypto/cnxk/cn9k_ipsec.c | 6 +- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++ examples/ipsec-secgw/ipsec.c | 1 - examples/ipsec-secgw/ipsec.h | 2 - lib/cryptodev/rte_crypto.h | 12 +++- lib/security/rte_security.h | 28 ++++++++- 14 files changed, 243 insertions(+), 34 deletions(-)
Signature · 1 line
2.7.4
PATCH v4 1/6 security: add SA lifetime configuration
Add SA lifetime configuration to register soft and hard expiry limits. Expiry can be in units of number of packets or bytes. Crypto op status is also updated to include new field, aux_flags, which can be used to indicate cases such as soft expiry in case of lookaside protocol operations.
In case of soft expiry, the packets are successfully IPsec processed but the soft expiry would indicate that SA needs to be reconfigured. For inline protocol capable ethdev, this would result in an eth event while for lookaside protocol capable cryptodev, this can be communicated via rte_crypto_op.aux_flags field.
In case of hard expiry, the packets will not be IPsec processed and would result in error.
--- .../test_cryptodev_security_ipsec_test_vectors.h | 3 --- doc/guides/rel_notes/deprecation.rst | 5 ---- doc/guides/rel_notes/release_21_11.rst | 13 ++++++++++ examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h | 2 +- lib/cryptodev/rte_crypto.h | 12 +++++++++- lib/security/rte_security.h | 28 ++++++++++++++++++++-- 7 files changed, 52 insertions(+), 13 deletions(-)
app/test/test_cryptodev_security_ipsec_test_vectors.h +0 -3
@@ -98,7 +98,6 @@ struct ipsec_test_data pkt_aes_128_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
@@ -195,7 +194,6 @@ struct ipsec_test_data pkt_aes_192_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
@@ -295,7 +293,6 @@ struct ipsec_test_data pkt_aes_256_gcm = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .tunnel.type = RTE_SECURITY_IPSEC_TUNNEL_IPV4, - .esn_soft_limit = 0, .replay_win_sz = 0, },
doc/guides/rel_notes/deprecation.rst +0 -5
@@ -275,8 +275,3 @@ Deprecation Notices * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific content. On Linux and FreeBSD, supported prior to DPDK 20.11, original structure will be kept until DPDK 21.11. - -* cryptodev: The structure ``rte_crypto_op`` would be updated to reduce - reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other - information from the crypto/security operation. This field will be used to - communicate events such as soft expiry with IPsec in lookaside mode.
doc/guides/rel_notes/release_21_11.rst +13 -0
@@ -152,6 +152,13 @@ API Changes as it is for drivers only and should be private to DPDK, and not installed for app use. +* cryptodev: use 1 reserved byte from ``rte_crypto_op`` for aux flags + + * Updated the structure ``rte_crypto_op`` to reduce reserved bytes to + 2 (from 3), and use 1 byte to indicate warnings and other information from + the crypto/security operation. This field will be used to communicate events + such as soft expiry with IPsec in lookaside mode. + ABI Changes -----------
@@ -174,6 +181,12 @@ ABI Changes have much processing in PMD specific callbacks but just 64-bit set/get. This avoids a per pkt function pointer jump overhead for such PMD's. +* security: add IPsec SA lifetime configuration + + * Added IPsec SA lifetime configuration to allow applications to configure + soft and hard SA expiry limits. Limits can be either in units of packets or + bytes. + Known Issues ------------
examples/ipsec-secgw/ipsec.c +1 -1
@@ -49,7 +49,7 @@ set_ipsec_conf(struct ipsec_sa *sa, struct rte_security_ipsec_xform *ipsec) }/* TODO support for Transport */ } - ipsec->esn_soft_limit =IPSEC_OFFLOAD_ESN_SOFTLIMIT ; + ipsec->life.packets_soft_limit =IPSEC_OFFLOAD_PKTS_SOFTLIMIT ; ipsec->replay_win_sz = app_sa_prm.window_size; ipsec->options.esn = app_sa_prm.enable_esn; ipsec->options.udp_encap = sa->udp_encap;
examples/ipsec-secgw/ipsec.h +1 -1
@@ -23,7 +23,7 @@#define MAX_DIGEST_SIZE 32/* Bytes -- 256 bits */ -#define IPSEC_OFFLOAD_ESN_SOFTLIMIT 0xffffff00 +#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ sizeof(struct rte_crypto_sym_op))
lib/cryptodev/rte_crypto.h +11 -1
@@ -65,6 +65,11 @@ enum rte_crypto_op_sess_type { RTE_CRYPTO_OP_SECURITY_SESSION /**< Security session crypto operation */ }; +/* Auxiliary flags related to IPsec offload with RTE_SECURITY */ + +#define RTE_CRYPTO_OP_AUX_FLAGS_IPSEC_SOFT_EXPIRY (1 << 0) +/**< SA soft expiry limit has been reached */ +/** * Cryptographic Operation. *
@@ -93,7 +98,12 @@ struct rte_crypto_op {*/ uint8_t sess_type;/**< operation session type */ -uint8_t reserved[3 ]; +uint8_t aux_flags; +/**< Operation specific auxiliary/additional flags. +* These flags carry additional information from the +* operation. Processing of the same is optional. +*/ +uint8_t reserved[2 ];/**< Reserved bytes to fill 64 bits for * future additions */
lib/security/rte_security.h +26 -2
@@ -217,6 +217,30 @@ enum rte_security_ipsec_sa_direction { };/** +* Configure soft and hard lifetime of an IPsec SA +* +* Lifetime of an IPsec SA would specify the maximum number of packets or bytes +* that can be processed. IPsec operations would start failing once any hard +* limit is reached. +* +* Soft limits can be specified to generate notification when the SA is +* approaching hard limits for lifetime. For inline operations, reaching soft +* expiry limit would result in raising an eth event for the same. For lookaside +* operations, this would result in a warning returned in +* ``rte_crypto_op.aux_flags``. +*/ +struct rte_security_ipsec_lifetime { +uint64_t packets_soft_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_soft_limit; +/**< Soft expiry limit in bytes */ +uint64_t packets_hard_limit; +/**< Soft expiry limit in number of packets */ +uint64_t bytes_hard_limit; +/**< Soft expiry limit in bytes */ +}; + +/** * IPsec security association configuration data. * * This structure contains data required to create an IPsec SA security session.
@@ -236,8 +260,8 @@ struct rte_security_ipsec_xform {/**< IPsec SA Mode - transport/tunnel */ struct rte_security_ipsec_tunnel_param tunnel;/**< Tunnel parameters, NULL for transport mode */ -uint64_t esn_soft_limit; -/**< ESN for which the overflow event need to be raised */ +struct rte_security_ipsec_lifetime life; +/**< IPsec SA lifetime */ uint32_t replay_win_sz;/**< Anti replay window size to enable sequence replay attack handling. * replay checking is disabled if the window size is 0.
Signature · 1 line
2.7.4
PATCH v4 2/6 common/cnxk: support lifetime configuration
In reply to Anoob JosephAdd support for SA lifetime configuration. Expiry can be either in units of octets or packets.
Also, updated cryptodev dequeue path to update crypto op result to indicate soft expiry.
--- drivers/common/cnxk/cnxk_security.c | 70 +++++++++++++++++++++++++++++++ drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 48 ++++++++++++++++----- drivers/crypto/cnxk/cn9k_ipsec.c | 6 ++- 3 files changed, 112 insertions(+), 12 deletions(-)
drivers/common/cnxk/cnxk_security.c +70 -0
@@ -161,6 +161,26 @@ ot_ipsec_sa_common_param_fill(union roc_ot_ipsec_sa_word2 *w2,return -EINVAL ; } +if (ipsec_xfrm->life.packets_soft_limit !=0 || + ipsec_xfrm->life.packets_hard_limit !=0 ) { +if (ipsec_xfrm->life.bytes_soft_limit !=0 || + ipsec_xfrm->life.bytes_hard_limit !=0 ) { +plt_err ("Expiry tracking with both packets & bytes is not supported" ); +return -EINVAL ; + } + w2->s.life_unit =ROC_IE_OT_SA_LIFE_UNIT_PKTS ; + } + +if (ipsec_xfrm->life.bytes_soft_limit !=0 || + ipsec_xfrm->life.bytes_hard_limit !=0 ) { +if (ipsec_xfrm->life.packets_soft_limit !=0 || + ipsec_xfrm->life.packets_hard_limit !=0 ) { +plt_err ("Expiry tracking with both packets & bytes is not supported" ); +return -EINVAL ; + } + w2->s.life_unit =ROC_IE_OT_SA_LIFE_UNIT_OCTETS ; + } +return 0 ; }
@@ -236,6 +256,31 @@ cnxk_ot_ipsec_inb_sa_fill(struct roc_ot_ipsec_inb_sa *sa, ROC_CTX_UNIT_128B) -1 ; +/** +* CPT MC triggers expiry when counter value changes from 2 to 1. To +* mitigate this behaviour add 1 to the life counter values provided. +*/ + +if (ipsec_xfrm->life.bytes_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.bytes_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.packets_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.bytes_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.bytes_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.packets_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } +/* There are two words of CPT_CTX_HW_S for ucode to skip */ sa->w0.s.ctx_hdr_size =1 ; sa->w0.s.aop_valid =1 ;
@@ -360,6 +405,31 @@ cnxk_ot_ipsec_outb_sa_fill(struct roc_ot_ipsec_outb_sa *sa,/* IPID gen */ sa->w2.s.ipid_gen =1 ; +/** +* CPT MC triggers expiry when counter value changes from 2 to 1. To +* mitigate this behaviour add 1 to the life counter values provided. +*/ + +if (ipsec_xfrm->life.bytes_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.bytes_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_soft_limit) { + sa->ctx.soft_life = ipsec_xfrm->life.packets_soft_limit +1 ; + sa->w0.s.soft_life_dec =1 ; + } + +if (ipsec_xfrm->life.bytes_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.bytes_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } + +if (ipsec_xfrm->life.packets_hard_limit) { + sa->ctx.hard_life = ipsec_xfrm->life.packets_hard_limit +1 ; + sa->w0.s.hard_life_dec =1 ; + } +/* There are two words of CPT_CTX_HW_S for ucode to skip */ sa->w0.s.ctx_hdr_size =1 ; sa->w0.s.aop_valid =1 ;
drivers/crypto/cnxk/cn10k_cryptodev_ops.c +37 -11
69 lines not on this page · raw message
drivers/crypto/cnxk/cn9k_ipsec.c +5 -1
@@ -485,7 +485,11 @@ cn9k_ipsec_inb_sa_create(struct cnxk_cpt_qp *qp,static inline int cn9k_ipsec_xform_verify (struct rte_security_ipsec_xform *ipsec) { -RTE_SET_USED (ipsec); +if (ipsec->life.bytes_hard_limit !=0 || + ipsec->life.bytes_soft_limit !=0 || + ipsec->life.packets_hard_limit !=0 || + ipsec->life.packets_soft_limit !=0 ) +return -ENOTSUP ;return 0 ; }
Signature · 1 line
2.7.4
PATCH v4 3/6 crypto/octeontx2: add checks for life configuration
In reply to Anoob JosephLifetime tracking is not supported by hardware and is not implemented in software either. Return failure when lifetime is configured.
--- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/crypto/octeontx2/otx2_ipsec_po.h +6 -0
@@ -293,6 +293,12 @@ ipsec_po_xform_verify(struct rte_security_ipsec_xform *ipsec,struct rte_crypto_sym_xform *auth_xform, *cipher_xform;int ret; +if (ipsec->life.bytes_hard_limit !=0 || + ipsec->life.bytes_soft_limit !=0 || + ipsec->life.packets_hard_limit !=0 || + ipsec->life.packets_soft_limit !=0 ) +return -ENOTSUP ; +if (xform->type ==RTE_CRYPTO_SYM_XFORM_AEAD )return ipsec_po_xform_aead_verify (ipsec, xform);
Signature · 1 line
2.7.4
PATCH v4 4/6 test/crypto: add packets soft expiry cases
In reply to Anoob JosephAdd tests to validate packets soft expiry handling.
--- app/test/test_cryptodev.c | 21 +++++++++++++++++++-- app/test/test_cryptodev_security_ipsec.c | 18 ++++++++++++++++-- app/test/test_cryptodev_security_ipsec.h | 4 +++- 3 files changed, 38 insertions(+), 5 deletions(-)
app/test/test_cryptodev.c +19 -2
@@ -9045,7 +9045,7 @@ test_ipsec_proto_process(const struct ipsec_test_data td[],/* Process crypto operation */ process_crypto_request (dev_id, ut_params->op); - ret =test_ipsec_status_check (ut_params->op, flags, dir); + ret =test_ipsec_status_check (ut_params->op, flags, dir, i +1 );if (ret !=TEST_SUCCESS ) goto crypto_op_free;
@@ -9115,7 +9115,8 @@ test_ipsec_proto_all(const struct ipsec_test_flags *flags)unsigned int i, nb_pkts =1 , pass_cnt =0 ;int ret; -if (flags->iv_gen) +if (flags->iv_gen || + flags->sa_expiry_pkts_soft) nb_pkts =IPSEC_TEST_PACKETS_MAX ;for (i =0 ; i <RTE_DIM (aead_list); i++) {
@@ -9180,6 +9181,18 @@ test_ipsec_proto_iv_gen(const void *data __rte_unused) }static int +test_ipsec_proto_sa_exp_pkts_soft(const void *data __rte_unused) +{ +struct ipsec_test_flags flags; + +memset (&flags,0 ,sizeof (flags)); + + flags.sa_expiry_pkts_soft = true; + +return test_ipsec_proto_all (&flags); +} + +static int test_ipsec_proto_err_icv_corrupt(const void *data __rte_unused) {struct ipsec_test_flags flags;
@@ -14136,6 +14149,10 @@ static struct unit_test_suite ipsec_proto_testsuite = { ut_setup_security, ut_teardown, test_ipsec_proto_udp_encap),TEST_CASE_NAMED_ST ( +"SA expiry packets soft" , + ut_setup_security, ut_teardown, + test_ipsec_proto_sa_exp_pkts_soft), +TEST_CASE_NAMED_ST ("Negative test: ICV corruption" , ut_setup_security, ut_teardown, test_ipsec_proto_err_icv_corrupt),
app/test/test_cryptodev_security_ipsec.c +16 -2
@@ -173,6 +173,10 @@ test_ipsec_td_prepare(const struct crypto_param *param1,if (flags->iv_gen) td->ipsec_xform.options.iv_gen_disable =0 ; + +if (flags->sa_expiry_pkts_soft) + td->ipsec_xform.life.packets_soft_limit = +IPSEC_TEST_PACKETS_MAX -1 ; }RTE_SET_USED (param2);
@@ -395,7 +399,8 @@ test_ipsec_post_process(struct rte_mbuf *m, const struct ipsec_test_data *td,int test_ipsec_status_check (struct rte_crypto_op *op,const struct ipsec_test_flags *flags, -enum rte_security_ipsec_sa_direction dir) +enum rte_security_ipsec_sa_direction dir, +int pkt_num) {int ret =TEST_SUCCESS ;
@@ -406,7 +411,16 @@ test_ipsec_status_check(struct rte_crypto_op *op, } }else {if (op->status !=RTE_CRYPTO_OP_STATUS_SUCCESS ) { -printf ("Security op processing failed\n" ); +printf ("Security op processing failed [pkt_num: %d]\n" , + pkt_num); + ret =TEST_FAILED ; + } + } + +if (flags->sa_expiry_pkts_soft && pkt_num ==IPSEC_TEST_PACKETS_MAX ) { +if (!(op->aux_flags & +RTE_CRYPTO_OP_AUX_FLAGS_IPSEC_SOFT_EXPIRY )) { +printf ("SA soft expiry (pkts) test failed\n" ); ret =TEST_FAILED ; } }
app/test/test_cryptodev_security_ipsec.h +3 -1
@@ -49,6 +49,7 @@ struct ipsec_test_data {struct ipsec_test_flags {bool display_alg; +bool sa_expiry_pkts_soft;bool icv_corrupt;bool iv_gen;bool udp_encap;
@@ -114,6 +115,7 @@ int test_ipsec_post_process(struct rte_mbuf *m,int test_ipsec_status_check (struct rte_crypto_op *op,const struct ipsec_test_flags *flags, -enum rte_security_ipsec_sa_direction dir); +enum rte_security_ipsec_sa_direction dir, +int pkt_num);#endif
Signature · 1 line
2.7.4
PATCH v4 5/6 test/crypto: add packets hard expiry cases
In reply to Anoob JosephAdd tests to validate packets hard expiry handling.
--- app/test/test_cryptodev.c | 19 ++++++++++++++++++- app/test/test_cryptodev_security_ipsec.c | 22 +++++++++++++++++++--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 38 insertions(+), 4 deletions(-)
app/test/test_cryptodev.c +18 -1
@@ -9116,7 +9116,8 @@ test_ipsec_proto_all(const struct ipsec_test_flags *flags)int ret;if (flags->iv_gen || - flags->sa_expiry_pkts_soft) + flags->sa_expiry_pkts_soft || + flags->sa_expiry_pkts_hard) nb_pkts =IPSEC_TEST_PACKETS_MAX ;for (i =0 ; i <RTE_DIM (aead_list); i++) {
@@ -9193,6 +9194,18 @@ test_ipsec_proto_sa_exp_pkts_soft(const void *data __rte_unused) }static int +test_ipsec_proto_sa_exp_pkts_hard(const void *data __rte_unused) +{ +struct ipsec_test_flags flags; + +memset (&flags,0 ,sizeof (flags)); + + flags.sa_expiry_pkts_hard = true; + +return test_ipsec_proto_all (&flags); +} + +static int test_ipsec_proto_err_icv_corrupt(const void *data __rte_unused) {struct ipsec_test_flags flags;
@@ -14153,6 +14166,10 @@ static struct unit_test_suite ipsec_proto_testsuite = { ut_setup_security, ut_teardown, test_ipsec_proto_sa_exp_pkts_soft),TEST_CASE_NAMED_ST ( +"SA expiry packets hard" , + ut_setup_security, ut_teardown, + test_ipsec_proto_sa_exp_pkts_hard), +TEST_CASE_NAMED_ST ("Negative test: ICV corruption" , ut_setup_security, ut_teardown, test_ipsec_proto_err_icv_corrupt),
app/test/test_cryptodev_security_ipsec.c +19 -3
@@ -200,6 +200,10 @@ test_ipsec_td_update(struct ipsec_test_data td_inb[], td_inb[i].input_text.data[icv_pos] +=1 ; } +if (flags->sa_expiry_pkts_hard) + td_inb[i].ipsec_xform.life.packets_hard_limit = +IPSEC_TEST_PACKETS_MAX -1 ; +if (flags->udp_encap) td_inb[i].ipsec_xform.options.udp_encap =1 ;
@@ -285,9 +289,10 @@ test_ipsec_td_verify(struct rte_mbuf *m, const struct ipsec_test_data *td, uint8_t *output_text = rte_pktmbuf_mtod(m, uint8_t *);uint32_t skip, len =rte_pktmbuf_pkt_len (m); -/* For negative tests, no need to do verification */ -if (flags->icv_corrupt && - td->ipsec_xform.direction ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS ) +/* For tests with status as error for test success, skip verification */ +if (td->ipsec_xform.direction ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && + (flags->icv_corrupt || + flags->sa_expiry_pkts_hard))return TEST_SUCCESS ; if (td->ipsec_xform.direction == RTE_SECURITY_IPSEC_SA_DIR_EGRESS &&
@@ -404,6 +409,17 @@ test_ipsec_status_check(struct rte_crypto_op *op, {int ret =TEST_SUCCESS ; +if (dir ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && + flags->sa_expiry_pkts_hard && + pkt_num ==IPSEC_TEST_PACKETS_MAX ) { +if (op->status !=RTE_CRYPTO_OP_STATUS_ERROR ) { +printf ("SA hard expiry (pkts) test failed\n" ); +return TEST_FAILED ; + }else { +return TEST_SUCCESS ; + } + } +if (dir ==RTE_SECURITY_IPSEC_SA_DIR_INGRESS && flags->icv_corrupt) {if (op->status !=RTE_CRYPTO_OP_STATUS_ERROR ) {printf ("ICV corruption test case failed\n" );
app/test/test_cryptodev_security_ipsec.h +1 -0
@@ -50,6 +50,7 @@ struct ipsec_test_data {struct ipsec_test_flags {bool display_alg;bool sa_expiry_pkts_soft; +bool sa_expiry_pkts_hard;bool icv_corrupt;bool iv_gen;bool udp_encap;
Signature · 1 line
2.7.4
PATCH v4 6/6 examples/ipsec-secgw: clear soft expiry configuration
In reply to Anoob JosephSoft expiry is not a mandatory IPsec feature. It is verified separately with IPsec unit tests. So configuration of the same is not required. Also, soft expiry tracking can cause perf degradation with some PMDs. Since a separate UT is available and the same setting in ipsec-secgw is not verifying the functionality, remove the same by clearing life configuration.
--- examples/ipsec-secgw/ipsec.c | 1 - examples/ipsec-secgw/ipsec.h | 2 -- 2 files changed, 3 deletions(-)
examples/ipsec-secgw/ipsec.c +0 -1
@@ -49,7 +49,6 @@ set_ipsec_conf(struct ipsec_sa *sa, struct rte_security_ipsec_xform *ipsec) }/* TODO support for Transport */ } - ipsec->life.packets_soft_limit =IPSEC_OFFLOAD_PKTS_SOFTLIMIT ; ipsec->replay_win_sz = app_sa_prm.window_size; ipsec->options.esn = app_sa_prm.enable_esn; ipsec->options.udp_encap = sa->udp_encap;
examples/ipsec-secgw/ipsec.h +0 -2
@@ -23,8 +23,6 @@#define MAX_DIGEST_SIZE 32/* Bytes -- 256 bits */ -#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00 -#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ sizeof(struct rte_crypto_sym_op))
Signature · 1 line
2.7.4
Quoted 10 lines
Add SA lifetime configuration in security. SA lifetime tracking can be offloaded on supported PMDs.
SA lifetime would cover soft & hard expiry in units of number of packets and bytes. When SA soft expiry happens, the packet is successfuly processed but with additional expiry notification. Crypto op structure, ``rte_crypto_op`` is updated to cover such notifications with lookaside protocol offloads.
SA hard expiration would cause IPsec processing to return an error.
Quoted 8 lines
PMDs
crypto_cn10k,crypto_cn9kandcrypto_octeontx2are updated with their
respective lifetime tracking capabilities. Unit tests are added for soft and hard expiry with number of packets.Changes in v4:
- Removed extra comments around auxilliary flag macros (comment from Konstantin)
Series
Applied to dpdk-next-crypto
Deprecation notice removed for the feature supported. Release notes are also reworded.